/proc/stat: fix wrong cpustat gnice value
PATCH 1/1 /proc/stat: fix wrong cpustat gnice value
The value being used for guest_nice should be CPUTIME_GUEST_NICE and not CPUTIME_USER.
Fixes 26dae145a76c "procfs: Use all-in-one vtime aware kcpustat accessor"
Signed-off-by Flavio Leitner <[email protected]>
--- fs/proc/stat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/proc/stat.c +2 -2
@@ -134,7 +134,7 @@ static int show_stat(struct seq_file *p, void *v) softirq += cpustat[CPUTIME_SOFTIRQ ]; steal += cpustat[CPUTIME_STEAL ]; guest += cpustat[CPUTIME_GUEST ]; - guest_nice += cpustat[CPUTIME_USER ]; + guest_nice += cpustat[CPUTIME_GUEST_NICE ]; sum +=kstat_cpu_irqs_sum (i); sum +=arch_irq_stat_cpu (i);
@@ -175,7 +175,7 @@ static int show_stat(struct seq_file *p, void *v) softirq = cpustat[CPUTIME_SOFTIRQ ]; steal = cpustat[CPUTIME_STEAL ]; guest = cpustat[CPUTIME_GUEST ]; - guest_nice = cpustat[CPUTIME_USER ]; + guest_nice = cpustat[CPUTIME_GUEST_NICE ];seq_printf (p,"cpu%d" , i);seq_put_decimal_ull (p," " ,nsec_to_clock_t (user));seq_put_decimal_ull (p," " ,nsec_to_clock_t (nice));
Signature · 1 line
2.23.0
Quoted 5 lines · Flavio Leitner
The value being used for
guest_niceshould beCPUTIME_GUEST_NICEand notCPUTIME_USER.Fixes 26dae145a76c "procfs: Use all-in-one vtime aware kcpustat accessor"Signed-off-by Flavio Leitner <[email protected]>
Good catch, thanks!
Quoted 29 lines
--- fs/proc/stat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/proc/stat.c +2
-2@@ -134,7 +134,7 @@ static int show_stat(struct seq_file *p, void *v) softirq += cpustat[CPUTIME_SOFTIRQ ]; steal += cpustat[CPUTIME_STEAL ]; guest += cpustat[CPUTIME_GUEST ]; - guest_nice += cpustat[CPUTIME_USER ]; + guest_nice += cpustat[CPUTIME_GUEST_NICE ]; sum +=kstat_cpu_irqs_sum (i); sum +=arch_irq_stat_cpu (i);@@ -175,7 +175,7 @@ static int show_stat(struct seq_file *p, void *v) softirq = cpustat[CPUTIME_SOFTIRQ ]; steal = cpustat[CPUTIME_STEAL ]; guest = cpustat[CPUTIME_GUEST ]; - guest_nice = cpustat[CPUTIME_USER ]; + guest_nice = cpustat[CPUTIME_GUEST_NICE ];seq_printf (p,"cpu%d" , i);seq_put_decimal_ull (p," " ,nsec_to_clock_t (user));seq_put_decimal_ull (p," " ,nsec_to_clock_t (nice));Signature · 1 line
2.23.0