ASoC: fsl_audmix: add missed pm_runtime_disable
Subsystems (3)
PATCH RESEND 1/1 ASoC: fsl_audmix: add missed pm_runtime_disable
The driver forgets to call pm_runtime_disable in probe failure and remove.
Add the missed calls to fix it.
Signed-off-by Chuhong Yuan <[email protected]>
--- sound/soc/fsl/fsl_audmix.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
sound/soc/fsl/fsl_audmix.c +8 -1
@@ -505,15 +505,20 @@ static int fsl_audmix_probe(struct platform_device *pdev) ARRAY_SIZE(fsl_audmix_dai));if (ret) {dev_err (dev,"failed to register ASoC DAI\n" ); -return ret; + goto err_disable_pm; } priv->pdev =platform_device_register_data (dev, mdrv,0 ,NULL ,0 );if (IS_ERR (priv->pdev)) { ret =PTR_ERR (priv->pdev);dev_err (dev,"failed to register platform %s: %d\n" , mdrv, ret); + goto err_disable_pm; } +return 0 ; + +err_disable_pm: +pm_runtime_disable (dev);return ret; }
@@ -521,6 +526,8 @@ static int fsl_audmix_remove(struct platform_device *pdev) {struct fsl_audmix *priv =dev_get_drvdata (&pdev->dev); +pm_runtime_disable (&pdev->dev); +if (priv->pdev)platform_device_unregister (priv->pdev);
Signature · 1 line
2.24.0
Quoted 5 lines · Chuhong Yuan
The driver forgets to call
pm_runtime_disablein probe failure and remove.
Add the missed calls to fix it.Signed-off-by Chuhong Yuan <[email protected]>
Acked-by Nicolin Chen <[email protected]>
Thanks
Quoted 42 lines
--- sound/soc/fsl/fsl_audmix.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)sound/soc/fsl/fsl_audmix.c +8
-1@@ -505,15 +505,20 @@ static int fsl_audmix_probe(struct platform_device *pdev) ARRAY_SIZE(fsl_audmix_dai));if (ret) {dev_err (dev,"failed to register ASoC DAI\n" ); -return ret; + goto err_disable_pm; } priv->pdev =platform_device_register_data (dev, mdrv,0 ,NULL ,0 );if (IS_ERR (priv->pdev)) { ret =PTR_ERR (priv->pdev);dev_err (dev,"failed to register platform %s: %d\n" , mdrv, ret); + goto err_disable_pm; } +return 0 ; + +err_disable_pm: +pm_runtime_disable (dev);return ret; }@@ -521,6 +526,8 @@ static int fsl_audmix_remove(struct platform_device *pdev) {struct fsl_audmix *priv =dev_get_drvdata (&pdev->dev); +pm_runtime_disable (&pdev->dev); +if (priv->pdev)platform_device_unregister (priv->pdev);Signature · 1 line
2.24.0