Skip to contentSkip to conversation

End of the MTD makefile cleanup

PATCH Superseded Miquel Raynal 3 participants 13 messages Oct 25, 2019 – Dec 5, 2019

Subsystems (3)
lore
Share & tools
lore

Miquel Raynal

author maintainer
#0 lore raw

v6 cover End of the MTD makefile cleanup

As rightfully pointed by Jagan, I should have dropped the dependency of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series.

Instead of sending the 40 patches again, here are only the last three patches with:
* patch 1 (24/26) being corrected as per Jagan's comment
* patch 2 (25/26) is untouched
* patch 3 (26/26) is almost untouched but I had to resolve a conflict due to patch 1.

Thanks,
Miquèl

Miquel Raynal (3):
cmd: nand/sf: isolate legacy code
cmd: make MTD commands depend on MTD
mtd: Makefile: deep cleanup

 Makefile                  |  5 --
 cmd/Kconfig               | 10 ++--
 cmd/Makefile              |  3 ++
 cmd/legacy-mtd-utils.c    | 99 +++++++++++++++++++++++++++++++++++++++
 cmd/legacy-mtd-utils.h    | 14 ++++++
 cmd/nand.c                |  2 +
 cmd/sf.c                  |  2 +
 drivers/Makefile          |  7 +--
 drivers/mtd/Makefile      | 50 ++++++++++++++------
 drivers/mtd/mtd_uboot.c   | 94 -------------------------------------
 drivers/mtd/nand/Makefile |  5 ++
 include/linux/mtd/mtd.h   |  6 ---
 12 files changed, 169 insertions(+), 128 deletions(-)
 create mode 100644 cmd/legacy-mtd-utils.c
 create mode 100644 cmd/legacy-mtd-utils.h
Signature · 1 line
2.20.1
author maintainer
#1 lore raw

PATCH v6 1/3 cmd: nand/sf: isolate legacy code

The 'sf' command is not supposed to rely on the MTD stack, but both 'sf' and 'nand' commands use helpers located in mtd_uboot.c. Despite their location, these functions do not depend at all on the MTD stack.

This file (drivers/mtd/mtd_uboot.c) is only compiled if CONFIG_MTD is selected, which is inconsistent with the current situation. Solve this by moving these three functions (which are only used by the above two commands) out of mtd_uboot.c and put them in a C file only compiled with cmd/sf.c and cmd/nand.c.

---
 cmd/Makefile            |  3 ++
 cmd/legacy-mtd-utils.c  | 99 +++++++++++++++++++++++++++++++++++++++++
 cmd/legacy-mtd-utils.h  | 14 ++++++
 cmd/nand.c              |  2 +
 cmd/sf.c                |  2 +
 drivers/mtd/Makefile    |  2 +-
 drivers/mtd/mtd_uboot.c | 94 --------------------------------------
 include/linux/mtd/mtd.h |  6 ---
 8 files changed, 121 insertions(+), 101 deletions(-)
 create mode 100644 cmd/legacy-mtd-utils.c
 create mode 100644 cmd/legacy-mtd-utils.h
cmd/Makefile +3 -0
index ac843b4b16..88b77c9f78 100644
@@ -97,6 +97,9 @@ obj-$(CONFIG_CMD_MMC) += mmc.o
 obj-$(CONFIG_MP) += mp.o
 obj-$(CONFIG_CMD_MTD) += mtd.o
 obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o
+ifneq ($(CONFIG_CMD_NAND)$(CONFIG_CMD_SF),)
+obj-y += legacy-mtd-utils.o
+endif
 obj-$(CONFIG_CMD_NAND) += nand.o
 obj-$(CONFIG_CMD_NET) += net.o
 obj-$(CONFIG_CMD_NVEDIT_EFI) += nvedit_efi.o
cmd/legacy-mtd-utils.c new file +99 -0

99 lines not on this page · raw message

cmd/legacy-mtd-utils.h new file +14 -0
new file mode 100644
index 0000000000..b31342bcb7
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __LEGACY_MTD_UTILS_H
+#define __LEGACY_MTD_UTILS_H
+
+int get_part(const char *partname, int *idx, loff_t *off, loff_t *size,
+	     loff_t *maxsize, int devtype);
+int mtd_arg_off(const char *arg, int *idx, loff_t *off, loff_t *size,
+		loff_t *maxsize, int devtype, uint64_t chipsize);
+int mtd_arg_off_size(int argc, char *const argv[], int *idx, loff_t *off,
+		     loff_t *size, loff_t *maxsize, int devtype,
+		     uint64_t chipsize);
+
+#endif /* LEGACY_MTD_UTILS_H */
cmd/nand.c +2 -0
index 27efef20bc..f40936cf68 100644
@@ -30,6 +30,8 @@
 #include <jffs2/jffs2.h>
 #include <nand.h>
 
+#include "legacy-mtd-utils.h"
+
 #if defined(CONFIG_CMD_MTDPARTS)
 
 /* partition handling routines */
cmd/sf.c +2 -0
index 6ccf98ae51..e993b3e5ad 100644
@@ -18,6 +18,8 @@
 #include <asm/io.h>
 #include <dm/device-internal.h>
 
+#include "legacy-mtd-utils.h"
+
 static struct spi_flash *flash;
 
 /*
drivers/mtd/Makefile +1 -1
index 3542042245..c9a96adace 100644
@@ -3,7 +3,7 @@
 # (C) Copyright 2000-2007
 # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
 
-ifneq (,$(findstring y,$(CONFIG_MTD)$(CONFIG_CMD_NAND)$(CONFIG_CMD_ONENAND)$(CONFIG_CMD_SF)$(CONFIG_CMD_MTD)))
+ifneq (,$(findstring y,$(CONFIG_MTD)$(CONFIG_CMD_ONENAND)$(CONFIG_CMD_MTD)))
 obj-y += mtdcore.o mtd_uboot.o
 endif
 obj-$(CONFIG_DM_MTD) += mtd-uclass.o
drivers/mtd/mtd_uboot.c +0 -94

103 lines not on this page · raw message

include/linux/mtd/mtd.h +0 -6
index e3549f0a46..ceffd994de 100644
@@ -588,12 +588,6 @@ struct mtd_info *__mtd_next_device(int i);
 	     (mtd) != NULL;				\
 	     (mtd) = __mtd_next_device(mtd->index + 1))
 
-int mtd_arg_off(const char *arg, int *idx, loff_t *off, loff_t *size,
-		loff_t *maxsize, int devtype, uint64_t chipsize);
-int mtd_arg_off_size(int argc, char *const argv[], int *idx, loff_t *off,
-		     loff_t *size, loff_t *maxsize, int devtype,
-		     uint64_t chipsize);
-
 /* drivers/mtd/mtdcore.c */
 void mtd_get_len_incl_bad(struct mtd_info *mtd, uint64_t offset,
 			  const uint64_t length, uint64_t *len_incl_bad,
Signature · 1 line
2.20.1
#2 lore raw

PATCH v6 1/3 cmd: nand/sf: isolate legacy code

Quoted 5 lines · Miquel Raynal

The 'sf' command is not supposed to rely on the MTD stack, but both 'sf' and 'nand' commands use helpers located in mtd_uboot.c. Despite their location, these functions do not depend at all on the MTD stack.

Quoted 7 lines

This file (drivers/mtd/mtd_uboot.c) is only compiled if CONFIG_MTD is selected, which is inconsistent with the current situation. Solve this by moving these three functions (which are only used by the above two commands) out of mtd_uboot.c and put them in a C file only compiled with cmd/sf.c and cmd/nand.c.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191204/c27fa452/attachment.sig>
author maintainer
#3 lore raw

PATCH v6 2/3 cmd: make MTD commands depend on MTD

In reply to Miquel Raynal

Defconfigs have been fixed, now we can add proper dependencies in Kconfig. SPI FLASH is still not dependent on MTD (deeper rework needed).

---
 cmd/Kconfig | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
cmd/Kconfig +7 -3
index 33adf29a96..01d4330e04 100644
@@ -799,6 +799,7 @@ config CMD_FDC
 config CMD_FLASH
 	bool "flinfo, erase, protect"
 	default y
+	depends on MTD
 	help
 	  NOR flash support.
 	    flinfo - print FLASH memory information
@@ -988,6 +989,7 @@ config CMD_MMC_SWRITE
 
 config CMD_MTD
 	bool "mtd"
+	depends on MTD
 	select MTD_PARTITIONS
 	help
 	  MTD commands support.
@@ -995,6 +997,7 @@ config CMD_MTD
 config CMD_NAND
 	bool "nand"
 	default y if NAND_SUNXI
+	depends on MTD_RAW_NAND
 	help
 	  NAND support.
 
@@ -1026,6 +1029,7 @@ config CMD_NVME
 
 config CMD_ONENAND
 	bool "onenand - access to onenand device"
+	depends on MTD
 	help
 	  OneNAND is a brand of NAND ('Not AND' gate) flash which provides
 	  various useful features. This command allows reading, writing,
@@ -1895,7 +1899,7 @@ config CMD_JFFS2
 
 config CMD_MTDPARTS
 	bool "MTD partition support"
-	select MTD if (CMD_NAND || NAND)
+	depends on MTD
 	help
 	  MTD partitioning tool support.
 	  It is strongly encouraged to avoid using this command
@@ -1915,14 +1919,14 @@ config CMD_MTDPARTS_SPREAD
 
 config MTDIDS_DEFAULT
 	string "Default MTD IDs"
-	depends on MTD_PARTITIONS || CMD_MTDPARTS || CMD_NAND || CMD_FLASH
+	depends on MTD || SPI_FLASH
 	help
 	  Defines a default MTD IDs list for use with MTD partitions in the
 	  Linux MTD command line partitions format.
 
 config MTDPARTS_DEFAULT
 	string "Default MTD partition scheme"
-	depends on MTD_PARTITIONS || CMD_MTDPARTS || CMD_NAND || CMD_FLASH
+	depends on MTD || SPI_FLASH
 	help
 	  Defines a default MTD partitioning scheme in the Linux MTD command
 	  line partitions format
Signature · 1 line
2.20.1
#4 lore raw

PATCH v6 2/3 cmd: make MTD commands depend on MTD

Quoted 4 lines · Miquel Raynal

Defconfigs have been fixed, now we can add proper dependencies in Kconfig. SPI FLASH is still not dependent on MTD (deeper rework needed).

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191204/827ff7d6/attachment.sig>
author maintainer
#5 lore raw

PATCH v6 3/3 mtd: Makefile: deep cleanup

In reply to Miquel Raynal

Move MTD-related lines out of the root Makefile. Put them in their respective directories. Enclose some of these new lines to skip them when building the SPL. MTD core files and some MTD device drivers are compiled in a mtd.o object and included in the final object only if MTD support is required (there are two different symbols for that, one for U-Boot and one for the SPL).

Now that all defconfigs have been fixed, we can stop the logic where enabling a command selects the core files to compile. This logic is broken since selecting a symbol with a 'depends on' will not enforce this secondary dependency.

---
 Makefile                  |  5 ----
 drivers/Makefile          |  7 ++----
 drivers/mtd/Makefile      | 50 +++++++++++++++++++++++++++------------
 drivers/mtd/nand/Makefile |  5 ++++
 4 files changed, 42 insertions(+), 25 deletions(-)
Makefile +0 -5
index 1d9ade948b..e55c0b236e 100644
@@ -708,11 +708,6 @@ libs-y += drivers/
 libs-y += drivers/dma/
 libs-y += drivers/gpio/
 libs-y += drivers/i2c/
-libs-y += drivers/mtd/
-libs-$(CONFIG_CMD_NAND) += drivers/mtd/nand/raw/
-libs-y += drivers/mtd/onenand/
-libs-$(CONFIG_CMD_UBI) += drivers/mtd/ubi/
-libs-y += drivers/mtd/spi/
 libs-y += drivers/net/
 libs-y += drivers/net/phy/
 libs-y += drivers/power/ \
drivers/Makefile +2 -5
index a4bb5e4975..708aa2a1a7 100644
@@ -11,7 +11,7 @@ obj-$(CONFIG_$(SPL_TPL_)I2C_SUPPORT) += i2c/
 obj-$(CONFIG_$(SPL_TPL_)INPUT) += input/
 obj-$(CONFIG_$(SPL_TPL_)LED) += led/
 obj-$(CONFIG_$(SPL_TPL_)MMC_SUPPORT) += mmc/
-obj-$(CONFIG_$(SPL_TPL_)NAND_SUPPORT) += mtd/nand/raw/
+obj-y += mtd/
 obj-$(CONFIG_$(SPL_TPL_)PCH_SUPPORT) += pch/
 obj-$(CONFIG_$(SPL_TPL_)PCI) += pci/
 obj-$(CONFIG_$(SPL_TPL_)PHY) += phy/
@@ -19,7 +19,6 @@ obj-$(CONFIG_$(SPL_TPL_)PINCTRL) += pinctrl/
 obj-$(CONFIG_$(SPL_TPL_)RAM) += ram/
 obj-$(CONFIG_$(SPL_TPL_)RTC_SUPPORT) += rtc/
 obj-$(CONFIG_$(SPL_TPL_)SERIAL_SUPPORT) += serial/
-obj-$(CONFIG_$(SPL_TPL_)SPI_FLASH_SUPPORT) += mtd/spi/
 obj-$(CONFIG_$(SPL_TPL_)SPI_SUPPORT) += spi/
 obj-$(CONFIG_$(SPL_TPL_)TIMER) += timer/
 obj-$(CONFIG_$(SPL_TPL_)VIRTIO) += virtio/
@@ -42,9 +41,6 @@ obj-$(CONFIG_SPL_POWER_SUPPORT) += power/ power/pmic/
 obj-$(CONFIG_SPL_POWER_SUPPORT) += power/regulator/
 obj-$(CONFIG_SPL_POWER_DOMAIN) += power/domain/
 obj-$(CONFIG_SPL_DM_RESET) += reset/
-obj-$(CONFIG_SPL_MTD_SUPPORT) += mtd/
-obj-$(CONFIG_SPL_ONENAND_SUPPORT) += mtd/onenand/
-obj-$(CONFIG_SPL_UBI) += mtd/ubispl/
 obj-$(CONFIG_SPL_DMA_SUPPORT) += dma/
 obj-$(CONFIG_SPL_ETH_SUPPORT) += net/
 obj-$(CONFIG_SPL_ETH_SUPPORT) += net/phy/
@@ -102,6 +98,7 @@ obj-$(CONFIG_QE) += qe/
 obj-$(CONFIG_U_QE) += qe/
 obj-y += mailbox/
 obj-y += memory/
+obj-y += mtd/
 obj-y += pwm/
 obj-y += reset/
 obj-y += input/
drivers/mtd/Makefile +35 -15

55 lines not on this page · raw message

drivers/mtd/nand/Makefile +5 -0
index a358bc680e..96e186600a 100644
@@ -1,5 +1,10 @@
 # SPDX-License-Identifier: GPL-2.0+
 
+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TPL_BUILD),)
 nandcore-objs := core.o bbt.o
 obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o
+obj-$(CONFIG_MTD_RAW_NAND) += raw/
 obj-$(CONFIG_MTD_SPI_NAND) += spi/
+else
+obj-$(CONFIG_$(SPL_TPL_)NAND_SUPPORT) += raw/
+endif
Signature · 1 line
2.20.1
#6 lore raw

PATCH v6 3/3 mtd: Makefile: deep cleanup

Quoted 7 lines · Miquel Raynal

Move MTD-related lines out of the root Makefile. Put them in their respective directories. Enclose some of these new lines to skip them when building the SPL. MTD core files and some MTD device drivers are compiled in a mtd.o object and included in the final object only if MTD support is required (there are two different symbols for that, one for U-Boot and one for the SPL).

Quoted 6 lines

Now that all defconfigs have been fixed, we can stop the logic where enabling a command selects the core files to compile. This logic is broken since selecting a symbol with a 'depends on' will not enforce this secondary dependency.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191204/784dad3b/attachment.sig>
#7 lore raw

v6 cover End of the MTD makefile cleanup

In reply to Miquel Raynal
Quoted 12 lines · Miquel Raynal

As rightfully pointed by Jagan, I should have dropped the dependency of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series.

Instead of sending the 40 patches again, here are only the last three patches with:
* patch 1 (24/26) being corrected as per Jagan's comment
* patch 2 (25/26) is untouched
* patch 3 (26/26) is almost untouched but I had to resolve a conflict due to patch 1.

Quoted 7 lines

Thanks,
Miquèl

Miquel Raynal (3):
cmd: nand/sf: isolate legacy code
cmd: make MTD commands depend on MTD
mtd: Makefile: deep cleanup

author maintainer
#8 lore raw

v6 cover End of the MTD makefile cleanup

Hi Jagan,

Jagan Teki <[email protected]> wrote on Sat, 26 Oct 2019 15:50:06 +0530:

Quoted 17 lines
Quoted 15 lines · Miquel Raynal

As rightfully pointed by Jagan, I should have dropped the dependency of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series.

Instead of sending the 40 patches again, here are only the last three patches with:
* patch 1 (24/26) being corrected as per Jagan's comment
* patch 2 (25/26) is untouched
* patch 3 (26/26) is almost untouched but I had to resolve a conflict due to patch 1.

Thanks,
Miquèl

Quoted 6 lines
Quoted 4 lines

Miquel Raynal (3):
cmd: nand/sf: isolate legacy code
cmd: make MTD commands depend on MTD
mtd: Makefile: deep cleanup

Thanks!

Who is supposed to take the two series?

Miquèl

#9 lore raw

v6 cover End of the MTD makefile cleanup

Quoted 28 lines · Miquel Raynal

Hi Jagan,

Jagan Teki <[email protected]> wrote on Sat, 26 Oct 2019 15:50:06 +0530:

Quoted 22 lines
Quoted 19 lines · Miquel Raynal

As rightfully pointed by Jagan, I should have dropped the dependency of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series.

Instead of sending the 40 patches again, here are only the last three patches with:
* patch 1 (24/26) being corrected as per Jagan's comment
* patch 2 (25/26) is untouched
* patch 3 (26/26) is almost untouched but I had to resolve a conflict due to patch 1.

Thanks,
Miquèl

Miquel Raynal (3):
cmd: nand/sf: isolate legacy code
cmd: make MTD commands depend on MTD
mtd: Makefile: deep cleanup

Quoted 5 lines
Quoted 1 line

Thanks!

Who is supposed to take the two series?

Looks like there are several defconfig changes in master, please rebase on master and send your branch (some where from github or so).

#10 lore raw

v6 cover End of the MTD makefile cleanup

Quoted 29 lines · Jagan Teki
Quoted 28 lines · Miquel Raynal

Hi Jagan,

Jagan Teki <[email protected]> wrote on Sat, 26 Oct 2019 15:50:06 +0530:

Quoted 22 lines
Quoted 19 lines · Miquel Raynal

As rightfully pointed by Jagan, I should have dropped the dependency of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series.

Instead of sending the 40 patches again, here are only the last three patches with:
* patch 1 (24/26) being corrected as per Jagan's comment
* patch 2 (25/26) is untouched
* patch 3 (26/26) is almost untouched but I had to resolve a conflict due to patch 1.

Thanks,
Miquèl

Miquel Raynal (3):
cmd: nand/sf: isolate legacy code
cmd: make MTD commands depend on MTD
mtd: Makefile: deep cleanup

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Thanks!

Who is supposed to take the two series?

Looks like there are several defconfig changes in master, please rebase on master and send your branch (some where from github or so).

If it's just defconfigs, I'll grab it so I can have the series also be the only thing in the tree when I do the before/after size check. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191027/a520e7df/attachment.sig>
#11 lore raw

v6 cover End of the MTD makefile cleanup

Quoted 39 lines · On Sun, 27 Oct, 2019, 15:06 Tom Rini, <[email protected]> wrote:
Quoted 1 line · Jagan Teki

On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal <[email protected]>

Quoted 10 lines · wrote:
Quoted 10 lines

Hi Jagan,

Jagan Teki <[email protected]> wrote on Sat, 26 Oct 2019 15:50:06 +0530:

Quoted 4 lines
Quoted 2 lines · Miquel Raynal

As rightfully pointed by Jagan, I should have dropped the

dependency

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the

"MTD

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series.

Instead of sending the 40 patches again, here are only the last

three

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

patches with:
* patch 1 (24/26) being corrected as per Jagan's comment
* patch 2 (25/26) is untouched
* patch 3 (26/26) is almost untouched but I had to resolve a

conflict

Quoted 14 lines
Quoted 14 lines
Quoted 11 lines
Quoted 9 lines

due to patch 1.

Thanks,
Miquèl

Miquel Raynal (3):
cmd: nand/sf: isolate legacy code
cmd: make MTD commands depend on MTD
mtd: Makefile: deep cleanup

Thanks!

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

Who is supposed to take the two series?

Looks like there are several defconfig changes in master, please rebase on master and send your branch (some where from github or so).

If it's just defconfigs, I'll grab it so I can have the series also be the only thing in the tree when I do the before/after size check. Thanks!

Thanks Tom.

Quoted 1 line
author maintainer
#12 lore raw

v6 cover End of the MTD makefile cleanup

Hello,

Jagan Teki <[email protected]> wrote on Sun, 27 Oct 2019 15:24:40 +0100:

Quoted 46 lines · On Sun, 27 Oct, 2019, 15:06 Tom Rini, <[email protected]> wrote:
Quoted 45 lines · Jagan Teki
Quoted 1 line

On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal <[email protected]>

Quoted 10 lines · wrote:
Quoted 10 lines

Hi Jagan,

Jagan Teki <[email protected]> wrote on Sat, 26 Oct 2019 15:50:06 +0530:

Quoted 4 lines
Quoted 2 lines · Miquel Raynal

As rightfully pointed by Jagan, I should have dropped the

dependency

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the

"MTD

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series.

Instead of sending the 40 patches again, here are only the last

three

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

patches with:
* patch 1 (24/26) being corrected as per Jagan's comment
* patch 2 (25/26) is untouched
* patch 3 (26/26) is almost untouched but I had to resolve a

conflict

Quoted 18 lines
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines

due to patch 1.

Thanks,
Miquèl

Miquel Raynal (3):
cmd: nand/sf: isolate legacy code
cmd: make MTD commands depend on MTD
mtd: Makefile: deep cleanup

Quoted 5 lines
Quoted 1 line

Thanks!

Who is supposed to take the two series?

Looks like there are several defconfig changes in master, please rebase on master and send your branch (some where from github or so).

Quoted 8 lines
Quoted 4 lines

If it's just defconfigs, I'll grab it so I can have the series also be the only thing in the tree when I do the before/after size check. Thanks!

Thanks Tom.

Quoted 1 line

Great! Thanks Tom.

Miquèl