ath11k: add some missing __packed qualifiers
PATCH 1/2 ath11k: add some missing __packed qualifiers
A few of the WMI parameter structs were missing this.
--- drivers/net/wireless/ath/ath11k/wmi.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath11k/wmi.h +3 -3
@@ -4562,12 +4562,12 @@ struct wmi_twt_enable_params_cmd {u32 mode_check_interval;u32 add_sta_slot_interval;u32 remove_sta_slot_interval; -}; +} __packed;struct wmi_twt_disable_params_cmd {u32 tlv_header;u32 pdev_id; -}; +} __packed;enum WMI_HOST_TWT_COMMAND {WMI_HOST_TWT_COMMAND_REQUEST_TWT =0 ,
@@ -4682,7 +4682,7 @@ struct wmi_obss_spatial_reuse_params_cmd {s32 obss_min;s32 obss_max;u32 vdev_id; -}; +} __packed;struct target_resource_config {u32 num_vdevs;
Signature · 7 lines
2.20.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 2/2 ath11k: explicitly cast wmi commands to their correct struct type
Three of the WMI command handlers were not casting to the right data type. Lets make the code consistent with the other handlers.
--- drivers/net/wireless/ath/ath11k/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath11k/wmi.c +3 -3
@@ -2517,7 +2517,7 @@ ath11k_wmi_send_twt_enable_cmd(struct ath11k *ar, u32 pdev_id)if (!skb)return -ENOMEM ; - cmd = (void *)skb->data; + cmd = (struct wmi_twt_enable_params_cmd *)skb->data; cmd->tlv_header =FIELD_PREP (WMI_TLV_TAG ,WMI_TAG_TWT_ENABLE_CMD ) |FIELD_PREP (WMI_TLV_LEN , len -TLV_HDR_SIZE ); cmd->pdev_id = pdev_id;
@@ -2568,7 +2568,7 @@ ath11k_wmi_send_twt_disable_cmd(struct ath11k *ar, u32 pdev_id)if (!skb)return -ENOMEM ; - cmd = (void *)skb->data; + cmd = (struct wmi_twt_disable_params_cmd *)skb->data; cmd->tlv_header =FIELD_PREP (WMI_TLV_TAG ,WMI_TAG_TWT_DISABLE_CMD ) |FIELD_PREP (WMI_TLV_LEN , len -TLV_HDR_SIZE ); cmd->pdev_id = pdev_id;
@@ -2768,7 +2768,7 @@ ath11k_wmi_send_obss_spr_cmd(struct ath11k *ar, u32 vdev_id,if (!skb)return -ENOMEM ; - cmd = (void *)skb->data; + cmd = (struct wmi_obss_spatial_reuse_params_cmd *)skb->data; cmd->tlv_header =FIELD_PREP (WMI_TLV_TAG ,WMI_TAG_OBSS_SPATIAL_REUSE_SET_CMD ) |FIELD_PREP (WMI_TLV_LEN , len -TLV_HDR_SIZE );
Signature · 1 line
2.20.1
Re: [PATCH 2/2] ath11k: explicitly cast wmi commands to their correct struct type
Quoted 5 lines · John Crispin
Three of the WMI command handlers were not casting to the right data type. Lets make the code consistent with the other handlers.
Signed-off-by John Crispin <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
77ea8b455ca1 ath11k: explicitly cast wmi commands to their correct struct type
Signature · 3 lines
https://patchwork.kernel.org/patch/11274221/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH 2/2] ath11k: explicitly cast wmi commands to their correct struct type
In reply to John CrispinQuoted 5 lines · John Crispin
Three of the WMI command handlers were not casting to the right data type. Lets make the code consistent with the other handlers.
Signed-off-by John Crispin <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
77ea8b455ca1 ath11k: explicitly cast wmi commands to their correct struct type
Signature · 8 lines
https://patchwork.kernel.org/patch/11274221/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 4 lines · John Crispin
A few of the WMI parameter structs were missing this.
Signed-off-by John Crispin <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
20c3c4fd3967 ath11k: add some missing __packed qualifiers
Signature · 3 lines
https://patchwork.kernel.org/patch/11274223/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 4 lines · John Crispin
A few of the WMI parameter structs were missing this.
Signed-off-by John Crispin <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
20c3c4fd3967 ath11k: add some missing __packed qualifiers
Signature · 8 lines
https://patchwork.kernel.org/patch/11274223/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k