Skip to contentSkip to conversation

drm/exynos: gsc: add missed component_del

PATCH RESEND In review Chuhong Yuan 2 participants 2 messages Dec 5, 2019 – Dec 13, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drm/exynos: gsc: add missed component_del

The driver forgets to call component_del in remove to match component_add in probe.
Add the missed call to fix it.

---
 drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/exynos/exynos_drm_gsc.c +1 -0
index 7ae087b0504d..88b6fcaa20be 100644
@@ -1313,6 +1313,7 @@ static int gsc_remove(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 
+	component_del(dev, &gsc_component_ops);
 	pm_runtime_dont_use_autosuspend(dev);
 	pm_runtime_disable(dev);
 
Signature · 1 line
2.24.0
maintainer
#1 lore raw

You don't need to resend this. Already merged to exynos-drm-fixes three weeks ago.

Thanks,
Inki Dae

19. 12. 6. 오전 1:05에 Chuhong Yuan 이(가) 쓴 글:

Quoted 15 lines

The driver forgets to call component_del in remove to match component_add in probe.
Add the missed call to fix it.

---
 drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/exynos/exynos_drm_gsc.c +0 -0
index 7ae087b0504d..88b6fcaa20be 100644

drivers/gpu/drm/exynos/exynos_drm_gsc.c static int gsc_remove(struct platform_device *pdev) · line 1319

Quoted 7 lines
drivers/gpu/drm/exynos/exynos_drm_gsc.c +1 -0
@@ -1313,6 +1313,7 @@ static int gsc_remove(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 
+	component_del(dev, &gsc_component_ops);
 	pm_runtime_dont_use_autosuspend(dev);
 	pm_runtime_disable(dev);
 

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel