Skip to contentSkip to conversation

ARM: exynos_defconfig: Bring back explicitly wanted options

PATCH In review Krzysztof Kozlowski 2 participants 3 messages Dec 5, 2019 – Dec 11, 2019

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 ARM: exynos_defconfig: Bring back explicitly wanted options

Few options KALLSYMS_ALL, SCSI, PM_DEVFREQ and mutex/spinlock debugging were removed with savedefconfig because they were selected by other options. However these are user-visible options and they might not be selected in the future. Exactly this happened with commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS dependency") removing the dependency between DEBUG_FS and TRACING.

To avoid losing these options in the future, explicitly mention them in defconfig.

---
 arch/arm/configs/exynos_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/configs/exynos_defconfig +6 -0
index e7e4bb5ad8d5..026407101cf2 100644
@@ -38,6 +38,7 @@ CONFIG_CRYPTO_SHA256_ARM=m
 CONFIG_CRYPTO_SHA512_ARM=m
 CONFIG_CRYPTO_AES_ARM_BS=m
 CONFIG_CRYPTO_CHACHA20_NEON=m
+CONFIG_KALLSYMS_ALL=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 CONFIG_PARTITION_ADVANCED=y
@@ -92,6 +93,7 @@ CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_CRYPTOLOOP=y
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_SIZE=8192
+CONFIG_SCSI=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_ATA=y
@@ -291,6 +293,7 @@ CONFIG_CROS_EC_SPI=y
 CONFIG_COMMON_CLK_MAX77686=y
 CONFIG_COMMON_CLK_S2MPS11=y
 CONFIG_EXYNOS_IOMMU=y
+CONFIG_PM_DEVFREQ=y
 CONFIG_DEVFREQ_GOV_PERFORMANCE=y
 CONFIG_DEVFREQ_GOV_POWERSAVE=y
 CONFIG_DEVFREQ_GOV_USERSPACE=y
@@ -355,4 +358,7 @@ CONFIG_SOFTLOCKUP_DETECTOR=y
 # CONFIG_DETECT_HUNG_TASK is not set
 CONFIG_PROVE_LOCKING=y
 CONFIG_DEBUG_ATOMIC_SLEEP=y
+CONFIG_DEBUG_RT_MUTEXES=y
+CONFIG_DEBUG_SPINLOCK=y
+CONFIG_DEBUG_MUTEXES=y
 CONFIG_DEBUG_USER=y
Signature · 1 line
2.17.1
#1 lore raw

Hi Krzyszotof,

Quoted 11 lines · Krzysztof Kozlowski

Few options KALLSYMS_ALL, SCSI, PM_DEVFREQ and mutex/spinlock debugging were removed with savedefconfig because they were selected by other options. However these are user-visible options and they might not be selected in the future. Exactly this happened with commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS dependency") removing the dependency between DEBUG_FS and TRACING.

To avoid losing these options in the future, explicitly mention them in defconfig.

I will not mind adding:

as this patch is a direct result of the discussion on my initial patch:

https://patchwork.kernel.org/patch/11260361/

and my previous findings.

Quoted 33 lines
---
  arch/arm/configs/exynos_defconfig | 6 ++++++
  1 file changed, 6 insertions(+)
arch/arm/configs/exynos_defconfig +3 -0
index e7e4bb5ad8d5..026407101cf2 100644
@@ -38,6 +38,7 @@ CONFIG_CRYPTO_SHA256_ARM=m
  CONFIG_CRYPTO_SHA512_ARM=m
  CONFIG_CRYPTO_AES_ARM_BS=m
  CONFIG_CRYPTO_CHACHA20_NEON=m
+CONFIG_KALLSYMS_ALL=y
  CONFIG_MODULES=y
  CONFIG_MODULE_UNLOAD=y
  CONFIG_PARTITION_ADVANCED=y
@@ -92,6 +93,7 @@ CONFIG_BLK_DEV_LOOP=y
  CONFIG_BLK_DEV_CRYPTOLOOP=y
  CONFIG_BLK_DEV_RAM=y
  CONFIG_BLK_DEV_RAM_SIZE=8192
+CONFIG_SCSI=y
  CONFIG_BLK_DEV_SD=y
  CONFIG_CHR_DEV_SG=y
  CONFIG_ATA=y
@@ -291,6 +293,7 @@ CONFIG_CROS_EC_SPI=y
  CONFIG_COMMON_CLK_MAX77686=y
  CONFIG_COMMON_CLK_S2MPS11=y
  CONFIG_EXYNOS_IOMMU=y
+CONFIG_PM_DEVFREQ=y
  CONFIG_DEVFREQ_GOV_PERFORMANCE=y
  CONFIG_DEVFREQ_GOV_POWERSAVE=y
  CONFIG_DEVFREQ_GOV_USERSPACE=y

arch/arm/configs/exynos_defconfig CONFIG_SOFTLOCKUP_DETECTOR=y · line 364

Quoted 7 lines
arch/arm/configs/exynos_defconfig +3 -0
@@ -355,4 +358,7 @@ CONFIG_SOFTLOCKUP_DETECTOR=y
  # CONFIG_DETECT_HUNG_TASK is not set
  CONFIG_PROVE_LOCKING=y
  CONFIG_DEBUG_ATOMIC_SLEEP=y
+CONFIG_DEBUG_RT_MUTEXES=y
+CONFIG_DEBUG_SPINLOCK=y
+CONFIG_DEBUG_MUTEXES=y
  CONFIG_DEBUG_USER=y

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
author maintainer Applied
#2 lore raw
Quoted 10 lines · Marek Szyprowski

Hi Krzyszotof,

Quoted 7 lines · Krzysztof Kozlowski

Few options KALLSYMS_ALL, SCSI, PM_DEVFREQ and mutex/spinlock debugging were removed with savedefconfig because they were selected by other options. However these are user-visible options and they might not be selected in the future. Exactly this happened with commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS dependency") removing the dependency between DEBUG_FS and TRACING.

Quoted 7 lines
Quoted 4 lines

To avoid losing these options in the future, explicitly mention them in defconfig.

I will not mind adding:

Applied.

Best regards,
Krzysztof