Skip to contentSkip to conversation

drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>

PATCH In review Thomas Zimmermann 3 participants 3 messages Dec 6, 2019

Subsystems (4)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>

Several MGA G200 SE machines don't respect the value of the startadd register field. After more feedback on affected machines, neither PCI subvendor ID nor the internal ID seem to hint towards the bug. All affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was decided to flag all G200 SE A machines as broken.

Fixes 1591fadf857c ("drm/mgag200: Add workaround for HW that does not support 'startadd'")
Cc Thomas Zimmermann <[email protected]>
Cc John Donnelly <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Dave Airlie <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc David Airlie <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc "Y.C. Chen" <[email protected]>
Cc Neil Armstrong <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc "José Roberto de Souza" <[email protected]>
Cc Andrzej Pietrasiewicz <[email protected]>
Cc <[email protected]> # v5.3+
Cc Greg Kroah-Hartman <[email protected]>
Cc Allison Randal <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Noralf Trønnes" <[email protected]>
---
 drivers/gpu/drm/mgag200/mgag200_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/mgag200/mgag200_drv.c +1 -2
index 30b3b827adf8..9f4f5f071add 100644
@@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_modeset, int, 0400);
 static struct drm_driver driver;
 
 static const struct pci_device_id pciidlist[] = {
-	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
+	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
 		G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
-	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A },
 	{ PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B },
 	{ PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
 	{ PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw

drivers/gpu/drm/mgag200/mgag200_drv.c module_param_named(modeset, mgag200_modeset, int, 0400); · line 35

Quoted 10 lines

Several MGA G200 SE machines don't respect the value of the startadd register field. After more feedback on affected machines, neither PCI subvendor ID nor the internal ID seem to hint towards the bug. All affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was decided to flag all G200 SE A machines as broken.

drivers/gpu/drm/mgag200/mgag200_drv.c +1 -2
-	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
+	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
 		G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
-	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A },

cheers,
Gerd

Tested-by
#2 lore raw
Quoted 10 lines · Gerd Hoffmann
Quoted 6 lines

Several MGA G200 SE machines don't respect the value of the startadd register field. After more feedback on affected machines, neither PCI subvendor ID nor the internal ID seem to hint towards the bug. All affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was decided to flag all G200 SE A machines as broken.

Quoted 6 lines

drivers/gpu/drm/mgag200/mgag200_drv.c module_param_named(modeset, mgag200_modeset, int, 0400); · line 35

Quoted 4 lines
drivers/gpu/drm/mgag200/mgag200_drv.c +1 -1
-	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
+	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
		G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
drivers/gpu/drm/mgag200/mgag200_drv.c +0 -1
-	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A },

This series of commits appear to resolve the display issue in 5.4.-rc8 as reported in :

https://gitlab.freedesktop.org/drm/misc/issues/7

52ca22daadbb 2019-12-06 | drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>
e0f1a41a45b3 2019-12-06 | drm/mgag200: Add workaround for HW that does not support 'startadd'
11a219a38f2d 2019-12-06 | drm/mgag200: Store flags from PCI driver data in device structure
a23512ace008 2019-12-06 | drm/mgag200: Extract device type from flags

There is one commit I did not apply :

[PATCH v2] drm/mgag200: Add module parameter to pin all buffers at offset 0

I don’t see a need for that now since we using the PCI-ID of 0x522 for the fix.

Quoted 8 lines

cheers,
Gerd

_______________________________________________
dri-devel mailing list
[email protected]
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_dri-2Ddevel&d=DwIGaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc&m=cFYmB62lgH3WoOWZuvgMKjsgMXQUscmrypDlQhYpF_E&s=21ZEZohFZBQsEr5bo3sS4pMpCf2ca5KXFJq5X3XUzQw&e=

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel