Skip to contentSkip to conversation

package/spidermonkey: depends on host gcc >= 4.9

PATCH New aduskett at gmail.com 3 participants 7 messages Dec 4, 2019 – Dec 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/spidermonkey: depends on host gcc >= 4.9

From: Adam Duskett <[email protected]>

If GCC on the host is older than 4.9, during the configure stage an error is thrown such as:

checking whether the host C compiler can be used... no
ERROR: Only GCC 4.9 or newer is supported (found version 4.8.2).

Depend on the host gcc version being >= 4.9

Fixes:
http://autobuild.buildroot.net/results/192661452fd522bf46b23d5a7a522eb853a984bf

---
 package/spidermonkey/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/spidermonkey/Config.in +2 -0
index 284502f618..5f12110626 100644
@@ -16,6 +16,7 @@ config BR2_PACKAGE_SPIDERMONKEY_JIT_ARCH_SUPPORTS
 
 config BR2_PACKAGE_SPIDERMONKEY
 	bool "spidermonkey"
+	depends on BR2_HOST_GCC_AT_LEAST_4_9
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_SPIDERMONKEY_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
@@ -43,5 +44,6 @@ comment "spidermonkey needs a glibc or musl toolchain with C++, wchar, dynamic l
 		!BR2_INSTALL_LIBSTDCPP || \
 		BR2_STATIC_LIBS || \
 		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
+		!BR2_HOST_GCC_AT_LEAST_4_9 || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
 		!BR2_USE_WCHAR
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/spidermonkey: depends on host gcc >= 4.9

Before this get's added I do want to make another suggestion:

Open embedded also has a patch that reverts the reliance on C++14 back to C++11, allowing the host GCC version to be >= 4.8.

https://github.com/openembedded/meta-openembedded/blob/master/meta-oe/recipes-extended/mozjs/mozjs/fallback-to-2011-C%2B%2B-standard.patch

If this is a better option let me know and I will instead re-submit the patch to include this patch.

Thanks!

Adam

Quoted 41 lines · On Wed, Dec 4, 2019 at 1:49 PM <[email protected]> wrote:

From: Adam Duskett <[email protected]>

If GCC on the host is older than 4.9, during the configure stage an error is thrown such as:

checking whether the host C compiler can be used... no
ERROR: Only GCC 4.9 or newer is supported (found version 4.8.2).

Depend on the host gcc version being >= 4.9

Fixes:
http://autobuild.buildroot.net/results/192661452fd522bf46b23d5a7a522eb853a984bf

---
 package/spidermonkey/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/spidermonkey/Config.in +2 -1
index 284502f618..5f12110626 100644
@@ -16,6 +16,7 @@ config BR2_PACKAGE_SPIDERMONKEY_JIT_ARCH_SUPPORTS
 
 config BR2_PACKAGE_SPIDERMONKEY
        bool "spidermonkey"
+       depends on BR2_HOST_GCC_AT_LEAST_4_9
        depends on BR2_INSTALL_LIBSTDCPP
        depends on BR2_PACKAGE_SPIDERMONKEY_ARCH_SUPPORTS
        depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
@@ -43,5 +44,6 @@ comment "spidermonkey needs a glibc or musl toolchain with C++, wchar, dynamic l
                !BR2_INSTALL_LIBSTDCPP || \
                BR2_STATIC_LIBS || \
                !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
+               !BR2_HOST_GCC_AT_LEAST_4_9 || \
                !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
                !BR2_USE_WCHAR
--

2.23.0

#2 lore raw

PATCH 1/1 package/spidermonkey: depends on host gcc >= 4.9

Quoted 6 lines · On Wed, 4 Dec 2019 13:54:41 -0800 Adam Duskett <[email protected]> wrote:

Before this get's added I do want to make another suggestion:

Open embedded also has a patch that reverts the reliance on C++14 back to C++11, allowing the host GCC version to be >= 4.8.

https://github.com/openembedded/meta-openembedded/blob/master/meta-oe/recipes-extended/mozjs/mozjs/fallback-to-2011-C%2B%2B-standard.patch

So what this patch seems to imply is that in fact gcc 4.9 is not really required by the spidermonkey code. If that's the case, then yes I believe having the patch is probably nicer than having to propagate the dependency.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/spidermonkey: depends on host gcc >= 4.9

Quoted 8 lines · Thomas Petazzoni
Quoted 5 lines · On Wed, 4 Dec 2019 13:54:41 -0800 Adam Duskett <[email protected]> wrote:

Before this get's added I do want to make another suggestion:

Open embedded also has a patch that reverts the reliance on C++14 back to C++11, allowing the host GCC version to be >= 4.8.

Quoted 6 lines
Quoted 1 line

https://github.com/openembedded/meta-openembedded/blob/master/meta-oe/recipes-extended/mozjs/mozjs/fallback-to-2011-C%2B%2B-standard.patch

So what this patch seems to imply is that in fact gcc 4.9 is not really required by the spidermonkey code. If that's the case, then yes I believe having the patch is probably nicer than having to propagate the dependency.

As I understand it, spidermonkey *does* use C++14 features (hence the need for
target GCC 4.9+). However, it also builds host tools which need only C++11 features, but the test is applied to host and target compiler indiscriminately. The patch doesn't make a correct distinction between host and target, it just generally lowers the minimum C++ version.

Now, given that they assume C++14 support is available, it's relatively likely
that they'll start using those features in future versions. At that point. things will anyway break and we need this condition. So I'd say, byte the bullet now and require hsot and target GCC >= 4.9.

Regards,
Arnout

#4 lore raw

PATCH 1/1 package/spidermonkey: depends on host gcc >= 4.9

Quoted 10 lines · On Fri, 6 Dec 2019 00:02:44 +0100 Arnout Vandecappelle <[email protected]> wrote:
Quoted 4 lines

So what this patch seems to imply is that in fact gcc 4.9 is not really required by the spidermonkey code. If that's the case, then yes I believe having the patch is probably nicer than having to propagate the dependency.

As I understand it, spidermonkey *does* use C++14 features (hence the need for
target GCC 4.9+). However, it also builds host tools which need only C++11 features, but the test is applied to host and target compiler indiscriminately. The patch doesn't make a correct distinction between host and target, it just generally lowers the minimum C++ version.

Ah, that's not good indeed.

Quoted 4 lines

Now, given that they assume C++14 support is available, it's relatively likely
that they'll start using those features in future versions. At that point. things will anyway break and we need this condition. So I'd say, byte the bullet now and require hsot and target GCC >= 4.9.

Fair enough. We need to resurrect the patch then, because I changed its state to Changes Requested yesterday.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/1 package/spidermonkey: depends on host gcc >= 4.9

I changed the patch back to new.

Adam

Quoted 30 lines · Thomas Petazzoni
Quoted 10 lines · On Fri, 6 Dec 2019 00:02:44 +0100 Arnout Vandecappelle <[email protected]> wrote:
Quoted 4 lines

So what this patch seems to imply is that in fact gcc 4.9 is not really required by the spidermonkey code. If that's the case, then yes I believe having the patch is probably nicer than having to propagate the dependency.

As I understand it, spidermonkey *does* use C++14 features (hence the need for
target GCC 4.9+). However, it also builds host tools which need only C++11 features, but the test is applied to host and target compiler indiscriminately. The patch doesn't make a correct distinction between host and target, it just generally lowers the minimum C++ version.

Ah, that's not good indeed.

Quoted 4 lines

Now, given that they assume C++14 support is available, it's relatively likely
that they'll start using those features in future versions. At that point. things will anyway break and we need this condition. So I'd say, byte the bullet now and require hsot and target GCC >= 4.9.

Fair enough. We need to resurrect the patch then, because I changed its state to Changes Requested yesterday.

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#6 lore raw

PATCH 1/1 package/spidermonkey: depends on host gcc >= 4.9

In reply to aduskett at gmail.com
Quoted 10 lines · On Wed, 4 Dec 2019 13:49:13 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

If GCC on the host is older than 4.9, during the configure stage an error is thrown such as:

checking whether the host C compiler can be used... no
ERROR: Only GCC 4.9 or newer is supported (found version 4.8.2).

Depend on the host gcc version being >= 4.9

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/192661452fd522bf46b23d5a7a522eb853a984bf

---
 package/spidermonkey/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com