s390x/tcg: clear local interrupts on reset normal
PATCH v2 1/1 s390x/tcg: clear local interrupts on reset normal
We neglected to clean up pending interrupts and emergency signals; fix that.
---
v1->v2:
- rebased on top of my s390-next branch; we can now move the fields to be reset instead of clearing them manually
Further cleanup possible in a follow-up patch.
--- target/s390x/cpu.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
target/s390x/cpu.h +4 -4
@@ -98,10 +98,6 @@ struct CPUS390XState {uint64_t cregs[16 ];/* control registers */ -int pending_int; -uint16_t external_call_addr; -DECLARE_BITMAP (emergency_signals,S390_MAX_CPUS ); -uint64_t ckc;uint64_t cputm;uint32_t todpr;
@@ -117,6 +113,10 @@ struct CPUS390XState {struct {} start_normal_reset_fields;uint8_t riccb[64 ];/* runtime instrumentation control */ +int pending_int; +uint16_t external_call_addr; +DECLARE_BITMAP (emergency_signals,S390_MAX_CPUS ); +/* Fields up to this point are cleared by a CPU reset */ struct {} end_reset_fields;
Signature · 1 line
2.21.0
Quoted 9 lines · Cornelia Huck
We neglected to clean up pending interrupts and emergency signals; fix that.
Signed-off-by Cornelia Huck <[email protected]>---
v1->v2:
- rebased on top of my s390-next branch; we can now move the fields to be reset instead of clearing them manually
Yep, much cleaner than v1 :)
Quoted 33 lines
Further cleanup possible in a follow-up patch.
--- target/s390x/cpu.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)target/s390x/cpu.h +4
-4@@ -98,10 +98,6 @@ struct CPUS390XState {uint64_t cregs[16 ];/* control registers */ -int pending_int; -uint16_t external_call_addr; -DECLARE_BITMAP (emergency_signals,S390_MAX_CPUS ); -uint64_t ckc;uint64_t cputm;uint32_t todpr;@@ -117,6 +113,10 @@ struct CPUS390XState {struct {} start_normal_reset_fields;uint8_t riccb[64 ];/* runtime instrumentation control */ +int pending_int; +uint16_t external_call_addr; +DECLARE_BITMAP (emergency_signals,S390_MAX_CPUS ); +/* Fields up to this point are cleared by a CPU reset */ struct {} end_reset_fields;
Quoted 33 lines · Cornelia Huck
We neglected to clean up pending interrupts and emergency signals; fix that.
Signed-off-by Cornelia Huck <[email protected]>---
v1->v2:
- rebased on top of my s390-next branch; we can now move the fields to be reset instead of clearing them manuallyFurther cleanup possible in a follow-up patch.
--- target/s390x/cpu.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)target/s390x/cpu.h +0
-4@@ -98,10 +98,6 @@ struct CPUS390XState {uint64_t cregs[16 ];/* control registers */ -int pending_int; -uint16_t external_call_addr; -DECLARE_BITMAP (emergency_signals,S390_MAX_CPUS ); -uint64_t ckc;uint64_t cputm;uint32_t todpr;
target/s390x/cpu.h struct CPUS390XState { · line 122
Quoted 10 lines
target/s390x/cpu.h +4
-0@@ -117,6 +113,10 @@ struct CPUS390XState {struct {} start_normal_reset_fields;uint8_t riccb[64 ];/* runtime instrumentation control */ +int pending_int; +uint16_t external_call_addr; +DECLARE_BITMAP (emergency_signals,S390_MAX_CPUS ); +/* Fields up to this point are cleared by a CPU reset */ struct {} end_reset_fields;
Signature · 3 lines
Thanks, David / dhildenb
Cornelia Huck
AppliedQuoted 10 lines · On Fri, 6 Dec 2019 14:54:04 +0100 Cornelia Huck <[email protected]> wrote:
We neglected to clean up pending interrupts and emergency signals; fix that.
Signed-off-by Cornelia Huck <[email protected]>---
v1->v2:
- rebased on top of my s390-next branch; we can now move the fields to be reset instead of clearing them manually
Quoted 5 lines
Further cleanup possible in a follow-up patch.
--- target/s390x/cpu.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Queued to s390-next.