Skip to contentSkip to conversation

package/linux-tools: add hyperv integration services

PATCH New Pascal de Bruijn 2 participants 4 messages Dec 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/linux-tools: add hyperv integration services

includes: hv_vss_daemon, hv_kvp_daemon & hv_fcopy_daemon

---
 package/linux-tools/Config.in                      | 40 +++++++++++++++++++++
 .../linux-tools/linux-tool-hv_fcopy_daemon.init    | 24 +++++++++++++
 .../linux-tools/linux-tool-hv_fcopy_daemon.mk.in   | 39 ++++++++++++++++++++
 .../linux-tools/linux-tool-hv_fcopy_daemon.service | 11 ++++++
 package/linux-tools/linux-tool-hv_kvp_daemon.init  | 24 +++++++++++++
 package/linux-tools/linux-tool-hv_kvp_daemon.mk.in | 42 ++++++++++++++++++++++
 .../linux-tools/linux-tool-hv_kvp_daemon.service   | 11 ++++++
 package/linux-tools/linux-tool-hv_vss_daemon.init  | 24 +++++++++++++
 package/linux-tools/linux-tool-hv_vss_daemon.mk.in | 38 ++++++++++++++++++++
 .../linux-tools/linux-tool-hv_vss_daemon.service   | 11 ++++++
 package/linux-tools/linux-tools.mk                 | 10 ++++++
 11 files changed, 274 insertions(+)
 create mode 100644 package/linux-tools/linux-tool-hv_fcopy_daemon.init
 create mode 100644 package/linux-tools/linux-tool-hv_fcopy_daemon.mk.in
 create mode 100644 package/linux-tools/linux-tool-hv_fcopy_daemon.service
 create mode 100644 package/linux-tools/linux-tool-hv_kvp_daemon.init
 create mode 100644 package/linux-tools/linux-tool-hv_kvp_daemon.mk.in
 create mode 100644 package/linux-tools/linux-tool-hv_kvp_daemon.service
 create mode 100644 package/linux-tools/linux-tool-hv_vss_daemon.init
 create mode 100644 package/linux-tools/linux-tool-hv_vss_daemon.mk.in
 create mode 100644 package/linux-tools/linux-tool-hv_vss_daemon.service
package/linux-tools/Config.in +40 -0
index ab8cc38..bd6c987 100644
@@ -116,4 +116,44 @@ config BR2_PACKAGE_LINUX_TOOLS_TMON
 	  tmon is a terminal-based tool (using curses) that allows the
 	  user to access thermal information about the system.
 
+menu "Microsoft HyperV Integration Services"
+
+config BR2_PACKAGE_LINUX_TOOLS_HV_VSS_DAEMON
+	bool "hv_vss_daemon"
+        depends on BR2_i386 || BR2_x86_64
+	select BR2_PACKAGE_LINUX_TOOLS
+	help
+	  Microsoft HyperV Volume Snapshot Service daemon
+
+	  Relevant kernel configuration options:
+	  HYPERV (HYPERVISOR_GUEST X86_LOCAL_APIC ACPI X86)
+	  HYPERV_UTILS (CONNECTOR NLS)
+
+config BR2_PACKAGE_LINUX_TOOLS_HV_KVP_DAEMON
+        bool "hv_kvp_daemon"
+        depends on BR2_i386 || BR2_x86_64
+        select BR2_PACKAGE_LINUX_TOOLS
+        help
+          Microsoft HyperV Key/Value Pair daemon
+
+	  Is used by HyperV to retrieve status information
+	  from your virtualized guest OS
+
+	  Relevant kernel configuration options:
+	  HYPERV (HYPERVISOR_GUEST X86_LOCAL_APIC ACPI X86)
+	  HYPERV_UTILS (CONNECTOR NLS)
+
+config BR2_PACKAGE_LINUX_TOOLS_HV_FCOPY_DAEMON
+        bool "hv_fcopy_daemon"
+        depends on BR2_i386 || BR2_x86_64
+        select BR2_PACKAGE_LINUX_TOOLS
+        help
+          Microsoft HyperV File Copy daemon
+
+	  Relevant kernel configuration options:
+	  HYPERV (HYPERVISOR_GUEST X86_LOCAL_APIC ACPI X86)
+	  HYPERV_UTILS (CONNECTOR NLS)
+
+endmenu
+
 endmenu
package/linux-tools/linux-tool-hv_fcopy_daemon.init new file +24 -0
new file mode 100644
index 0000000..cb20241
@@ -0,0 +1,24 @@
+#!/bin/sh
+
+NAME="hv_fcopy_daemon"
+DAEMON="/usr/sbin/${NAME}"
+
+case "$1" in
+start)
+        printf "Starting ${NAME}: "
+        start-stop-daemon -S -x ${DAEMON}
+        [ $? -eq 0 ] && echo "OK" || echo "FAIL"
+        ;;
+stop)
+        printf "Stopping ${NAME}: "
+        start-stop-daemon -K -x ${DAEMON}
+        [ $? -eq 0 ] && echo "OK" || echo "FAIL"
+        ;;
+restart|reload)
+        $0 stop
+        $0 start
+        ;;
+*)
+        echo "Usage: $0 {start|stop|restart|reload}"
+        exit 1
+esac
package/linux-tools/linux-tool-hv_fcopy_daemon.mk.in new file +39 -0
new file mode 100644
index 0000000..4a3e1c2
@@ -0,0 +1,39 @@
+################################################################################
+#
+# hv_fcopy_daemon
+#
+################################################################################
+
+LINUX_TOOLS += hv_fcopy_daemon
+
+HV_FCOPY_DAEMON_MAKE_OPTS = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)"
+
+define HV_FCOPY_DAEMON_BUILD_CMDS
+	$(Q)if test ! -f $(LINUX_DIR)/tools/hv/hv_fcopy_daemon.c ; then \
+		echo "Your kernel version is too old and does not have the HyperV FCOPY daemon tool." ; \
+		exit 1 ; \
+	fi
+
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools/hv \
+		$(HV_FCOPY_DAEMON_MAKE_OPTS) \
+		hv_fcopy_daemon
+endef
+
+define HV_FCOPY_DAEMON_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(LINUX_DIR)/tools/hv/hv_fcopy_daemon \
+		$(TARGET_DIR)/usr/sbin/hv_fcopy_daemon
+endef
+
+define HV_FCOPY_DAEMON_INSTALL_INIT_SYSTEMD
+        mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+        $(INSTALL) -m 0644 -D package/linux-tools/linux-tool-hv_fcopy_daemon.service \
+                $(TARGET_DIR)/usr/lib/systemd/system/hv_fcopy_daemon.service
+	ln -sf ../../../../usr/lib/systemd/system/hv_fcopy_daemon.service \
+		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/hv_fcopy_daemon.service
+endef
+
+define HV_FCOPY_DAEMON_INSTALL_INIT_SYSV
+	$(INSTALL) -m 0755 -D package/linux-tools/linux-tool-hv_fcopy_daemon.init \
+		$(TARGET_DIR)/etc/init.d/S10hv_fcopy_daemon
+endef
+
package/linux-tools/linux-tool-hv_fcopy_daemon.service new file +11 -0
new file mode 100644
index 0000000..e719553
@@ -0,0 +1,11 @@
+[Unit]
+Description=HyperV FCopy daemon
+After=syslog.target
+ConditionVirtualization=microsoft
+
+[Service]
+Type=simple
+ExecStart=/usr/sbin/hv_fcopy_daemon --no-daemon
+
+[Install]
+WantedBy=multi-user.target
package/linux-tools/linux-tool-hv_kvp_daemon.init new file +24 -0
new file mode 100644
index 0000000..51d687b
@@ -0,0 +1,24 @@
+#!/bin/sh
+
+NAME="hv_kvp_daemon"
+DAEMON="/usr/sbin/${NAME}"
+
+case "$1" in
+start)
+        printf "Starting ${NAME}: "
+        start-stop-daemon -S -x ${DAEMON}
+        [ $? -eq 0 ] && echo "OK" || echo "FAIL"
+        ;;
+stop)
+        printf "Stopping ${NAME}: "
+        start-stop-daemon -K -x ${DAEMON}
+        [ $? -eq 0 ] && echo "OK" || echo "FAIL"
+        ;;
+restart|reload)
+        $0 stop
+        $0 start
+        ;;
+*)
+        echo "Usage: $0 {start|stop|restart|reload}"
+        exit 1
+esac
package/linux-tools/linux-tool-hv_kvp_daemon.mk.in new file +42 -0

42 lines not on this page · raw message

package/linux-tools/linux-tool-hv_kvp_daemon.service new file +11 -0
new file mode 100644
index 0000000..940d832
@@ -0,0 +1,11 @@
+[Unit]
+Description=HyperV KVP daemon
+After=syslog.target
+ConditionVirtualization=microsoft
+
+[Service]
+Type=simple
+ExecStart=/usr/sbin/hv_kvp_daemon --no-daemon
+
+[Install]
+WantedBy=multi-user.target
package/linux-tools/linux-tool-hv_vss_daemon.init new file +24 -0
new file mode 100644
index 0000000..b009619
@@ -0,0 +1,24 @@
+#!/bin/sh
+
+NAME="hv_vss_daemon"
+DAEMON="/usr/sbin/${NAME}"
+
+case "$1" in
+start)
+        printf "Starting ${NAME}: "
+        start-stop-daemon -S -x ${DAEMON}
+        [ $? -eq 0 ] && echo "OK" || echo "FAIL"
+        ;;
+stop)
+        printf "Stopping ${NAME}: "
+        start-stop-daemon -K -x ${DAEMON}
+        [ $? -eq 0 ] && echo "OK" || echo "FAIL"
+        ;;
+restart|reload)
+        $0 stop
+        $0 start
+        ;;
+*)
+        echo "Usage: $0 {start|stop|restart|reload}"
+        exit 1
+esac
package/linux-tools/linux-tool-hv_vss_daemon.mk.in new file +38 -0
new file mode 100644
index 0000000..db1ecb3
@@ -0,0 +1,38 @@
+################################################################################
+#
+# hv_vss_daemon
+#
+################################################################################
+
+LINUX_TOOLS += hv_vss_daemon
+
+HV_VSS_DAEMON_MAKE_OPTS = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)"
+
+define HV_VSS_DAEMON_BUILD_CMDS
+	$(Q)if test ! -f $(LINUX_DIR)/tools/hv/hv_vss_daemon.c ; then \
+		echo "Your kernel version is too old and does not have the HyperV VSS daemon tool." ; \
+		exit 1 ; \
+	fi
+
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools/hv \
+		$(HV_VSS_DAEMON_MAKE_OPTS) \
+		hv_vss_daemon
+endef
+
+define HV_VSS_DAEMON_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(LINUX_DIR)/tools/hv/hv_vss_daemon \
+		$(TARGET_DIR)/usr/sbin/hv_vss_daemon
+endef
+
+define HV_VSS_DAEMON_INSTALL_INIT_SYSTEMD
+        mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+        $(INSTALL) -m 0644 -D package/linux-tools/linux-tool-hv_vss_daemon.service \
+                $(TARGET_DIR)/usr/lib/systemd/system/hv_vss_daemon.service
+	ln -sf ../../../../usr/lib/systemd/system/hv_vss_daemon.service \
+		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/hv_vss_daemon.service
+endef
+
+define HV_VSS_DAEMON_INSTALL_INIT_SYSV
+        $(INSTALL) -m 0755 -D package/linux-tools/linux-tool-hv_vss_daemon.init \
+                $(TARGET_DIR)/etc/init.d/S10hv_vss_daemon
+endef
package/linux-tools/linux-tool-hv_vss_daemon.service new file +11 -0
new file mode 100644
index 0000000..f653f7b
@@ -0,0 +1,11 @@
+[Unit]
+Description=HyperV VSS daemon
+After=syslog.target
+ConditionVirtualization=microsoft
+
+[Service]
+Type=simple
+ExecStart=/usr/sbin/hv_vss_daemon --no-daemon
+
+[Install]
+WantedBy=multi-user.target
package/linux-tools/linux-tools.mk +10 -0
index ac4da59..cd1da86 100644
@@ -42,4 +42,14 @@ LINUX_TOOLS_POST_INSTALL_TARGET_HOOKS += $(foreach tool,$(LINUX_TOOLS),\
 	$(if $(BR2_PACKAGE_LINUX_TOOLS_$(call UPPERCASE,$(tool))),\
 		$(call UPPERCASE,$(tool))_INSTALL_TARGET_CMDS))
 
+LINUX_TOOLS_POST_INSTALL_TARGET_HOOKS += $(foreach tool,$(LINUX_TOOLS),\
+	$(if $(BR2_INIT_SYSV)$(BR2_INIT_BUSYBOX),\
+		$(if $(BR2_PACKAGE_LINUX_TOOLS_$(call UPPERCASE,$(tool))),\
+			$(call UPPERCASE,$(tool))_INSTALL_INIT_SYSV)))
+
+LINUX_TOOLS_POST_INSTALL_TARGET_HOOKS += $(foreach tool,$(LINUX_TOOLS),\
+	$(if $(BR2_INIT_SYSTEMD),\
+		$(if $(BR2_PACKAGE_LINUX_TOOLS_$(call UPPERCASE,$(tool))),\
+			$(call UPPERCASE,$(tool))_INSTALL_INIT_SYSTEMD)))
+
 $(eval $(generic-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/2 package/linux-tools: add hyperv integration services

Hello Pascal,

Quoted 16 lines · On Fri, 6 Dec 2019 14:16:59 +0100 Pascal de Bruijn <[email protected]>…

includes: hv_vss_daemon, hv_kvp_daemon & hv_fcopy_daemon

---
 package/linux-tools/Config.in                      | 40 +++++++++++++++++++++
 .../linux-tools/linux-tool-hv_fcopy_daemon.init    | 24 +++++++++++++
 .../linux-tools/linux-tool-hv_fcopy_daemon.mk.in   | 39 ++++++++++++++++++++
 .../linux-tools/linux-tool-hv_fcopy_daemon.service | 11 ++++++
 package/linux-tools/linux-tool-hv_kvp_daemon.init  | 24 +++++++++++++
 package/linux-tools/linux-tool-hv_kvp_daemon.mk.in | 42 ++++++++++++++++++++++
 .../linux-tools/linux-tool-hv_kvp_daemon.service   | 11 ++++++
 package/linux-tools/linux-tool-hv_vss_daemon.init  | 24 +++++++++++++
 package/linux-tools/linux-tool-hv_vss_daemon.mk.in | 38 ++++++++++++++++++++
 .../linux-tools/linux-tool-hv_vss_daemon.service   | 11 ++++++
 package/linux-tools/linux-tools.mk                 | 10 ++++++
 11 files changed, 274 insertions(+)

I think it would be nice to add yourself to the DEVELOPERS file for those new files.

package/linux-tools/Config.in config BR2_PACKAGE_LINUX_TOOLS_TMON · line 123

Quoted 13 lines
package/linux-tools/Config.in +5 -0
index ab8cc38..bd6c987 100644
@@ -116,4 +116,44 @@ config BR2_PACKAGE_LINUX_TOOLS_TMON
 	  tmon is a terminal-based tool (using curses) that allows the
 	  user to access thermal information about the system.
 
+menu "Microsoft HyperV Integration Services"
+
+config BR2_PACKAGE_LINUX_TOOLS_HV_VSS_DAEMON
+	bool "hv_vss_daemon"
+        depends on BR2_i386 || BR2_x86_64

Indentation for this line is not correct.

package/linux-tools/Config.in config BR2_PACKAGE_LINUX_TOOLS_TMON · line 125

Quoted 2 lines
package/linux-tools/Config.in +2 -0
+	  Relevant kernel configuration options:
+	  HYPERV (HYPERVISOR_GUEST X86_LOCAL_APIC ACPI X86)

It's not clear what are those options between parenthesis.

package/linux-tools/Config.in config BR2_PACKAGE_LINUX_TOOLS_TMON · line 136

Quoted 7 lines
package/linux-tools/Config.in +7 -0
+	  HYPERV_UTILS (CONNECTOR NLS)
+
+config BR2_PACKAGE_LINUX_TOOLS_HV_KVP_DAEMON
+        bool "hv_kvp_daemon"
+        depends on BR2_i386 || BR2_x86_64
+        select BR2_PACKAGE_LINUX_TOOLS
+        help

Indentation is not correct, you should use one tab. Please run "make check-package" to verify the syntax of Config.in.

Quoted 20 lines
package/linux-tools/linux-tool-hv_fcopy_daemon.init new file +14 -0
new file mode 100644
index 0000000..cb20241
@@ -0,0 +1,24 @@
+#!/bin/sh
+
+NAME="hv_fcopy_daemon"
+DAEMON="/usr/sbin/${NAME}"
+
+case "$1" in
+start)
+        printf "Starting ${NAME}: "
+        start-stop-daemon -S -x ${DAEMON}
+        [ $? -eq 0 ] && echo "OK" || echo "FAIL"
+        ;;
+stop)
+        printf "Stopping ${NAME}: "
+        start-stop-daemon -K -x ${DAEMON}

package/linux-tools/linux-tool-hv_fcopy_daemon.init line 24

Quoted 10 lines
package/linux-tools/linux-tool-hv_fcopy_daemon.init new file +10 -0
+        [ $? -eq 0 ] && echo "OK" || echo "FAIL"
+        ;;
+restart|reload)
+        $0 stop
+        $0 start
+        ;;
+*)
+        echo "Usage: $0 {start|stop|restart|reload}"
+        exit 1
+esac

Make sure to use package/busybox/S01logging as a template for the init scripts.

package/linux-tools/linux-tool-hv_fcopy_daemon.init

Quoted 12 lines
package/linux-tools/linux-tool-hv_fcopy_daemon.init new file +12 -0
+define HV_FCOPY_DAEMON_INSTALL_INIT_SYSTEMD
+        mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+        $(INSTALL) -m 0644 -D package/linux-tools/linux-tool-hv_fcopy_daemon.service \
+                $(TARGET_DIR)/usr/lib/systemd/system/hv_fcopy_daemon.service
+	ln -sf ../../../../usr/lib/systemd/system/hv_fcopy_daemon.service \
+		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/hv_fcopy_daemon.service
+endef
+
+define HV_FCOPY_DAEMON_INSTALL_INIT_SYSV
+	$(INSTALL) -m 0755 -D package/linux-tools/linux-tool-hv_fcopy_daemon.init \
+		$(TARGET_DIR)/etc/init.d/S10hv_fcopy_daemon
+endef

Did you see my reply on your previous version of the patch, which says that these two variables will never be used, because HV_FCOPY_DAEMON is not a Buildroot package ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/2 package/linux-tools: add hyperv integration services

From: Thomas Petazzoni <[email protected]>

To: Pascal de Bruijn <[email protected]>
Cc: <[email protected]>
Sent: 12/6/2019 3:16 PM
Subject: Re: [Buildroot] [PATCH 1/2] package/linux-tools: add hyperv integration services

Hello Pascal,

Quoted 15 lines · On Fri, ?6 Dec 2019 14:16:59 +0100 Pascal de Bruijn <[email protected]>…

includes: hv_vss_daemon, hv_kvp_daemon & hv_fcopy_daemon

---

?package/linux-tools/Config.in ? ? ? ? ? ? ? ? ? ? ?| 40 +++++++++++++++++++++ 
?.../linux-tools/linux-tool-hv_fcopy_daemon.init ? ?| 24 +++++++++++++ 
?.../linux-tools/linux-tool-hv_fcopy_daemon.mk.in ? | 39 ++++++++++++++++++++ 
?.../linux-tools/linux-tool-hv_fcopy_daemon.service | 11 ++++++ 
?package/linux-tools/linux-tool-hv_kvp_daemon.init ?| 24 +++++++++++++ 
?package/linux-tools/linux-tool-hv_kvp_daemon.mk.in | 42 ++++++++++++++++++++++ 
?.../linux-tools/linux-tool-hv_kvp_daemon.service ? | 11 ++++++ 
?package/linux-tools/linux-tool-hv_vss_daemon.init ?| 24 +++++++++++++ 
?package/linux-tools/linux-tool-hv_vss_daemon.mk.in | 38 ++++++++++++++++++++ 
?.../linux-tools/linux-tool-hv_vss_daemon.service ? | 11 ++++++ 
?package/linux-tools/linux-tools.mk ? ? ? ? ? ? ? ? | 10 ++++++ 
Quoted 1 line

?11 files changed, 274 insertions(+)

I think it would be nice to add yourself to the DEVELOPERS file for those new files.

package/linux-tools/Config.in config BR2_PACKAGE_LINUX_TOOLS_TMON

Quoted 13 lines
package/linux-tools/Config.in +0 -0
index ab8cc38..bd6c987 100644 
@@ -116,4 +116,44 @@ config BR2_PACKAGE_LINUX_TOOLS_TMON 

? ? ? ? tmon is a terminal-based tool (using curses) that allows the ? ? ? ? user to access thermal information about the system. ?

package/linux-tools/Config.in +5 -0
+menu "Microsoft HyperV Integration Services" 
+ 
+config BR2_PACKAGE_LINUX_TOOLS_HV_VSS_DAEMON 
+ ? ? bool "hv_vss_daemon" 
+ ? ? ? ?depends on BR2_i386 || BR2_x86_64 

Indentation for this line is not correct.

Quoted 2 lines

+ ? ? ? Relevant kernel configuration options:
+ ? ? ? HYPERV (HYPERVISOR_GUEST X86_LOCAL_APIC ACPI X86)

It's not clear what are those options between parenthesis.

As stated they are all kernel configuration options, the options between the parenthesis are just dependancies of the dependancy.

Quoted 7 lines

+ ? ? ? HYPERV_UTILS (CONNECTOR NLS)
+
+config BR2_PACKAGE_LINUX_TOOLS_HV_KVP_DAEMON
+ ? ? ? ?bool "hv_kvp_daemon"
+ ? ? ? ?depends on BR2_i386 || BR2_x86_64
+ ? ? ? ?select BR2_PACKAGE_LINUX_TOOLS
+ ? ? ? ?help

Indentation is not correct, you should use one tab. Please run "make check-package" to verify the syntax of Config.in.

Quoted 20 lines
package/linux-tools/linux-tool-hv_fcopy_daemon.init new file +14 -0
new file mode 100644 
index 0000000..cb20241 
@@ -0,0 +1,24 @@ 
+#!/bin/sh 
+ 
+NAME="hv_fcopy_daemon" 
+DAEMON="/usr/sbin/${NAME}" 
+ 
+case "$1" in 
+start) 
+ ? ? ? ?printf "Starting ${NAME}: " 
+ ? ? ? ?start-stop-daemon -S -x ${DAEMON} 
+ ? ? ? ?[ $? -eq 0 ] && echo "OK" || echo "FAIL" 
+ ? ? ? ?;; 
+stop) 
+ ? ? ? ?printf "Stopping ${NAME}: " 
+ ? ? ? ?start-stop-daemon -K -x ${DAEMON} 

package/linux-tools/linux-tool-hv_fcopy_daemon.init line 24

Quoted 10 lines
package/linux-tools/linux-tool-hv_fcopy_daemon.init new file +10 -0
+ ? ? ? ?[ $? -eq 0 ] && echo "OK" || echo "FAIL" 
+ ? ? ? ?;; 
+restart|reload) 
+ ? ? ? ?$0 stop 
+ ? ? ? ?$0 start 
+ ? ? ? ?;; 
+*) 
+ ? ? ? ?echo "Usage: $0 {start|stop|restart|reload}" 
+ ? ? ? ?exit 1 
+esac 

Make sure to use package/busybox/S01logging as a template for the init scripts.

package/linux-tools/linux-tool-hv_fcopy_daemon.init

Quoted 12 lines
package/linux-tools/linux-tool-hv_fcopy_daemon.init new file +12 -0
+define HV_FCOPY_DAEMON_INSTALL_INIT_SYSTEMD 
+ ? ? ? ?mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants 
+ ? ? ? ?$(INSTALL) -m 0644 -D package/linux-tools/linux-tool-hv_fcopy_daemon.service \ 
+ ? ? ? ? ? ? ? ?$(TARGET_DIR)/usr/lib/systemd/system/hv_fcopy_daemon.service 
+ ? ? ln -sf ../../../../usr/lib/systemd/system/hv_fcopy_daemon.service \ 
+ ? ? ? ? ?$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/hv_fcopy_daemon.service 
+endef 
+ 
+define HV_FCOPY_DAEMON_INSTALL_INIT_SYSV 
+ ? ? $(INSTALL) -m 0755 -D package/linux-tools/linux-tool-hv_fcopy_daemon.init \ 
+ ? ? ? ? ?$(TARGET_DIR)/etc/init.d/S10hv_fcopy_daemon 
+endef 

Did you see my reply on your previous version of the patch, which says that these two variables will never be used, because HV_FCOPY_DAEMON is not a Buildroot package ?

I actually modified linux-tools.mk to make that work.

Regards,
Pascal de Bruijn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191206/de3bbad5/attachment.html>

#3 lore raw

PATCH 1/2 package/linux-tools: add hyperv integration services

Hello,

It is very difficult to reply to your e-mails, because the plain text version of your e-mail does not properly quote the text you're replying to. Could you fix your e-mail client to only send plain text e-mails to the mailing list, and to properly quote the text you're replying to ?

Quoted 7 lines · On Fri, 6 Dec 2019 15:24:31 +0100 Pascal de Bruijn <[email protected]>…
Quoted 2 lines

+ ? ? ? Relevant kernel configuration options:
+ ? ? ? HYPERV (HYPERVISOR_GUEST X86_LOCAL_APIC ACPI X86)

It's not clear what are those options between parenthesis.

As stated they are all kernel configuration options, the options between the parenthesis are just dependancies of the dependancy.

I think we shouldn't list the dependencies of dependencies. They risk changing from kernel versions to others. Just list that it needs CONFIG_HYPERV and CONFIG_HYPVER_UTILS.

Quoted 5 lines

Did you see my reply on your previous version of the patch, which says that these two variables will never be used, because HV_FCOPY_DAEMON is not a Buildroot package ?

I actually modified linux-tools.mk to make that work.

Indeed, I missed it. It should be part of a separate, preliminary patch in your series.

Could you take into account the few comments that I have given, and send an updated version of the patch series ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com