Skip to contentSkip to conversation

net/i40e: fix flow control broken

PATCH Applied Guinan Sun 3 participants 4 messages Dec 6, 2019 – Dec 16, 2019 Network drivers

lore
Share & tools
lore

Guinan Sun

author
#0 lore raw

PATCH 1/1 net/i40e: fix flow control broken

Repeat switching flow control on or off during receiving traffic, testpmd reports "failed to switch Tx queue occurs" after quit. The patch fixes the issue.

Fixes f53577f06925 ("i40e: support flow control")
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +1 -1
index 5999c964b..5507f6c39 100644
@@ -53,7 +53,7 @@
 
 /* Wait count and interval */
 #define I40E_CHK_Q_ENA_COUNT       1000
-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
 
 /* Maximun number of VSI */
 #define I40E_MAX_NUM_VSIS          (384UL)
Signature · 1 line
2.17.1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Sun, GuinanX <[email protected]>
Sent: Friday, December 6, 2019 11:41 PM
To: [email protected]
Cc: Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>; Sun, GuinanX <[email protected]>; [email protected]
Subject: [PATCH] net/i40e: fix flow control broken

Quoted 3 lines

Repeat switching flow control on or off during receiving traffic, testpmd reports "failed to switch Tx queue occurs" after quit.
The patch fixes the issue.

The explain more about the root cause and the fix.

Quoted 24 lines
Fixes f53577f06925 ("i40e: support flow control")
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +1 -2
index 5999c964b..5507f6c39 100644
@@ -53,7 +53,7 @@
 
 /* Wait count and interval */
 #define I40E_CHK_Q_ENA_COUNT       1000
-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
 
 /* Maximun number of VSI */
 #define I40E_MAX_NUM_VSIS          (384UL)
--

2.17.1

Acked-by on v1 1/1 Applied
#2 lore raw
In reply to Guinan Sun
Quoted 28 lines · Guinan Sun

Repeat switching flow control on or off during receiving traffic, testpmd reports "failed to switch Tx queue occurs" after quit. The patch fixes the issue.

Fixes f53577f06925 ("i40e: support flow control")

---
drivers/net/i40e/i40e_ethdev.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +1 -1
index 5999c964b..5507f6c39 100644
@@ -53,7 +53,7 @@
 
 /* Wait count and interval */
 #define I40E_CHK_Q_ENA_COUNT       1000
-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
 
 /* Maximun number of VSI */
 #define I40E_MAX_NUM_VSIS          (384UL)
Signature · 1 line
2.17.1

Applied to dpdk-next-net-intel, Thanks.

#3 lore raw
Quoted 32 lines · Ye Xiaolong
Quoted 28 lines · Guinan Sun

Repeat switching flow control on or off during receiving traffic, testpmd reports "failed to switch Tx queue occurs" after quit. The patch fixes the issue.

Fixes f53577f06925 ("i40e: support flow control")

---
drivers/net/i40e/i40e_ethdev.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +1 -1
index 5999c964b..5507f6c39 100644
@@ -53,7 +53,7 @@
 
 /* Wait count and interval */
 #define I40E_CHK_Q_ENA_COUNT       1000
-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
 
 /* Maximun number of VSI */
 #define I40E_MAX_NUM_VSIS          (384UL)
Signature · 1 line
2.17.1
Quoted 1 line

Applied to dpdk-next-net-intel, Thanks.

Sorry, there is still concern about this patch, drop it from next-net-intel first.