Skip to contentSkip to conversation

ARM: dts: Cygnus: Fix MDIO node address/size cells

PATCH Applied Florian Fainelli 3 participants 4 messages Dec 6, 2019 – Dec 9, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: Cygnus: Fix MDIO node address/size cells

The MDIO node on Cygnus had an reversed #address-cells and
#size-cells properties, correct those.

Fixes 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
---
 arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/bcm-cygnus.dtsi +2 -2
index 2dac3efc7640..1bc45cfd5453 100644
@@ -174,8 +174,8 @@
 		mdio: mdio@18002000 {
 			compatible = "brcm,iproc-mdio";
 			reg = <0x18002000 0x8>;
-			#size-cells = <1>;
-			#address-cells = <0>;
+			#size-cells = <0>;
+			#address-cells = <1>;
 			status = "disabled";
 
 			gphy0: ethernet-phy@0 {
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Florian Fainelli

The MDIO node on Cygnus had an reversed #address-cells and
#size-cells properties, correct those.

Fixes 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
---
  arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/bcm-cygnus.dtsi +0 -0
index 2dac3efc7640..1bc45cfd5453 100644

arch/arm/boot/dts/bcm-cygnus.dtsi line 181

Quoted 10 lines
arch/arm/boot/dts/bcm-cygnus.dtsi +2 -2
@@ -174,8 +174,8 @@
  		mdio: mdio@18002000 {
  			compatible = "brcm,iproc-mdio";
  			reg = <0x18002000 0x8>;
-			#size-cells = <1>;
-			#address-cells = <0>;
+			#size-cells = <0>;
+			#address-cells = <1>;
  			status = "disabled";
 
  			gphy0: ethernet-phy@0 {

Looks good! Thanks!

Reviewed-by on v1 1/1
#2 lore raw
In reply to Florian Fainelli
Quoted 6 lines · Florian Fainelli

The MDIO node on Cygnus had an reversed #address-cells and
#size-cells properties, correct those.

Fixes 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")

Thanks Florian,

this looks good to me.

Quoted 22 lines
---
 arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/bcm-cygnus.dtsi +2 -2
index 2dac3efc7640..1bc45cfd5453 100644
@@ -174,8 +174,8 @@
 		mdio: mdio@18002000 {
 			compatible = "brcm,iproc-mdio";
 			reg = <0x18002000 0x8>;
-			#size-cells = <1>;
-			#address-cells = <0>;
+			#size-cells = <0>;
+			#address-cells = <1>;
 			status = "disabled";
 
 			gphy0: ethernet-phy@0 {
Signature · 1 line
2.17.1