Skip to contentSkip to conversation

netfilter: nf_tables_offload: return EOPNOTSUPP if rule specifies no actions

PATCH New Pablo Neira Ayuso 1 participant 1 message Dec 6, 2019

Subsystems (2)
lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 netfilter: nf_tables_offload: return EOPNOTSUPP if rule specifies no actions

If the rule only specifies the matching side, return EOPNOTSUPP. Otherwise, the front-end relies on the drivers to reject this rule.

Fixes c9626a2cbdb2 ("netfilter: nf_tables: add hardware offload support")
---
 net/netfilter/nf_tables_offload.c | 3 +++
 1 file changed, 3 insertions(+)
net/netfilter/nf_tables_offload.c +3 -0
index d7a35da008ef..22fb18906ccf 100644
@@ -44,6 +44,9 @@ struct nft_flow_rule *nft_flow_rule_create(struct net *net,
 		expr = nft_expr_next(expr);
 	}
 
+	if (num_actions == 0)
+		return ERR_PTR(-EOPNOTSUPP);
+
 	flow = nft_flow_rule_alloc(num_actions);
 	if (!flow)
 		return ERR_PTR(-ENOMEM);
Signature · 1 line
2.11.0