Skip to contentSkip to conversation

mptcp: Fix dd command line option

PATCH In review Mat Martineau 2 participants 3 messages Dec 7, 2019 – Dec 12, 2019

Subsystems (3)
lore
Share & tools
lore

Mat Martineau

author
#0 lore raw

PATCH 1/1 mptcp: Fix dd command line option

"conv=" is a valid command line parameter, but "conf=" is not. The error message is redirected to /dev/null so it is not obvious when running tests. The tests seem to pass either way, so it's not clear that even the "conv=" is really needed.

squashto: mptcp: add basic kselftest for mptcp
Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

---
 tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/mptcp/mptcp_connect.sh +1 -1
index e4c76f5766e4..d573a0feb98d 100755
@@ -445,7 +445,7 @@ make_file()
 	SIZE=$((RANDOM % 1024))
 	SIZE=$((SIZE + 128))
 	TSIZE=$((TSIZE + SIZE))
-	dd if=/dev/urandom conf=notrunc of="$name" bs=1 count=$SIZE 2> /dev/null
+	dd if=/dev/urandom conv=notrunc of="$name" bs=1 count=$SIZE 2> /dev/null
 	echo -e "\nMPTCP_TEST_FILE_END_MARKER" >> "$name"
 
 	echo "Created $name (size $TSIZE) containing data sent by $who"
Signature · 1 line
2.24.0
#1 lore raw

Hi Mat,

Quoted 4 lines · Mat Martineau

"conv=" is a valid command line parameter, but "conf=" is not. The error message is redirected to /dev/null so it is not obvious when running tests. The tests seem to pass either way, so it's not clear that even the "conv=" is really needed.

Good catch!

It looks good to me!

I will apply it once we sort out what we can do with Paolo and Davide's modifications. Let's discuss that at the meeting.

Cheers,
Matt

Signature · 5 lines
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
#2 lore raw

Hi Mat,

Quoted 8 lines · Matthieu Baerts

Hi Mat,

Quoted 4 lines · Mat Martineau

"conv=" is a valid command line parameter, but "conf=" is not. The error message is redirected to /dev/null so it is not obvious when running tests. The tests seem to pass either way, so it's not clear that even the "conv=" is really needed.

Quoted 6 lines

Good catch!

It looks good to me!

I will apply it once we sort out what we can do with Paolo and Davide's modifications. Let's discuss that at the meeting.

Just applied:

- a245ffca5256: "squashed" in "mptcp: add basic kselftest for mptcp"
- 4b28d355242e..a3f47d5cab03: result

I didn't relaunch the tests for this one, going to launch them soon with the next applied patches.

Cheers,
Matt

Signature · 5 lines
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium