libtraceevent: allow custom libdir path
PATCH 1/1 libtraceevent: allow custom libdir path
When I use prefix=/usr and try to install libtraceevent in my laptop it tries to install in /usr/lib64. I am not having any folder as /usr/lib64 and also the debian policy doesnot allow installing in /usr/lib64. It should be in /usr/lib/x86_64-linux-gnu/.
Quote: No package for a 64 bit architecture may install files in
/usr/lib64/ or in a subdirectory of it.
ref: https://www.debian.org/doc/debian-policy/ch-opersys.html
Make it more flexible by allowing to mention libdir_relative while installing so that distros can mention the path according to their policy or use the default one.
---
Hi Steve,
And yet another one (hopefully the final one for now). I know I missed the merge window, but your Ack should be ok.
tools/lib/traceevent/Makefile | 5 +++-- tools/lib/traceevent/plugins/Makefile | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-)
tools/lib/traceevent/Makefile +3 -2
@@ -39,11 +39,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) ifeq ($(LP64), 1) - libdir_relative = lib64 + libdir_relative_temp = lib64 else - libdir_relative = lib + libdir_relative_temp = lib endif +libdir_relative ?= $(libdir_relative_temp) prefix ?= /usr/local libdir = $(prefix)/$(libdir_relative) man_dir = $(prefix)/share/man
tools/lib/traceevent/plugins/Makefile +3 -2
@@ -32,11 +32,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) ifeq ($(LP64), 1) - libdir_relative = lib64 + libdir_relative_tmp = lib64 else - libdir_relative = lib + libdir_relative_tmp = lib endif +libdir_relative ?= $(libdir_relative_tmp) prefix ?= /usr/local libdir = $(prefix)/$(libdir_relative)
Signature · 1 line
2.11.0
Arnaldo,
Can you pull this patch in?
-- Steve
Quoted 63 lines · On Sat, 7 Dec 2019 11:14:40 +0000 Sudip Mukherjee…
When I use prefix=/usr and try to install libtraceevent in my laptop it tries to install in
/usr/lib64. I am not having any folder as/usr/lib64and also the debian policy doesnot allow installing in/usr/lib64. It should be in/usr/lib/x86_64-linux-gnu/.Quote: No package for a 64 bit architecture may install files in
/usr/lib64/or in a subdirectory of it.
ref: https://www.debian.org/doc/debian-policy/ch-opersys.htmlMake it more flexible by allowing to mention
libdir_relativewhile installing so that distros can mention the path according to their policy or use the default one.Signed-off-by Sudip Mukherjee <[email protected]>---
Hi Steve,
And yet another one (hopefully the final one for now). I know I missed the merge window, but your Ack should be ok.
tools/lib/traceevent/Makefile | 5 +++-- tools/lib/traceevent/plugins/Makefile | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-)tools/lib/traceevent/Makefile +3
-2@@ -39,11 +39,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) ifeq ($(LP64), 1) - libdir_relative = lib64 + libdir_relative_temp = lib64 else - libdir_relative = lib + libdir_relative_temp = lib endif +libdir_relative ?= $(libdir_relative_temp) prefix ?= /usr/local libdir = $(prefix)/$(libdir_relative) man_dir = $(prefix)/share/mantools/lib/traceevent/plugins/Makefile +3
-2@@ -32,11 +32,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) ifeq ($(LP64), 1) - libdir_relative = lib64 + libdir_relative_tmp = lib64 else - libdir_relative = lib + libdir_relative_tmp = lib endif +libdir_relative ?= $(libdir_relative_tmp) prefix ?= /usr/local libdir = $(prefix)/$(libdir_relative)
Em Thu, Dec 12, 2019 at 11:19:00AM -0500, Steven Rostedt escreveu:
Quoted 6 lines
Arnaldo,
Can you pull this patch in?
Reviewed-by Steven Rostedt (VMware) <[email protected]>
Sure, applied.
- Arnaldo
Quoted 69 lines
-- Steve
Quoted 63 lines · On Sat, 7 Dec 2019 11:14:40 +0000 Sudip Mukherjee…
When I use prefix=/usr and try to install libtraceevent in my laptop it tries to install in
/usr/lib64. I am not having any folder as/usr/lib64and also the debian policy doesnot allow installing in/usr/lib64. It should be in/usr/lib/x86_64-linux-gnu/.Quote: No package for a 64 bit architecture may install files in
/usr/lib64/or in a subdirectory of it.
ref: https://www.debian.org/doc/debian-policy/ch-opersys.htmlMake it more flexible by allowing to mention
libdir_relativewhile installing so that distros can mention the path according to their policy or use the default one.Signed-off-by Sudip Mukherjee <[email protected]>---
Hi Steve,
And yet another one (hopefully the final one for now). I know I missed the merge window, but your Ack should be ok.
tools/lib/traceevent/Makefile | 5 +++-- tools/lib/traceevent/plugins/Makefile | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-)tools/lib/traceevent/Makefile +3
-2@@ -39,11 +39,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) ifeq ($(LP64), 1) - libdir_relative = lib64 + libdir_relative_temp = lib64 else - libdir_relative = lib + libdir_relative_temp = lib endif +libdir_relative ?= $(libdir_relative_temp) prefix ?= /usr/local libdir = $(prefix)/$(libdir_relative) man_dir = $(prefix)/share/mantools/lib/traceevent/plugins/Makefile +3
-2@@ -32,11 +32,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) ifeq ($(LP64), 1) - libdir_relative = lib64 + libdir_relative_tmp = lib64 else - libdir_relative = lib + libdir_relative_tmp = lib endif +libdir_relative ?= $(libdir_relative_tmp) prefix ?= /usr/local libdir = $(prefix)/$(libdir_relative)
Signature · 1 line
- Arnaldo
[tip: perf/urgent] libtraceevent: Allow custom libdir path
In reply to Sudip MukherjeeThe following commit has been merged into the perf/urgent branch of tip:
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: c09982f8e2bae80a66232630ec4ba50afacea486 Gitweb: https://git.kernel.org/tip/c09982f8e2bae80a66232630ec4ba50afacea486 Author: Sudip Mukherjee <[email protected]> AuthorDate: Sat, 07 Dec 2019 11:14:40 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Mon, 16 Dec 2019 13:40:26 -03:00
libtraceevent: Allow custom libdir path
When I use prefix=/usr and try to install libtraceevent in my laptop it tries to install in /usr/lib64. I am not having any folder as /usr/lib64 and also the debian policy doesnot allow installing in /usr/lib64. It should be in /usr/lib/x86_64-linux-gnu/.
Quote: No package for a 64 bit architecture may install files in
/usr/lib64/ or in a subdirectory of it.
ref: https://www.debian.org/doc/debian-policy/ch-opersys.html
Make it more flexible by allowing to mention libdir_relative while installing so that distros can mention the path according to their policy or use the default one.
--- tools/lib/traceevent/Makefile | 5 +++-- tools/lib/traceevent/plugins/Makefile | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-)
tools/lib/traceevent/Makefile +3 -2
@@ -39,11 +39,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) ifeq ($(LP64), 1) - libdir_relative = lib64 + libdir_relative_temp = lib64 else - libdir_relative = lib + libdir_relative_temp = lib endif +libdir_relative ?= $(libdir_relative_temp) prefix ?= /usr/local libdir = $(prefix)/$(libdir_relative) man_dir = $(prefix)/share/man
tools/lib/traceevent/plugins/Makefile +3 -2
@@ -32,11 +32,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) ifeq ($(LP64), 1) - libdir_relative = lib64 + libdir_relative_tmp = lib64 else - libdir_relative = lib + libdir_relative_tmp = lib endif +libdir_relative ?= $(libdir_relative_tmp) prefix ?= /usr/local libdir = $(prefix)/$(libdir_relative)