Skip to contentSkip to conversation

drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

PATCH In review Jerry Han 2 participants 3 messages Dec 6, 2019 – Dec 9, 2019

Subsystems (4)
lore
Share & tools
lore

Jerry Han

author
#0 lore raw

PATCH 1/1 drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.

V9:
- Adjust init code, make the format more concise
- kill off default_off_cmds (Emil)
- use mipi_dsi_dcs_set_display_{on,off} in their enable/disable callbacks. (Emil)
- Adjusting the delay function (Emil)

V8:
- modify PARENTHESIS_ALIGNMENT format (Sam)
- use gpios are required API replace optional gpio API (Emil)

V7:
- Modify communication address

V6:
- Add the information of the reviewer
- Remove unnecessary delays, The udelay_range code gracefully returns without hitting the scheduler on a delay of 0. (Derek)
- Merge the same data structures, like display_mode and off_cmds (Derek)
- Optimize the processing of results returned by devm_gpiod_get_optional (Derek)

V5:
- Add the information of the reviewer (Sam)
- Delete unnecessary header files #include <linux/fb.h> (Sam)
- The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)
- ADD static, set_gpios function is not used outside this module (Sam)

V4:
- Frefix all function maes with boe_ (Sam)
- Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
- Sort include lines alphabetically (Sam)
- Fixed entries in the makefile must be sorted alphabetically (Sam)
- Add send_mipi_cmds function to avoid duplicating the code (Sam)
- Add the necessary delay(reset_delay_t5) between reset and sending the initialization command (Rock wang)

V3:
- Remove unnecessary delays in sending initialization commands (Jitao Shi)

V2:
- Use SPDX identifier (Sam)
- Use necessary header files replace drmP.h (Sam)
- Delete unnecessary header files #include <linux/err.h> (Sam)
- Specifies a GPIOs array to control the reset timing, instead of reading "dsi-reset-sequence" data from DTS (Sam)
- Delete backlight_disable() function when already disabled (Sam)
- Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
- Move the necessary data in the DTS to the current file, like porch, display_mode and Init code etc. (Sam)
- Add compatible device "boe,himax8279d10p" (Sam)

V1:
- Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.

---
 MAINTAINERS                                  |   6 +
 drivers/gpu/drm/panel/Kconfig                |  11 +
 drivers/gpu/drm/panel/Makefile               |   1 +
 drivers/gpu/drm/panel/panel-boe-himax8279d.c | 989 +++++++++++++++++++
 4 files changed, 1007 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c
MAINTAINERS +6 -0
index c2b89453805f..295cb214834c 100644
@@ -5135,6 +5135,12 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
 F:	drivers/gpu/drm/bochs/
 
+DRM DRIVER FOR BOE HIMAX8279D PANELS
+M:	Jerry Han <[email protected]>
+S:	Maintained
+F:	drivers/gpu/drm/panel/panel-boe-himax8279d.c
+F:	Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
+
 DRM DRIVER FOR FARADAY TVE200 TV ENCODER
 M:	Linus Walleij <[email protected]>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
drivers/gpu/drm/panel/Kconfig +11 -0
index f152bc4eeb53..683ff77a3733 100644
@@ -18,6 +18,17 @@ config DRM_PANEL_ARM_VERSATILE
 	  reference designs. The panel is detected using special registers
 	  in the Versatile family syscon registers.
 
+config DRM_PANEL_BOE_HIMAX8279D
+	tristate "Boe Himax8279d panel"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  Say Y here if you want to enable support for Boe Himax8279d
+	  TFT-LCD modules. The panel has a 1200x1920 resolution and uses
+	  24 bit RGB per pixel. It provides a MIPI DSI interface to
+	  the host and has a built-in LED backlight.
+
 config DRM_PANEL_LVDS
 	tristate "Generic LVDS panel driver"
 	depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
index b6cd39fe0f20..8783476110a3 100644
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o
+obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
 obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
 obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
 obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o
drivers/gpu/drm/panel/panel-boe-himax8279d.c new file +989 -0

989 lines not on this page · raw message

Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
I love your patch! Yet something to improve:

Hi Jerry,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-exynos/exynos-drm-next]
[also build test ERROR on drm-intel/for-linux-next linus/master v5.4 next-20191202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jerry-Han/drm-panel-Add-Boe-Himax8279d-MIPI-DSI-LCD-panel/20191208-014258
base:   https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=c6x

If you fix the issue, kindly add following tag

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/panel/panel-boe-himax8279d.c:32:1: error: expected ';', identifier or '(' before 'struct'
    struct panel_desc {
    ^~~~~~
   drivers/gpu/drm/panel/panel-boe-himax8279d.c: In function 'panel_add':
>> drivers/gpu/drm/panel/panel-boe-himax8279d.c:906:2: error: too few arguments to function 'drm_panel_init'
     drm_panel_init(&pinfo->base);
     ^~~~~~~~~~~~~~

In file included from drivers/gpu/drm/panel/panel-boe-himax8279d.c:22:0:
include/drm/drm_panel.h:159:6: note: declared here
void drm_panel_init(struct drm_panel *panel, struct device *dev,
^~~~~~~~~~~~~~

vim +32 drivers/gpu/drm/panel/panel-boe-himax8279d.c

    31	
  > 32	struct panel_desc {
    33		const struct drm_display_mode *display_mode;
    34		unsigned int bpc;
    35		unsigned int width_mm;
    36		unsigned int height_mm;
    37	
    38		unsigned long mode_flags;
    39		enum mipi_dsi_pixel_format format;
    40		unsigned int lanes;
    41		const struct panel_cmd *on_cmds;
    42		unsigned int on_cmds_num;
    43	};
    44	

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

author
#2 lore raw
Quoted 55 lines

Hi Jerry,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-exynos/exynos-drm-next]
[also build test ERROR on drm-intel/for-linux-next linus/master v5.4 next-20191202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jerry-Han/drm-panel-Add-Boe-Himax8279d-MIPI-DSI-LCD-panel/20191208-014258
base:   https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=c6x

If you fix the issue, kindly add following tag

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/panel/panel-boe-himax8279d.c:32:1: error: expected ';', identifier or '(' before 'struct'

    struct panel_desc {
    ^~~~~~

drivers/gpu/drm/panel/panel-boe-himax8279d.c: In function 'panel_add':

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/panel/panel-boe-himax8279d.c:906:2: error: too few arguments to function 'drm_panel_init'

     drm_panel_init(&pinfo->base);
     ^~~~~~~~~~~~~~

In file included from drivers/gpu/drm/panel/panel-boe-himax8279d.c:22:0:
include/drm/drm_panel.h:159:6: note: declared here
void drm_panel_init(struct drm_panel *panel, struct device *dev,
^~~~~~~~~~~~~~

vim +32 drivers/gpu/drm/panel/panel-boe-himax8279d.c

    31
Quoted 1 line

32 struct panel_desc {

    33          const struct drm_display_mode *display_mode;
    34          unsigned int bpc;
    35          unsigned int width_mm;
    36          unsigned int height_mm;
    37
    38          unsigned long mode_flags;
    39          enum mipi_dsi_pixel_format format;
    40          unsigned int lanes;
    41          const struct panel_cmd *on_cmds;
    42          unsigned int on_cmds_num;
    43  };
    44
Quoted 3 lines

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/[email protected] Intel Corporation

OK, Thanks,
I have synchronized to the latest branch.
and I have fixed it.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel