Skip to contentSkip to conversation

package/acsccid: needs iconv

PATCH New Bernd Kuhls 3 participants 3 messages Oct 30, 2019 – Dec 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/acsccid: needs iconv

Upstream commit
https://github.com/acshk/acsccid/commit/5672d821ba96deb6c0c11060e4de0c9dab9b21c7
added "include <iconv.h>"

Fixes:
http://autobuild.buildroot.net/results/04e/04eac264718a47c550bb48b3c36314751fb4de91/

---
 package/acsccid/Config.in  | 1 +
 package/acsccid/acsccid.mk | 4 ++++
 2 files changed, 5 insertions(+)
package/acsccid/Config.in +1 -0
index 90624ee797..74dd6de295 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_ACSCCID
 	depends on BR2_TOOLCHAIN_HAS_THREADS # pcsc-lite, libusb
 	depends on BR2_USE_MMU # pcsc-lite
 	depends on !BR2_STATIC_LIBS # pcsc-lite
+	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	select BR2_PACKAGE_PCSC_LITE
 	# Even though there is a --disable-libusb option, it has in
 	# fact no effect, and acsccid really requires libusb.
package/acsccid/acsccid.mk +4 -0
index abb25ac3be..28a31b95a3 100644
@@ -13,4 +13,8 @@ ACSCCID_INSTALL_STAGING = YES
 ACSCCID_DEPENDENCIES = pcsc-lite host-flex host-pkgconf libusb
 ACSCCID_CONF_OPTS = --enable-usbdropdir=/usr/lib/pcsc/drivers
 
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+ACSCCID_DEPENDENCIES += libiconv
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/acsccid: needs iconv

Quoted 4 lines · On Wed, 30 Oct 2019 06:37:50 +0100 Bernd Kuhls <[email protected]> wrote:

Upstream commit
https://github.com/acshk/acsccid/commit/5672d821ba96deb6c0c11060e4de0c9dab9b21c7
added "include <iconv.h>"

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/04e/04eac264718a47c550bb48b3c36314751fb4de91/

---
 package/acsccid/Config.in  | 1 +
 package/acsccid/acsccid.mk | 4 ++++
 2 files changed, 5 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/acsccid: needs iconv

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Quoted 4 lines · On Wed, 30 Oct 2019 06:37:50 +0100 Bernd Kuhls <[email protected]> wrote:

Upstream commit
https://github.com/acshk/acsccid/commit/5672d821ba96deb6c0c11060e4de0c9dab9b21c7
added "include <iconv.h>"

Quoted 8 lines
Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/04e/04eac264718a47c550bb48b3c36314751fb4de91/

---
package/acsccid/Config.in | 1 +
package/acsccid/acsccid.mk | 4 ++++

2 files changed, 5 insertions(+)

Committed to 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard