Skip to contentSkip to conversation

package/matchbox-desktop: remove unrecognized option

PATCH New Fabrice Fontaine 4 participants 7 messages Oct 30, 2019 – Dec 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/matchbox-desktop: remove unrecognized option

--enable-expat is not a recognized option so remove it

---
 package/matchbox-desktop/matchbox-desktop.mk | 1 -
 1 file changed, 1 deletion(-)
package/matchbox-desktop/matchbox-desktop.mk +0 -1
index 81b13c079c..9054dd80c6 100644
@@ -11,7 +11,6 @@ MATCHBOX_DESKTOP_SITE = http://downloads.yoctoproject.org/releases/matchbox/matc
 MATCHBOX_DESKTOP_LICENSE = GPL-2.0+
 MATCHBOX_DESKTOP_LICENSE_FILES = COPYING
 MATCHBOX_DESKTOP_DEPENDENCIES = matchbox-lib zlib
-MATCHBOX_DESKTOP_CONF_OPTS = --enable-expat
 
 # The bundled configure script does not properly replace LIBADD_DL, so
 # we force an autoreconf even if we don't have any patches touching
Signature · 1 line
2.23.0
#1 lore raw

PATCH 2/2 package/matchbox-desktop: needs -ldl

For an unknown reason, autoreconf does not work anymore to link with -ldl, probably because of a change in the behavior of the deprecated AC_LIBTOOL_DLOPEN macro

As matchox-desktop is not active, just add -ldl to LIBS

Fixes:
- http://autobuild.buildroot.org/results/382a5041b628328808083085f87016547a680478

---
 package/matchbox-desktop/matchbox-desktop.mk | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
package/matchbox-desktop/matchbox-desktop.mk +1 -5
index 9054dd80c6..82d8a44f77 100644
@@ -11,11 +11,7 @@ MATCHBOX_DESKTOP_SITE = http://downloads.yoctoproject.org/releases/matchbox/matc
 MATCHBOX_DESKTOP_LICENSE = GPL-2.0+
 MATCHBOX_DESKTOP_LICENSE_FILES = COPYING
 MATCHBOX_DESKTOP_DEPENDENCIES = matchbox-lib zlib
-
-# The bundled configure script does not properly replace LIBADD_DL, so
-# we force an autoreconf even if we don't have any patches touching
-# configure.ac/Makefile.am.
-MATCHBOX_DESKTOP_AUTORECONF = YES
+MATCHBOX_DESKTOP_CONF_ENV = LIBS=-ldl
 
 ifeq ($(BR2_PACKAGE_STARTUP_NOTIFICATION),y)
 MATCHBOX_DESKTOP_CONF_OPTS += --enable-startup-notification
Signature · 1 line
2.23.0
#2 lore raw

PATCH 2/2 package/matchbox-desktop: needs -ldl

Fabrice, All,

On 2019-10-30 10:22 +0100, Fabrice Fontaine spake thusly:

Quoted 3 lines

For an unknown reason, autoreconf does not work anymore to link with -ldl, probably because of a change in the behavior of the deprecated AC_LIBTOOL_DLOPEN macro

I'd like to understand what is really going on here, because there are build more recent than this one, which do build successfully:

    http://autobuild.buildroot.org/results/c9c/c9c02c2c6d29f447c82adf9c05c141f288de1754/

So definitely, the autoreconf does work in some cases.

So, can we identify the reason it fails in some caes and not in others?

Regards,
Yann E. MORIN.

Quoted 30 lines

As matchox-desktop is not active, just add -ldl to LIBS

Fixes:
- http://autobuild.buildroot.org/results/382a5041b628328808083085f87016547a680478

---
 package/matchbox-desktop/matchbox-desktop.mk | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
package/matchbox-desktop/matchbox-desktop.mk +1 -5
index 9054dd80c6..82d8a44f77 100644
@@ -11,11 +11,7 @@ MATCHBOX_DESKTOP_SITE = http://downloads.yoctoproject.org/releases/matchbox/matc
 MATCHBOX_DESKTOP_LICENSE = GPL-2.0+
 MATCHBOX_DESKTOP_LICENSE_FILES = COPYING
 MATCHBOX_DESKTOP_DEPENDENCIES = matchbox-lib zlib
-
-# The bundled configure script does not properly replace LIBADD_DL, so
-# we force an autoreconf even if we don't have any patches touching
-# configure.ac/Makefile.am.
-MATCHBOX_DESKTOP_AUTORECONF = YES
+MATCHBOX_DESKTOP_CONF_ENV = LIBS=-ldl
 
 ifeq ($(BR2_PACKAGE_STARTUP_NOTIFICATION),y)
 MATCHBOX_DESKTOP_CONF_OPTS += --enable-startup-notification
Signature · 1 line
2.23.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 2/2 package/matchbox-desktop: needs -ldl

Hi Yann,

Le mer. 20 nov. 2019 ? 19:23, Yann E. MORIN <[email protected]> a ?crit :

Quoted 8 lines

Fabrice, All,

On 2019-10-30 10:22 +0100, Fabrice Fontaine spake thusly:

Quoted 3 lines

For an unknown reason, autoreconf does not work anymore to link with -ldl, probably because of a change in the behavior of the deprecated AC_LIBTOOL_DLOPEN macro

Quoted 7 lines

I'd like to understand what is really going on here, because there are build more recent than this one, which do build successfully:

    http://autobuild.buildroot.org/results/c9c/c9c02c2c6d29f447c82adf9c05c141f288de1754/

So definitely, the autoreconf does work in some cases.

So, can we identify the reason it fails in some caes and not in others?

Build failures started on October 22nd so perhaps this issue is also linked to commit 9cc8680fe54c0b8f5008158e36e2157127f03a7e. There is already discussions ongoing about if for gmpc that missed -lm
(https://patchwork.ozlabs.org/patch/1186343/) and libv4l that missed -latomic (https://patchwork.ozlabs.org/patch/1186541).

Quoted 37 lines

Regards,
Yann E. MORIN.

Quoted 28 lines

As matchox-desktop is not active, just add -ldl to LIBS

Fixes:
- http://autobuild.buildroot.org/results/382a5041b628328808083085f87016547a680478

---
 package/matchbox-desktop/matchbox-desktop.mk | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
package/matchbox-desktop/matchbox-desktop.mk +1 -6
index 9054dd80c6..82d8a44f77 100644
@@ -11,11 +11,7 @@ MATCHBOX_DESKTOP_SITE = http://downloads.yoctoproject.org/releases/matchbox/matc
 MATCHBOX_DESKTOP_LICENSE = GPL-2.0+
 MATCHBOX_DESKTOP_LICENSE_FILES = COPYING
 MATCHBOX_DESKTOP_DEPENDENCIES = matchbox-lib zlib
-
-# The bundled configure script does not properly replace LIBADD_DL, so
-# we force an autoreconf even if we don't have any patches touching
-# configure.ac/Makefile.am.
-MATCHBOX_DESKTOP_AUTORECONF = YES
+MATCHBOX_DESKTOP_CONF_ENV = LIBS=-ldl
 
 ifeq ($(BR2_PACKAGE_STARTUP_NOTIFICATION),y)
 MATCHBOX_DESKTOP_CONF_OPTS += --enable-startup-notification
--
Quoted 2 lines

2.23.0

--
.-----------------.--------------------.------------------.--------------------.

Quoted 5 lines
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

Best Regards,

Fabrice

#4 lore raw

PATCH 2/2 package/matchbox-desktop: needs -ldl

Quoted 4 lines · On Wed, 20 Nov 2019 20:06:12 +0100 Fabrice Fontaine…
Quoted 4 lines

I'd like to understand what is really going on here, because there are build more recent than this one, which do build successfully:

    http://autobuild.buildroot.org/results/c9c/c9c02c2c6d29f447c82adf9c05c141f288de1754/
Quoted 8 lines
Quoted 3 lines

So definitely, the autoreconf does work in some cases.

So, can we identify the reason it fails in some caes and not in others?

Build failures started on October 22nd so perhaps this issue is also linked to commit 9cc8680fe54c0b8f5008158e36e2157127f03a7e. There is already discussions ongoing about if for gmpc that missed -lm
(https://patchwork.ozlabs.org/patch/1186343/) and libv4l that missed -latomic (https://patchwork.ozlabs.org/patch/1186541).

I did a test, and I can confirm that
http://patchwork.ozlabs.org/patch/1204728/ fixes the matchbox-desktop build issue, and makes this patch not needed.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/2 package/matchbox-desktop: remove unrecognized option

In reply to Fabrice Fontaine
Quoted 6 lines · On Wed, 30 Oct 2019 10:22:44 +0100 Fabrice Fontaine…

--enable-expat is not a recognized option so remove it

---
 package/matchbox-desktop/matchbox-desktop.mk | 1 -
 1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/2 package/matchbox-desktop: remove unrecognized option

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Quoted 6 lines · On Wed, 30 Oct 2019 10:22:44 +0100 Fabrice Fontaine…

--enable-expat is not a recognized option so remove it

---
package/matchbox-desktop/matchbox-desktop.mk | 1 -

1 file changed, 1 deletion(-)

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard