mm: clean up obsolete check on space in page->flags
Subsystems (2)
PATCH 1/1 mm: clean up obsolete check on space in page->flags
The check in linux/mm.h was intended to make sure we don't overrun page flags. But it's obsolete because it doesn't include LAST_CPUPID_WIDTH nor KASAN_TAG_WIDTH.
Just remove check since we already have it covered in linux/page-flags-layout.h (near the end of the file).
Signed-off-by Yu Zhao <[email protected]>
--- include/linux/mm.h | 4 ---- 1 file changed, 4 deletions(-)
include/linux/mm.h +0 -4
@@ -921,10 +921,6 @@ vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf);#define ZONEID_PGSHIFT (ZONEID_PGOFF * (ZONEID_SHIFT != 0)) -#if SECTIONS_WIDTH +NODES_WIDTH +ZONES_WIDTH >BITS_PER_LONG -NR_PAGEFLAGS -#error SECTIONS_WIDTH+NODES_WIDTH+ZONES_WIDTH > BITS_PER_LONG - NR_PAGEFLAGS -#endif -#define ZONES_MASK ((1UL << ZONES_WIDTH) - 1)#define NODES_MASK ((1UL << NODES_WIDTH) - 1)#define SECTIONS_MASK ((1UL << SECTIONS_WIDTH) - 1)
Signature · 1 line
2.24.0.393.g34dc348eaf-goog
Quoted 18 lines · Yu Zhao
The check in
linux/mm.hwas intended to make sure we don't overrun page flags. But it's obsolete because it doesn't includeLAST_CPUPID_WIDTHnorKASAN_TAG_WIDTH.Just remove check since we already have it covered in
linux/page-flags-layout.h(near the end of the file).Signed-off-by Yu Zhao <[email protected]>--- include/linux/mm.h | 4 ---- 1 file changed, 4 deletions(-)include/linux/mm.h +0
-0
include/linux/mm.h vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf); · line 926
Quoted 10 lines
include/linux/mm.h +0
-4@@ -921,10 +921,6 @@ vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf);#define ZONEID_PGSHIFT (ZONEID_PGOFF * (ZONEID_SHIFT != 0)) -#if SECTIONS_WIDTH +NODES_WIDTH +ZONES_WIDTH >BITS_PER_LONG -NR_PAGEFLAGS -#error SECTIONS_WIDTH+NODES_WIDTH+ZONES_WIDTH > BITS_PER_LONG - NR_PAGEFLAGS -#endif -#define ZONES_MASK ((1UL << ZONES_WIDTH) - 1)#define NODES_MASK ((1UL << NODES_WIDTH) - 1)#define SECTIONS_MASK ((1UL << SECTIONS_WIDTH) - 1)
Reviewed-by David Hildenbrand <[email protected]>
Signature · 3 lines
Thanks, David / dhildenb