tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
PATCH 1/1 tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
Loop through the connector's modes for both the tiled connectors and find a mode that matches the tile h size and tile v size. Request a modeset on this mode for both tiled connectors.
--- tests/kms_dp_tiled_display.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
tests/kms_dp_tiled_display.c +16 -2
@@ -207,9 +207,10 @@ static void test_cleanup(data_t *data)static void setup_mode (data_t *data) { -int count =0 , prev =0 ; -bool pipe_in_use = false; +int count =0 , prev =0 , i =0 ; +bool pipe_in_use = false, found = false;enum pipe pipe; +drmModeModeInfo *mode;igt_output_t *output;data_connector_t *conns = data->conns;
@@ -226,6 +227,8 @@ static void setup_mode(data_t *data)for_each_pipe (data->display, pipe) { pipe_in_use = false; + found = false; +if (count >0 ) {for (prev = count -1 ; prev >=0 ; prev--) {if (pipe == conns[prev].pipe) {
@@ -247,6 +250,17 @@ static void setup_mode(data_t *data) } }igt_require (conns[count].pipe !=PIPE_NONE ); + +for (i =0 ; i < conns[count].connector->count_modes; i++) { + mode = &conns[count].connector->modes[i]; +if (mode->vdisplay == conns[count].tile.tile_v_size && + mode->hdisplay == conns[count].tile.tile_h_size) { + found = true; +break ; + } + } +igt_require (found); +igt_output_override_mode (output, mode); }igt_display_commit_atomic (data->display,DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL );
Signature · 6 lines
2.22.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
== Series Details ==
== Series Details ==
Series: tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
URL : https://patchwork.freedesktop.org/series/70606/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7511 -> IGTPW_3827
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3827 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_3827, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
Known issues
------------
Here are the changes found in IGTPW_3827 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@bad-close:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-bxt-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/fi-bxt-dsi/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [INCOMPLETE][3] ([i915#45]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
Participating hosts (26 -> 9)
------------------------------
ERROR: It appears as if the changes made in IGTPW_3827 prevented too many machines from booting.
Missing (17): fi-kbl-soraka fi-ilk-m540 fi-bdw-5557u fi-bdw-gvtdvm fi-glk-dsi fi-byt-squawks fi-bwr-2160 fi-apl-guc fi-bsw-cyan fi-ctg-p8600 fi-kbl-guc fi-ivb-3770 fi-pnv-d510 fi-bsw-kefka fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5339 -> IGTPW_3827
CI-20190529: 20190529
CI_DRM_7511: 04ca2c0fb47c3d394a364f5f71943ca9f440dda7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3827: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
IGT_5339: d45e11f8e10a4c5775372002ec89974ce3d97b27 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
This looks like an unrelated failure and a false positive
Manasi
Quoted 71 lines · Patchwork
== Series Details ==
Series: tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
URL : https://patchwork.freedesktop.org/series/70606/
State : failure== Summary ==
CI Bug Log - changes from
CI_DRM_7511->IGTPW_3827
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
IGTPW_3827absolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
IGTPW_3827, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
Known issues
------------Here are the changes found in
IGTPW_3827that come from known issues:### IGT changes ###
#### Issues hit ####
* igt@gem_basic@bad-close:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-bxt-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/fi-bxt-dsi/igt@[email protected]#### Possible fixes ####
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [INCOMPLETE][3] ([i915#45]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45Participating hosts (26 -> 9)
------------------------------ERROR: It appears as if the changes made in
IGTPW_3827prevented too many machines from booting.Missing (17): fi-kbl-soraka fi-ilk-m540 fi-bdw-5557u fi-bdw-gvtdvm fi-glk-dsi fi-byt-squawks fi-bwr-2160 fi-apl-guc fi-bsw-cyan fi-ctg-p8600 fi-kbl-guc fi-ivb-3770 fi-pnv-d510 fi-bsw-kefka fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------* CI: CI-20190529 -> None
* IGT:IGT_5339->IGTPW_3827CI-20190529: 20190529
CI_DRM_7511:04ca2c0fb47c3d394a364f5f71943ca9f440dda7@git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3827: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
IGT_5339:d45e11f8e10a4c5775372002ec89974ce3d97b27@git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Quoted 7 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 5 lines · Karthik B S
Loop through the connector's modes for both the tiled connectors and find a mode that matches the tile h size and tile v size. Request a modeset on this mode for both tiled connectors.
Signed-off-by Karthik B S <[email protected]>
Looks good to me,
Could you test if the kernel taints go away with my new patch series:
https://patchwork.freedesktop.org/series/70722/
Manasi
Quoted 51 lines
--- tests/kms_dp_tiled_display.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)tests/kms_dp_tiled_display.c +16
-2@@ -207,9 +207,10 @@ static void test_cleanup(data_t *data)static void setup_mode (data_t *data) { -int count =0 , prev =0 ; -bool pipe_in_use = false; +int count =0 , prev =0 , i =0 ; +bool pipe_in_use = false, found = false;enum pipe pipe; +drmModeModeInfo *mode;igt_output_t *output;data_connector_t *conns = data->conns;@@ -226,6 +227,8 @@ static void setup_mode(data_t *data)for_each_pipe (data->display, pipe) { pipe_in_use = false; + found = false; +if (count >0 ) {for (prev = count -1 ; prev >=0 ; prev--) {if (pipe == conns[prev].pipe) {@@ -247,6 +250,17 @@ static void setup_mode(data_t *data) } }igt_require (conns[count].pipe !=PIPE_NONE ); + +for (i =0 ; i < conns[count].connector->count_modes; i++) { + mode = &conns[count].connector->modes[i]; +if (mode->vdisplay == conns[count].tile.tile_v_size && + mode->hdisplay == conns[count].tile.tile_h_size) { + found = true; +break ; + } + } +igt_require (found); +igt_output_override_mode (output, mode); }igt_display_commit_atomic (data->display,DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL );Signature · 1 line
2.22.0
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Thank you for the patch, pushed to igt
Quoted 56 lines · Karthik B S
Loop through the connector's modes for both the tiled connectors and find a mode that matches the tile h size and tile v size. Request a modeset on this mode for both tiled connectors.
Signed-off-by Karthik B S <[email protected]>--- tests/kms_dp_tiled_display.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)tests/kms_dp_tiled_display.c +16
-2@@ -207,9 +207,10 @@ static void test_cleanup(data_t *data)static void setup_mode (data_t *data) { -int count =0 , prev =0 ; -bool pipe_in_use = false; +int count =0 , prev =0 , i =0 ; +bool pipe_in_use = false, found = false;enum pipe pipe; +drmModeModeInfo *mode;igt_output_t *output;data_connector_t *conns = data->conns;@@ -226,6 +227,8 @@ static void setup_mode(data_t *data)for_each_pipe (data->display, pipe) { pipe_in_use = false; + found = false; +if (count >0 ) {for (prev = count -1 ; prev >=0 ; prev--) {if (pipe == conns[prev].pipe) {@@ -247,6 +250,17 @@ static void setup_mode(data_t *data) } }igt_require (conns[count].pipe !=PIPE_NONE ); + +for (i =0 ; i < conns[count].connector->count_modes; i++) { + mode = &conns[count].connector->modes[i]; +if (mode->vdisplay == conns[count].tile.tile_v_size && + mode->hdisplay == conns[count].tile.tile_h_size) { + found = true; +break ; + } + } +igt_require (found); +igt_output_override_mode (output, mode); }igt_display_commit_atomic (data->display,DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL );Signature · 1 line
2.22.0
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
In reply to Karthik B S== Series Details ==
== Series Details ==
Series: tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
URL : https://patchwork.freedesktop.org/series/70606/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7511 -> IGTPW_3827
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3827 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_3827, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
Known issues
------------
Here are the changes found in IGTPW_3827 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@bad-close:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-bxt-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/fi-bxt-dsi/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [INCOMPLETE][3] ([i915#45]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
Participating hosts (26 -> 9)
------------------------------
ERROR: It appears as if the changes made in IGTPW_3827 prevented too many machines from booting.
Missing (17): fi-kbl-soraka fi-ilk-m540 fi-bdw-5557u fi-bdw-gvtdvm fi-glk-dsi fi-byt-squawks fi-bwr-2160 fi-apl-guc fi-bsw-cyan fi-ctg-p8600 fi-kbl-guc fi-ivb-3770 fi-pnv-d510 fi-bsw-kefka fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5339 -> IGTPW_3827
CI-20190529: 20190529
CI_DRM_7511: 04ca2c0fb47c3d394a364f5f71943ca9f440dda7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3827: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
IGT_5339: d45e11f8e10a4c5775372002ec89974ce3d97b27 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3827/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev