Skip to contentSkip to conversation

mtd: rawnand: denali: error out if platform has no associated data

PATCH New Masahiro Yamada 1 participant 1 message Dec 9, 2019

Subsystems (3)
Memory technology devices (MTD) NAND flash Denali NAND driver
lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 mtd: rawnand: denali: error out if platform has no associated data

From: Masahiro Yamada <[email protected]>

denali->ecc_caps is a mandatory parameter. If it were left unset, nand_ecc_choose_conf() would end up with NULL pointer access.

So, every compatible must be associated with proper denali_dt_data. If of_device_get_match_data() returns NULL, let it fail immediately.

Signed-off-by Masahiro Yamada <[email protected]>

---

 drivers/mtd/nand/raw/denali_dt.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/mtd/nand/raw/denali_dt.c +6 -5
index 8b779a899dcf..276187939689 100644
@@ -118,11 +118,12 @@ static int denali_dt_probe(struct platform_device *pdev)
 	denali = &dt->controller;
 
 	data = of_device_get_match_data(dev);
-	if (data) {
-		denali->revision = data->revision;
-		denali->caps = data->caps;
-		denali->ecc_caps = data->ecc_caps;
-	}
+	if (WARN_ON(!data))
+		return -EINVAL;
+
+	denali->revision = data->revision;
+	denali->caps = data->caps;
+	denali->ecc_caps = data->ecc_caps;
 
 	denali->dev = dev;
 	denali->irq = platform_get_irq(pdev, 0);
Signature · 6 lines
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/