Skip to contentSkip to conversation

drm/gma500: add a missed gma_power_end in error path

PATCH Applied Chuhong Yuan 2 participants 2 messages Dec 9, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/gma500: add a missed gma_power_end in error path

oaktrail_lvds_mode_set() misses a gma_power_end() in an error path. Add the call to fix it.

---
 drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/gma500/oaktrail_lvds.c +1 -0
index 7390403ea1b7..582e09597500 100644
@@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
 
 	if (!connector) {
 		DRM_ERROR("Couldn't find connector when setting mode");
+		gma_power_end(dev);
 		return;
 	}
 
Signature · 1 line
2.24.0
maintainer Applied
#1 lore raw
Quoted 5 lines · Chuhong Yuan

oaktrail_lvds_mode_set() misses a gma_power_end() in an error path. Add the call to fix it.

Hi Chuhong, thanks for the patch.

Applied to drm-misc-next

-Patrik

Quoted 19 lines
---
 drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/gma500/oaktrail_lvds.c +1 -1
index 7390403ea1b7..582e09597500 100644
@@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
 
        if (!connector) {
                DRM_ERROR("Couldn't find connector when setting mode");
+               gma_power_end(dev);
                return;
        }
 
--

2.24.0