Skip to contentSkip to conversation

dt-bindings: usb: Convert Allwinner USB PHY controller to a schema

PATCH Applied Maxime Ripard 2 participants 2 messages Dec 9, 2019 – Dec 18, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: usb: Convert Allwinner USB PHY controller to a schema

The Allwinner SoCs have a USB PHY controller that is supported in Linux, with a matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas.

---

Changes from v1:
- Split the schemas into files of their own to make it more readable

---
 .../phy/allwinner,sun4i-a10-usb-phy.yaml      | 105 ++++++++++++++
 .../phy/allwinner,sun50i-a64-usb-phy.yaml     | 106 ++++++++++++++
 .../phy/allwinner,sun50i-h6-usb-phy.yaml      | 105 ++++++++++++++
 .../phy/allwinner,sun5i-a13-usb-phy.yaml      |  93 ++++++++++++
 .../phy/allwinner,sun6i-a31-usb-phy.yaml      | 119 +++++++++++++++
 .../phy/allwinner,sun8i-a23-usb-phy.yaml      | 102 +++++++++++++
 .../phy/allwinner,sun8i-a83t-usb-phy.yaml     | 122 ++++++++++++++++
 .../phy/allwinner,sun8i-h3-usb-phy.yaml       | 137 ++++++++++++++++++
 .../phy/allwinner,sun8i-r40-usb-phy.yaml      | 119 +++++++++++++++
 .../phy/allwinner,sun8i-v3s-usb-phy.yaml      |  86 +++++++++++
 .../devicetree/bindings/phy/sun4i-usb-phy.txt |  68 ---------
 11 files changed, 1094 insertions(+), 68 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun4i-a10-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun50i-h6-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun5i-a13-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-a23-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-a83t-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-h3-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-r40-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-v3s-usb-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
Documentation/devicetree/bindings/phy/allwinner,sun4i-a10-usb-phy.yaml new file +105 -0
new file mode 100644
index 000000000000..020ef9e4c411
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/allwinner,sun4i-a10-usb-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner A10 USB PHY Device Tree Bindings
+
+maintainers:
+  - Chen-Yu Tsai <[email protected]>
+  - Maxime Ripard <[email protected]>
+
+properties:
+  "#phy-cells":
+    const: 1
+
+  compatible:
+    enum:
+      - allwinner,sun4i-a10-usb-phy
+      - allwinner,sun7i-a20-usb-phy
+
+  reg:
+    items:
+      - description: PHY Control registers
+      - description: PHY PMU1 registers
+      - description: PHY PMU2 registers
+
+  reg-names:
+    items:
+      - const: phy_ctrl
+      - const: pmu1
+      - const: pmu2
+
+  clocks:
+    maxItems: 1
+    description: USB PHY bus clock
+
+  clock-names:
+    const: usb_phy
+
+  resets:
+    items:
+      - description: USB OTG reset
+      - description: USB Host 1 Controller reset
+      - description: USB Host 2 Controller reset
+
+  reset-names:
+    items:
+      - const: usb0_reset
+      - const: usb1_reset
+      - const: usb2_reset
+
+  usb0_id_det-gpios:
+    description: GPIO to the USB OTG ID pin
+
+  usb0_vbus_det-gpios:
+    description: GPIO to the USB OTG VBUS detect pin
+
+  usb0_vbus_power-supply:
+    description: Power supply to detect the USB OTG VBUS
+
+  usb0_vbus-supply:
+    description: Regulator controlling USB OTG VBUS
+
+  usb1_vbus-supply:
+    description: Regulator controlling USB1 Host controller
+
+  usb2_vbus-supply:
+    description: Regulator controlling USB2 Host controller
+
+required:
+  - "#phy-cells"
+  - compatible
+  - clocks
+  - clock-names
+  - reg
+  - reg-names
+  - resets
+  - reset-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/clock/sun4i-a10-ccu.h>
+    #include <dt-bindings/reset/sun4i-a10-ccu.h>
+
+    usbphy: phy@01c13400 {
+        #phy-cells = <1>;
+        compatible = "allwinner,sun4i-a10-usb-phy";
+        reg = <0x01c13400 0x10>, <0x01c14800 0x4>, <0x01c1c800 0x4>;
+        reg-names = "phy_ctrl", "pmu1", "pmu2";
+        clocks = <&ccu CLK_USB_PHY>;
+        clock-names = "usb_phy";
+        resets = <&ccu RST_USB_PHY0>,
+                 <&ccu RST_USB_PHY1>,
+                 <&ccu RST_USB_PHY2>;
+        reset-names = "usb0_reset", "usb1_reset", "usb2_reset";
+        usb0_id_det-gpios = <&pio 7 19 GPIO_ACTIVE_HIGH>;
+        usb0_vbus_det-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>;
+        usb0_vbus-supply = <&reg_usb0_vbus>;
+        usb1_vbus-supply = <&reg_usb1_vbus>;
+        usb2_vbus-supply = <&reg_usb2_vbus>;
+    };
Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml new file +106 -0

106 lines not on this page · raw message

Documentation/devicetree/bindings/phy/allwinner,sun50i-h6-usb-phy.yaml new file +105 -0

105 lines not on this page · raw message

Documentation/devicetree/bindings/phy/allwinner,sun5i-a13-usb-phy.yaml new file +93 -0

93 lines not on this page · raw message

Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-usb-phy.yaml new file +119 -0

119 lines not on this page · raw message

Documentation/devicetree/bindings/phy/allwinner,sun8i-a23-usb-phy.yaml new file +102 -0

102 lines not on this page · raw message

Documentation/devicetree/bindings/phy/allwinner,sun8i-a83t-usb-phy.yaml new file +122 -0

122 lines not on this page · raw message

Documentation/devicetree/bindings/phy/allwinner,sun8i-h3-usb-phy.yaml new file +137 -0

137 lines not on this page · raw message

Documentation/devicetree/bindings/phy/allwinner,sun8i-r40-usb-phy.yaml new file +119 -0

119 lines not on this page · raw message

Documentation/devicetree/bindings/phy/allwinner,sun8i-v3s-usb-phy.yaml new file +86 -0

86 lines not on this page · raw message

Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt deleted +0 -68

68 lines not on this page · raw message

Signature · 1 line
2.23.0
maintainer Applied
#1 lore raw
Quoted 28 lines · Maxime Ripard

The Allwinner SoCs have a USB PHY controller that is supported in Linux, with a matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas.

---

Changes from v1:
- Split the schemas into files of their own to make it more readable

---
 .../phy/allwinner,sun4i-a10-usb-phy.yaml      | 105 ++++++++++++++
 .../phy/allwinner,sun50i-a64-usb-phy.yaml     | 106 ++++++++++++++
 .../phy/allwinner,sun50i-h6-usb-phy.yaml      | 105 ++++++++++++++
 .../phy/allwinner,sun5i-a13-usb-phy.yaml      |  93 ++++++++++++
 .../phy/allwinner,sun6i-a31-usb-phy.yaml      | 119 +++++++++++++++
 .../phy/allwinner,sun8i-a23-usb-phy.yaml      | 102 +++++++++++++
 .../phy/allwinner,sun8i-a83t-usb-phy.yaml     | 122 ++++++++++++++++
 .../phy/allwinner,sun8i-h3-usb-phy.yaml       | 137 ++++++++++++++++++
 .../phy/allwinner,sun8i-r40-usb-phy.yaml      | 119 +++++++++++++++
 .../phy/allwinner,sun8i-v3s-usb-phy.yaml      |  86 +++++++++++
 .../devicetree/bindings/phy/sun4i-usb-phy.txt |  68 ---------
 11 files changed, 1094 insertions(+), 68 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun4i-a10-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun50i-h6-usb-phy.yaml
Quoted 9 lines
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun5i-a13-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-a23-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-a83t-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-h3-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-r40-usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-v3s-usb-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt

Applied, thanks.

Rob