librsync: new package
PATCH 1/1 librsync: new package
From: Bartosz Golaszewski <[email protected]>
rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).
This recipe adds new packages for librsync and rdiff.
--- .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +18 -0
@@ -0,0 +1,18 @@ +SUMMARY = "Remote delta-compression library." +AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert" + +LICENSE = "LGPLv2.1+" +LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499" + +SRC_URI = "git://github.com/librsync/librsync.git" +SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d" +S = "${WORKDIR}/git" + +DEPENDS = "popt" + +inherit cmake + +BBCLASSEXTEND = "native nativesdk" + +PACKAGES =+ "rdiff" +FILES_rdiff = "/usr/bin/rdiff"
Signature · 1 line
2.23.0
Hi Bartosz,
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).
Nice, I added it (really, 2.1) to my public layer, but this definetely belongs to OE:
https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb
Quoted 15 lines
This recipe adds new packages for librsync and rdiff.
Signed-off-by Bartosz Golaszewski <[email protected]>--- .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bbmeta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +1
-0@@ -0,0 +1,18 @@ +SUMMARY = "Remote delta-compression library."
meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 11
Quoted 10 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +10
-0+AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert" + +LICENSE = "LGPLv2.1+" +LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499" + +SRC_URI = "git://github.com/librsync/librsync.git" +SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d" +S = "${WORKDIR}/git" + +DEPENDS = "popt"
Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 18
Quoted 8 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +7
-0+ +inherit cmake + +BBCLASSEXTEND = "native nativesdk" + +PACKAGES =+ "rdiff" +FILES_rdiff = "/usr/bin/rdiff"
Best regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
pon., 9 gru 2019 o 15:53 Stefano Babic <[email protected]> napisał(a):
Quoted 11 lines
Hi Bartosz,
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).
Quoted 5 lines
Nice, I added it (really, 2.1) to my public layer, but this definetely belongs to OE:
https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb
Ha! Somehow it didn't pop up in google search. If you want you can send your own patch instead of this one.
We probably have the same idea for updates - I'm using it in my binary-delta update module for mender.
Quoted 21 lines
Quoted 21 lines
This recipe adds new packages for librsync and rdiff.
Signed-off-by Bartosz Golaszewski <[email protected]>--- .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bbmeta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +6
-0@@ -0,0 +1,18 @@ +SUMMARY = "Remote delta-compression library." +AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert" + +LICENSE = "LGPLv2.1+" +LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499" +
Quoted 9 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 11
Quoted 5 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +5
-0+SRC_URI = "git://github.com/librsync/librsync.git" +SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d" +S = "${WORKDIR}/git" + +DEPENDS = "popt"Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
Sure - it probably should become a PACKAGECONFIG option.
Bartosz
Quoted 18 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 18
Quoted 8 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +7
-0+ +inherit cmake + +BBCLASSEXTEND = "native nativesdk" + +PACKAGES =+ "rdiff" +FILES_rdiff = "/usr/bin/rdiff"Best regards,
Stefano--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
Quoted 12 lines · Bartosz Golaszewski
pon., 9 gru 2019 o 15:53 Stefano Babic <[email protected]> napisał(a):
Quoted 11 lines
Hi Bartosz,
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).
Quoted 7 lines
Quoted 4 lines
Nice, I added it (really, 2.1) to my public layer, but this definetely belongs to OE:
https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb
Ha! Somehow it didn't pop up in google search.
...
Better than Google is
http://layers.openembedded.org/layerindex/branch/master/recipes/?q=librsync
cu
Adrian
A message that is not in the archive (sent off-list or not yet received): CAMpxmJXDQh1vi7Eo-ZZZsyZ82n_X+n+-R2aGaxrYK1-TZ-5VbQ@mail.gmail.com
Hi Bartosz,
Quoted 12 lines · Bartosz Golaszewski
pon., 9 gru 2019 o 15:53 Stefano Babic <[email protected]> napisał(a):
Quoted 11 lines
Hi Bartosz,
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).
Quoted 8 lines
Quoted 5 lines
Nice, I added it (really, 2.1) to my public layer, but this definetely belongs to OE:
https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb
Ha! Somehow it didn't pop up in google search. If you want you can send your own patch instead of this one.
I am fine with yours, too ;-)
Quoted 3 lines
We probably have the same idea for updates - I'm using it in my binary-delta update module for mender.
Exactly the same idea: I am using it for binary-delta update in SWUpdate ;-)
Quoted 32 lines
Quoted 22 lines
Quoted 22 lines
This recipe adds new packages for librsync and rdiff.
Signed-off-by Bartosz Golaszewski <[email protected]>--- .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bbmeta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +6
-0@@ -0,0 +1,18 @@ +SUMMARY = "Remote delta-compression library." +AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert" + +LICENSE = "LGPLv2.1+" +LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499" +Quoted 9 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 11
Quoted 5 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +5
-0+SRC_URI = "git://github.com/librsync/librsync.git" +SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d" +S = "${WORKDIR}/git" + +DEPENDS = "popt"Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
Quoted 1 line
Sure - it probably should become a PACKAGECONFIG option.
Well, anyway the library without compression support loses most of its meaning... But a PACKAGECONFIG with default as on for both compression libraries is fine.
Best regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
Quoted 4 lines · Stefano Babic
...
Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
...
Is it also working for you?
https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
https://github.com/librsync/librsync/issues/8
cu
Adrian
Quoted 9 lines · Adrian Bunk
Quoted 4 lines · Stefano Babic
...
Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
...Is it also working for you?
https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
https://github.com/librsync/librsync/issues/8
Oh, good catch, I was not aware of it. I guess not, because I saw the dependencies when I wrote the recipe, but I *never* set ENABLE_COMPRESSION..
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
pon., 9 gru 2019 o 16:22 Stefano Babic <[email protected]> napisał(a):
Quoted 8 lines · Adrian Bunk
Quoted 6 lines · Stefano Babic
Quoted 4 lines
...
Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
...
Quoted 7 lines
Quoted 3 lines
Is it also working for you?
https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
https://github.com/librsync/librsync/issues/8Oh, good catch, I was not aware of it. I guess not, because I saw the dependencies when I wrote the recipe, but I *never* set
ENABLE_COMPRESSION..
Is this really something that needs to be provided by rdiff? We can just pipe the output to a compressor of your choice.
Bart
Quoted 9 lines
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
Quoted 13 lines · Bartosz Golaszewski
pon., 9 gru 2019 o 16:22 Stefano Babic <[email protected]> napisał(a):
Quoted 12 lines · Adrian Bunk
Quoted 9 lines · Stefano Babic
Quoted 4 lines
...
Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
...Is it also working for you?
https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
https://github.com/librsync/librsync/issues/8
Quoted 6 lines
Quoted 3 lines
Oh, good catch, I was not aware of it. I guess not, because I saw the dependencies when I wrote the recipe, but I *never* set
ENABLE_COMPRESSION..Is this really something that needs to be provided by rdiff? We can just pipe the output to a compressor of your choice.
Yes, I realized that it is not required by librsync - I already compress the output of rdiff to generate the delta, no need to integrate it. Sorry for noise.
What about to put the binary "rdiff" into a separate "bin" package ? I have rescue system where footprint is an issue, and rdiff is not required on target.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
pon., 9 gru 2019 o 17:23 Stefano Babic <[email protected]> napisał(a):
Quoted 22 lines · Bartosz Golaszewski
Quoted 13 lines
pon., 9 gru 2019 o 16:22 Stefano Babic <[email protected]> napisał(a):
Quoted 12 lines · Adrian Bunk
Quoted 9 lines · Stefano Babic
Quoted 4 lines
...
Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
...Is it also working for you?
https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
https://github.com/librsync/librsync/issues/8Quoted 6 lines
Quoted 3 lines
Oh, good catch, I was not aware of it. I guess not, because I saw the dependencies when I wrote the recipe, but I *never* set
ENABLE_COMPRESSION..Is this really something that needs to be provided by rdiff? We can just pipe the output to a compressor of your choice.
Quoted 8 lines
Yes, I realized that it is not required by librsync - I already compress the output of rdiff to generate the delta, no need to integrate it. Sorry for noise.
What about to put the binary "rdiff" into a separate "bin" package ? I have rescue system where footprint is an issue, and rdiff is not required on target.
But this is what I did in my patch.
Bart
Quoted 9 lines
Regards,
Stefano--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
Quoted 27 lines · Bartosz Golaszewski
pon., 9 gru 2019 o 17:23 Stefano Babic <[email protected]> napisał(a):
Quoted 26 lines · Bartosz Golaszewski
Quoted 13 lines
pon., 9 gru 2019 o 16:22 Stefano Babic <[email protected]> napisał(a):
Quoted 12 lines · Adrian Bunk
Quoted 9 lines · Stefano Babic
Quoted 4 lines
...
Don't you have any depends from zlib / bzip ? cmake tests it, if you do not add it, build will be fine but without support.
...Is it also working for you?
https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
https://github.com/librsync/librsync/issues/8Quoted 6 lines
Quoted 3 lines
Oh, good catch, I was not aware of it. I guess not, because I saw the dependencies when I wrote the recipe, but I *never* set
ENABLE_COMPRESSION..Is this really something that needs to be provided by rdiff? We can just pipe the output to a compressor of your choice.
Yes, I realized that it is not required by librsync - I already compress the output of rdiff to generate the delta, no need to integrate it. Sorry for noise.
Quoted 6 lines
Quoted 4 lines
What about to put the binary "rdiff" into a separate "bin" package ? I have rescue system where footprint is an issue, and rdiff is not required on target.
But this is what I did in my patch.
Sorry, you're right, you have already done it !
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================