Skip to contentSkip to conversation

pinctrl: samsung: Enable compile test for build coverage

PATCH Applied Krzysztof Kozlowski 2 participants 5 messages Dec 9, 2019 – Dec 13, 2019

Subsystems (4)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/2 pinctrl: samsung: Enable compile test for build coverage

The Samsung pinctrl drivers require only GPIOLIB and OF for building. The should be buildable on all architectures so enable COMPILE_TEST.

---
 drivers/pinctrl/samsung/Kconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/pinctrl/samsung/Kconfig +5 -3
index 425fadd6c346..cbf1ce48fddb 100644
@@ -9,7 +9,8 @@ config PINCTRL_SAMSUNG
 
 config PINCTRL_EXYNOS
 	bool "Pinctrl driver data for Samsung EXYNOS SoCs"
-	depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210)
+	depends on OF && GPIOLIB
+	depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST
 	select PINCTRL_SAMSUNG
 	select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210)
 	select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS
@@ -24,10 +25,11 @@ config PINCTRL_EXYNOS_ARM64
 
 config PINCTRL_S3C24XX
 	bool "Samsung S3C24XX SoC pinctrl driver"
-	depends on ARCH_S3C24XX && OF
+	depends on OF
+	depends on ARCH_S3C24XX || COMPILE_TEST
 	select PINCTRL_SAMSUNG
 
 config PINCTRL_S3C64XX
 	bool "Samsung S3C64XX SoC pinctrl driver"
-	depends on ARCH_S3C64XX
+	depends on ARCH_S3C64XX || COMPILE_TEST
 	select PINCTRL_SAMSUNG
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH 2/2 pinctrl: samsung: Clarify the option titles/names

The config options toggle Samsung Exynos SoCs pinctrl drivers, not the driver data. Clarify this in the option title/name and also make it consistent with other Samsung entries. No functional change.

---
 drivers/pinctrl/samsung/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/samsung/Kconfig +3 -3
index cbf1ce48fddb..779c0e9eca3f 100644
@@ -8,7 +8,7 @@ config PINCTRL_SAMSUNG
 	select PINCONF
 
 config PINCTRL_EXYNOS
-	bool "Pinctrl driver data for Samsung EXYNOS SoCs"
+	bool "Pinctrl common driver part for Samsung Exynos SoCs"
 	depends on OF && GPIOLIB
 	depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST
 	select PINCTRL_SAMSUNG
@@ -16,11 +16,11 @@ config PINCTRL_EXYNOS
 	select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS
 
 config PINCTRL_EXYNOS_ARM
-	bool "ARMv7-specific pinctrl driver data for Exynos" if COMPILE_TEST
+	bool "ARMv7-specific pinctrl driver for Samsung Exynos SoCs" if COMPILE_TEST
 	depends on PINCTRL_EXYNOS
 
 config PINCTRL_EXYNOS_ARM64
-	bool "ARMv8-specific pinctrl driver data for Exynos" if COMPILE_TEST
+	bool "ARMv8-specific pinctrl driver for Samsung Exynos SoCs" if COMPILE_TEST
 	depends on PINCTRL_EXYNOS
 
 config PINCTRL_S3C24XX
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 2/2] pinctrl: samsung: Clarify the option titles/names

Quoted 5 lines · Krzysztof Kozlowski

The config options toggle Samsung Exynos SoCs pinctrl drivers, not the driver data. Clarify this in the option title/name and also make it consistent with other Samsung entries. No functional change.

Like the other Samsung patch this doesn't apply to my tree devel branch which is close to v5.5-rc1.

Yours,
Linus Walleij

author maintainer Applied
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

The Samsung pinctrl drivers require only GPIOLIB and OF for building. The should be buildable on all architectures so enable COMPILE_TEST.

---
 drivers/pinctrl/samsung/Kconfig | 8 +++++---

Applied both to my tree. I'll send them to you Linus later in pull request (unless 0-day catches some build failures).

Best regards,
Krzysztof

#4 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

The Samsung pinctrl drivers require only GPIOLIB and OF for building. The should be buildable on all architectures so enable COMPILE_TEST.

---
 drivers/pinctrl/samsung/Kconfig | 8 +++++---

Applied both to my tree. I'll send them to you Linus later in pull request (unless 0-day catches some build failures).

Ah I see OK that's fine, forget my comments about not being able to apply patches then, I'll just wait for the pull request :)

Yours,
Linus Walleij