rapidio: Make it dependent to DMADEVICES
PATCH 1/1 rapidio: Make it dependent to DMADEVICES
DMADEVICES option depends on HAS_DMA, and this dependency is ignored when DMADEVICES is being selected.
Replace 'select' by 'depends on' in Kconfig for RAPIDIO_DMA_ENGINE.
--- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rapidio/Kconfig +1 -1
@@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO data
Signature · 1 line
2.20.1
Quoted 4 lines · Andy Shevchenko
DMADEVICES option depends on
HAS_DMA, and this dependency is ignored when DMADEVICES is being selected.Replace 'select' by 'depends on' in
KconfigforRAPIDIO_DMA_ENGINE.
Anybody to comment on this?
Quoted 24 lines
Fixes e42d98ebe7d7 ("rapidio: add DMA engine support for RIO data transfers")Cc Alexandre Bounine <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rapidio/Kconfig +1
-1@@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO dataSignature · 1 line
2.20.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
DMADEVICES option depends on
HAS_DMA, and this dependency is ignored when DMADEVICES is being selected.Replace 'select' by 'depends on' in
KconfigforRAPIDIO_DMA_ENGINE.
Yeah, I'm wondering why we got this into kernel much later (as d2b861002450 ("rapidio: Replace 'select' DMAENGINES 'with depends on'") in linux next and no one commented on this...
Quoted 23 lines
Fixes e42d98ebe7d7 ("rapidio: add DMA engine support for RIO data transfers")Cc Alexandre Bounine <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rapidio/Kconfig +1
-1@@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO dataSignature · 1 line
2.20.1
Signature · 2 lines
With Best Regards, Andy Shevchenko