Skip to contentSkip to conversation

generic/590: add _require_xfs_io_command "falloc"

PATCH In review Luis Henriques 2 participants 2 messages Dec 9, 2019 – Dec 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/590: add _require_xfs_io_command "falloc"

Without this check the test will fail with message:

fallocate: Operation not supported

Instead, with this _require_xfs_io_command, the test will be skipped instead if falloc isn't supported.

---
 tests/generic/590 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/590 +1 -0
index 80a665c6b001..2670fe99d21f 100755
@@ -34,6 +34,7 @@ rm -f $seqres.full
 _supported_fs generic
 _supported_os Linux
 _require_scratch_nocheck
+_require_xfs_io_command "falloc"
 
 maxextlen=$((0x1fffff))
 bs=4096
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Luis Henriques

Without this check the test will fail with message:

fallocate: Operation not supported

Instead, with this _require_xfs_io_command, the test will be skipped instead if falloc isn't supported.

Thanks, I missed this.

Quoted 17 lines
---
 tests/generic/590 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/590 +1 -0
index 80a665c6b001..2670fe99d21f 100755
@@ -34,6 +34,7 @@ rm -f $seqres.full
 _supported_fs generic
 _supported_os Linux
 _require_scratch_nocheck
+_require_xfs_io_command "falloc"
 
 maxextlen=$((0x1fffff))
 bs=4096