Skip to contentSkip to conversation

objtool: silence build output from sync-check.sh

PATCH In review Olof Johansson 2 participants 3 messages Dec 7, 2019 – Dec 16, 2019 objtool

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 objtool: silence build output from sync-check.sh

The sync-check.sh script prints out the path due to a "cd -" at the end of the script, even on silent builds. This isn't needed, since the script is never sourced (so it won't change the working directory of the surrounding build anyway).

Just remove the cd to make the build silent.

Fixes 2ffd84ae973b ("objtool: Update sync-check.sh from perf's check-headers.sh")
---
 tools/objtool/sync-check.sh | 2 --
 1 file changed, 2 deletions(-)
tools/objtool/sync-check.sh +0 -2
index 9bd04bbed01e..2a1261bfbb62 100755
@@ -48,5 +48,3 @@ check arch/x86/include/asm/inat.h     '-I "^#include [\"<]\(asm/\)*inat_types.h[
 check arch/x86/include/asm/insn.h     '-I "^#include [\"<]\(asm/\)*inat.h[\">]"'
 check arch/x86/lib/inat.c             '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"'
 check arch/x86/lib/insn.c             '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"'
-
-cd -
Signature · 1 line
2.22.GIT
Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · Olof Johansson

The sync-check.sh script prints out the path due to a "cd -" at the end of the script, even on silent builds. This isn't needed, since the script is never sourced (so it won't change the working directory of the surrounding build anyway).

Just remove the cd to make the build silent.

Fixes 2ffd84ae973b ("objtool: Update sync-check.sh from perf's check-headers.sh")
---
 tools/objtool/sync-check.sh | 2 --
 1 file changed, 2 deletions(-)
tools/objtool/sync-check.sh +0 -0
index 9bd04bbed01e..2a1261bfbb62 100755

tools/objtool/sync-check.sh check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[ · line 52

Quoted 5 lines
tools/objtool/sync-check.sh +0 -2
@@ -48,5 +48,3 @@ check arch/x86/include/asm/inat.h     '-I "^#include [\"<]\(asm/\)*inat_types.h[
 check arch/x86/include/asm/insn.h     '-I "^#include [\"<]\(asm/\)*inat.h[\">]"'
 check arch/x86/lib/inat.c             '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"'
 check arch/x86/lib/insn.c             '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"'
-
-cd -

If you want to send it through -tip, please resend to [email protected].

Signature · 1 line
Josh
#2 lore raw

PATCH 1/1 objtool: silence build output

The sync-check.sh script prints out the path due to a "cd -" at the end of the script, even on silent builds. This isn't even needed, since the script is executed in our build instead of sourced (so it won't change the working directory of the surrounding build anyway).

Just remove the cd to make the build silent.

Fixes 2ffd84ae973b ("objtool: Update sync-check.sh from perf's check-headers.sh")
---
 tools/objtool/sync-check.sh | 2 --
 1 file changed, 2 deletions(-)
tools/objtool/sync-check.sh +0 -2
index 9bd04bbed01e..2a1261bfbb62 100755
@@ -48,5 +48,3 @@ check arch/x86/include/asm/inat.h     '-I "^#include [\"<]\(asm/\)*inat_types.h[
 check arch/x86/include/asm/insn.h     '-I "^#include [\"<]\(asm/\)*inat.h[\">]"'
 check arch/x86/lib/inat.c             '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"'
 check arch/x86/lib/insn.c             '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"'
-
-cd -
Signature · 1 line
2.22.GIT