x86/platform/goldfish: add a check for platform_device_register_simple
Subsystems (2)
PATCH v2 1/1 x86/platform/goldfish: add a check for platform_device_register_simple
goldfish_init() misses a check for platform_device_register_simple(). Add a check to fix it.
Fixes ddd70cf93d78 ("goldfish: platform device for x86")
Signed-off-by Chuhong Yuan <[email protected]>
---
Changes in v2:
- Use PLATFORM_DEVID_NONE instead of -1.
- Use PTR_ERR_OR_ZERO() to simplify the code.
arch/x86/platform/goldfish/goldfish.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
arch/x86/platform/goldfish/goldfish.c +6 -3
@@ -44,11 +44,14 @@ __setup("goldfish", goldfish_setup);static int __init goldfish_init (void ) { +struct platform_device *pdev; +if (!goldfish_enable)return -ENODEV ; -platform_device_register_simple ("goldfish_pdev_bus" ,-1 , - goldfish_pdev_bus_resources,2 ); -return 0 ; + pdev =platform_device_register_simple ("goldfish_pdev_bus" , +PLATFORM_DEVID_NONE , + goldfish_pdev_bus_resources,2 ); +return PTR_ERR_OR_ZERO (pdev); }device_initcall (goldfish_init);
Signature · 1 line
2.24.0