wandboard: Fix the DM_PMIC conversion
PATCH v3 1/2 wandboard: Fix the DM_PMIC conversion
Commit ec837c82d709 ("imx6: wandboard: convert to DM_PMIC") caused the following pmic_get() error:
CPU: Freescale i.MX6QP rev1.0 at 792 MHz Reset cause: POR DRAM: 2 GiB PMIC: pmic_get() ret -19
...
and since the PMIC presence is used to determine the board D1 revision, the following error is seen when booting a board rev D1:
WARNING: Could not determine dtb to use
and the kernel does not boot at all.
Fix the regression by passing "pfuze100 at 8" as the correct parameter to the pmic_get() function in the DM case.
---
Changes since v2:
- None
board/wandboard/wandboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/wandboard/wandboard.c +1 -1
@@ -363,7 +363,7 @@ int power_init_board(void)puts ("PMIC: " ); - ret =pmic_get ("pfuze100" , &dev); + ret =pmic_get ("pfuze100 at 8" , &dev);if (ret <0 ) {printf ("pmic_get() ret %d\n" , ret);return 0 ;
Signature · 1 line
2.17.1
PATCH v3 2/2 wandboard: Remove repeated PMIC string
After the conversion to DM_PMIC the following output is seen:
PMIC: PMIC: PFUZE100 ID=0x10
Remove the unnecessary PMIC string from the board file to avoid the repetead string.
---
Changes since v2:
- None
board/wandboard/wandboard.c | 2 -- 1 file changed, 2 deletions(-)
board/wandboard/wandboard.c +0 -2
@@ -361,8 +361,6 @@ int power_init_board(void)struct udevice *dev;int reg, ret; -puts ("PMIC: " ); - ret =pmic_get ("pfuze100 at 8" , &dev);if (ret <0 ) {printf ("pmic_get() ret %d\n" , ret);
Signature · 1 line
2.17.1
PATCH v3 2/2 wandboard: Remove repeated PMIC string
Quoted 5 lines
After the conversion to
DM_PMICthe following output is seen:
PMIC: PMIC: PFUZE100 ID=0x10
Remove the unnecessary PMIC string from the board file to avoid the repetead string.Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v3 1/2 wandboard: Fix the DM_PMIC conversion
In reply to Fabio EstevamQuoted 11 lines
Commit
ec837c82d709("imx6: wandboard: convert toDM_PMIC") caused the followingpmic_get()error:CPU: Freescale i.MX6QP rev1.0 at 792 MHz Reset cause: POR DRAM: 2 GiB PMIC: pmic_get() ret -19...
and since the PMIC presence is used to determine the board D1 revision, the following error is seen when booting a board rev D1:
Quoted 6 lines
WARNING: Could not determine dtb to use
and the kernel does not boot at all.
Fix the regression by passing "pfuze100 at 8" as the correct parameter to thepmic_get()function in the DM case.Fixes ec837c82d709 ("imx6: wandboard: convert to DM_PMIC")Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================