fsck.f2fs: do not access nat etnries in ckpt before initialization
PATCH 1/1 fsck.f2fs: do not access nat etnries in ckpt before initialization
ckpt->entries is initialized by fsck_init(), but we tried to access it during f2fs_do_mount().
The call sequence is:
- f2fs_do_mount
- record_fsync_data
- traverse_dnodes
- do_record_fsync_data
- ADDRS_PER_PAGE
- get_node_info
- node_info_from_raw_nat(fsck->entries[nid])
- do_fsck
- fsck_init
- build_nat_area_bitmap
- fsck->entries = calloc(fsck->nr_nat_entries);
--- fsck/mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fsck/mount.c +1 -1
@@ -2139,7 +2139,7 @@ void get_node_info(struct f2fs_sb_info *sbi, nid_t nid, struct node_info *ni)struct f2fs_nat_entry raw_nat; ni->nid = nid; -if (c.func ==FSCK ) { +if (c.func ==FSCK &&F2FS_FSCK (sbi)->nr_nat_entries) {node_info_from_raw_nat (ni, &(F2FS_FSCK (sbi)->entries[nid]));if (ni->blk_addr)return ;
Signature · 8 lines
2.19.0.605.g01d371f741-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 16 lines · Jaegeuk Kim
ckpt->entriesis initialized byfsck_init(), but we tried to access it duringf2fs_do_mount().The call sequence is:
-f2fs_do_mount
-record_fsync_data
-traverse_dnodes
-do_record_fsync_data
-ADDRS_PER_PAGE
-get_node_info
-node_info_from_raw_nat(fsck->entries[nid])
-do_fsck
-fsck_init
-build_nat_area_bitmap
-fsck->entries=calloc(fsck->nr_nat_entries);
Quoted 1 line
Signed-off-by Jaegeuk Kim <[email protected]>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 17 lines · Chao Yu
Quoted 16 lines · Jaegeuk Kim
ckpt->entriesis initialized byfsck_init(), but we tried to access it duringf2fs_do_mount().The call sequence is:
-f2fs_do_mount
-record_fsync_data
-traverse_dnodes
-do_record_fsync_data
-ADDRS_PER_PAGE
-get_node_info
-node_info_from_raw_nat(fsck->entries[nid])
-do_fsck
-fsck_init
-build_nat_area_bitmap
-fsck->entries=calloc(fsck->nr_nat_entries);
Quoted 3 lines
Quoted 1 line
Signed-off-by Jaegeuk Kim <[email protected]>Reviewed-by Chao Yu <[email protected]>
Sorry, merged in master before.
Quoted 2 lines
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel