Skip to contentSkip to conversation

Regression in squashfs mount option handling in v5.4

DISCUSSION Jeremi Piotrowski 3 participants 4 messages Nov 30, 2019 – Dec 10, 2019 VFS

lore
Share & tools
lore
#0 lore raw

Hi,

I'm working on an embedded project which uses 'rauc' as an updater. rauc mounts a squashfs image using

mount -t squashfs -o ro,loop,sizelimit=xxx squashfs.img /mnt

On my system mount is busybox, and busybox does not know the sizelimit parameter, so it simply passes it on to the mount syscall. The syscall arguments end up being:

mount("/dev/loop0", "dir", "squashfs", MS_RDONLY|MS_SILENT, "sizelimit=xxx")

Until kernel 5.4 this worked, since 5.4 this returns EINVAL and dmesg contains the line "squashfs: Unknown parameter 'sizelimit'". I believe this has to do with the conversion of squashfs to the new mount api.

This is an unfortunate regression, and it does not seem like this can be simply reverted. What is the suggested course of action?

Please cc me on replies, I'm not subscribed to the list.

Thanks,
Jeremi

#1 lore raw

[adding Cc-s]

Quoted 25 lines · Jeremi Piotrowski

Hi,

I'm working on an embedded project which uses 'rauc' as an updater. rauc mounts a squashfs image using

mount -t squashfs -o ro,loop,sizelimit=xxx squashfs.img /mnt

On my system mount is busybox, and busybox does not know the sizelimit parameter, so it simply passes it on to the mount syscall. The syscall arguments end up being:

mount("/dev/loop0", "dir", "squashfs", MS_RDONLY|MS_SILENT, "sizelimit=xxx")

Until kernel 5.4 this worked, since 5.4 this returns EINVAL and dmesg contains the line "squashfs: Unknown parameter 'sizelimit'". I believe this has to do with the conversion of squashfs to the new mount api.

This is an unfortunate regression, and it does not seem like this can be simply reverted. What is the suggested course of action?

Please cc me on replies, I'm not subscribed to the list.

Thanks,
Jeremi

Signature · 2 lines
~Randy
Reported-by: Randy Dunlap <[email protected]>
#2 lore raw
Quoted 20 lines · Randy Dunlap

[adding Cc-s]

Quoted 17 lines · Jeremi Piotrowski

Hi,

I'm working on an embedded project which uses 'rauc' as an updater. rauc mounts a squashfs image using

mount -t squashfs -o ro,loop,sizelimit=xxx squashfs.img /mnt

On my system mount is busybox, and busybox does not know the sizelimit parameter, so it simply passes it on to the mount syscall. The syscall arguments end up being:

mount("/dev/loop0", "dir", "squashfs", MS_RDONLY|MS_SILENT, "sizelimit=xxx")

Until kernel 5.4 this worked, since 5.4 this returns EINVAL and dmesg contains the line "squashfs: Unknown parameter 'sizelimit'". I believe this has to do with the conversion of squashfs to the new mount api.

Quoted 13 lines
Quoted 8 lines

This is an unfortunate regression, and it does not seem like this can be simply reverted. What is the suggested course of action?

Please cc me on replies, I'm not subscribed to the list.

Thanks,
Jeremi

Signature · 2 lines
~Randy
Reported-by: Randy Dunlap <[email protected]>

Ping. This is preventing me from updating the kernel on my systems.

#3 lore raw
Quoted 31 lines · Jeremi Piotrowski
Quoted 30 lines · Randy Dunlap

[adding Cc-s]

Quoted 25 lines · Jeremi Piotrowski

Hi,

I'm working on an embedded project which uses 'rauc' as an updater. rauc mounts a squashfs image using

mount -t squashfs -o ro,loop,sizelimit=xxx squashfs.img /mnt

On my system mount is busybox, and busybox does not know the sizelimit parameter, so it simply passes it on to the mount syscall. The syscall arguments end up being:

   mount("/dev/loop0", "dir", "squashfs", MS_RDONLY|MS_SILENT, "sizelimit=xxx")

Until kernel 5.4 this worked, since 5.4 this returns EINVAL and dmesg contains the line "squashfs: Unknown parameter 'sizelimit'". I believe this has to do with the conversion of squashfs to the new mount api.

This is an unfortunate regression, and it does not seem like this can be simply reverted. What is the suggested course of action?

Please cc me on replies, I'm not subscribed to the list.

Thanks,
Jeremi

Quoted 6 lines
Quoted 3 lines
Signature · 2 lines
~Randy
Reported-by: Randy Dunlap <[email protected]>

Ping. This is preventing me from updating the kernel on my systems.

Fedora is hitting a similar issue https://bugzilla.redhat.com/show_bug.cgi?id=1781863

Dec 10 10:04:06 kernel: squashfs: version 4.0 (2009/01/31) Phillip Lougher
Dec 10 10:04:06 kernel: squashfs: Unknown parameter 'errors'

I don't think squashfs ever actually supported the errors parameter but it was just silently ignored. It turns out you could can pass whatever nonsense you want for parameters so I don't think we can reject parameters in the generic case

fs/fs_context.c +1 -2
index 138b5b4d621d..7ec20b1f8a53 100644
@@ -160,8 +160,7 @@ int vfs_parse_fs_param(struct fs_context *fc, struct fs_parameter *param)
 		return 0;
 	}
 
-	return invalf(fc, "%s: Unknown parameter '%s'",
-		      fc->fs_type->name, param->key);
+	return 0;
 }
 EXPORT_SYMBOL(vfs_parse_fs_param);