Skip to contentSkip to conversation

staging: hp100: add back CONFIG_NET dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 10, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: hp100: add back CONFIG_NET dependency

The move to staging lost an important dependency:

ERROR: "eth_validate_addr" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "eth_mac_addr" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "alloc_etherdev_mqs" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "register_netdev" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__skb_pad" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "consume_skb" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "dev_trans_start" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__dev_kfree_skb_any" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "netif_rx" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "eth_type_trans" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "skb_trim" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "skb_put" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__netdev_alloc_skb" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "free_netdev" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "unregister_netdev" [drivers/staging/hp/hp100.ko] undefined!

Add it back explicitly.

Fixes 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging")
---
 drivers/staging/hp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/hp/Kconfig +1 -0
index fb395cfe6b92..9566d4ab5ce5 100644
@@ -6,6 +6,7 @@
 config NET_VENDOR_HP
 	bool "HP devices"
 	default y
+	depends on NET
 	depends on ISA || EISA || PCI
 	---help---
 	  If you have a network (Ethernet) card belonging to this class, say Y.
Signature · 1 line
2.20.0
#1 lore raw
Quoted 31 lines · Arnd Bergmann

The move to staging lost an important dependency:

ERROR: "eth_validate_addr" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "eth_mac_addr" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "alloc_etherdev_mqs" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "register_netdev" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__skb_pad" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "consume_skb" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "dev_trans_start" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__dev_kfree_skb_any" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "netif_rx" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "eth_type_trans" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "skb_trim" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "skb_put" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__netdev_alloc_skb" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "free_netdev" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "unregister_netdev" [drivers/staging/hp/hp100.ko] undefined!

Add it back explicitly.

Fixes 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging")
---
 drivers/staging/hp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/hp/Kconfig +0 -0
index fb395cfe6b92..9566d4ab5ce5 100644

drivers/staging/hp/Kconfig line 12

Quoted 7 lines
drivers/staging/hp/Kconfig +1 -0
@@ -6,6 +6,7 @@
 config NET_VENDOR_HP
 	bool "HP devices"
 	default y
+	depends on NET
 	depends on ISA || EISA || PCI
 	---help---
 	  If you have a network (Ethernet) card belonging to this class, say Y.

Heh, I just queued up this same patch a few hours ago :)

greg k-h