drm/edid: Increase size of VDB and CMDB bitmaps to 256 bits
Subsystems (2)
PATCH 1/1 drm/edid: Increase size of VDB and CMDB bitmaps to 256 bits
CEA-861-G adds modes up to 219, so increase the size of the maps in preparation for adding the new modes to drm_edid.c.
Signed-off-by Thomas Anderson <[email protected]>
--- include/drm/drm_connector.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
include/drm/drm_connector.h +8 -8
@@ -188,19 +188,19 @@ struct drm_hdmi_info {/** * @y420_vdb_modes: bitmap of modes which can support ycbcr420 -* output only (not normal RGB/YCBCR444/422 outputs). There are total -* 107 VICs defined by CEA-861-F spec, so the size is 128 bits to map -* upto 128 VICs; +* output only (not normal RGB/YCBCR444/422 outputs). The max VIC +* defined by the CEA-861-G spec is 219, so the size is 256 bits to map +* up to 256 VICs. */ -unsigned long y420_vdb_modes[BITS_TO_LONGS (128 )]; +unsigned long y420_vdb_modes[BITS_TO_LONGS (256 )];/** * @y420_cmdb_modes: bitmap of modes which can support ycbcr420 -* output also, along with normal HDMI outputs. There are total 107 -* VICs defined by CEA-861-F spec, so the size is 128 bits to map upto -* 128 VICs; +* output also, along with normal HDMI outputs. The max VIC defined by +* the CEA-861-G spec is 219, so the size is 256 bits to map up to 256 +* VICs. */ -unsigned long y420_cmdb_modes[BITS_TO_LONGS (128 )]; +unsigned long y420_cmdb_modes[BITS_TO_LONGS (256 )];/** @y420_cmdb_map: bitmap of SVD index, to extraxt vcb modes */ u64 y420_cmdb_map;
Signature · 1 line
2.24.0.525.g8f36a354ae-goog
Quoted 4 lines · Thomas Anderson
CEA-861-G adds modes up to 219, so increase the size of the maps in preparation for adding the new modes to
drm_edid.c.Signed-off-by Thomas Anderson <[email protected]>
Thanks. lgtm. Pushed to drm-misc-next.
PS. I do wonder a bit if we should consider a more economical way to track this stuff. Not really sure how many bits we can realistically expect to be set in these bitmasks...
Quoted 38 lines
--- include/drm/drm_connector.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)include/drm/drm_connector.h +8
-8@@ -188,19 +188,19 @@ struct drm_hdmi_info {/** * @y420_vdb_modes: bitmap of modes which can support ycbcr420 -* output only (not normal RGB/YCBCR444/422 outputs). There are total -* 107 VICs defined by CEA-861-F spec, so the size is 128 bits to map -* upto 128 VICs; +* output only (not normal RGB/YCBCR444/422 outputs). The max VIC +* defined by the CEA-861-G spec is 219, so the size is 256 bits to map +* up to 256 VICs. */ -unsigned long y420_vdb_modes[BITS_TO_LONGS (128 )]; +unsigned long y420_vdb_modes[BITS_TO_LONGS (256 )];/** * @y420_cmdb_modes: bitmap of modes which can support ycbcr420 -* output also, along with normal HDMI outputs. There are total 107 -* VICs defined by CEA-861-F spec, so the size is 128 bits to map upto -* 128 VICs; +* output also, along with normal HDMI outputs. The max VIC defined by +* the CEA-861-G spec is 219, so the size is 256 bits to map up to 256 +* VICs. */ -unsigned long y420_cmdb_modes[BITS_TO_LONGS (128 )]; +unsigned long y420_cmdb_modes[BITS_TO_LONGS (256 )];/** @y420_cmdb_map: bitmap of SVD index, to extraxt vcb modes */ u64 y420_cmdb_map;Signature · 1 line
2.24.0.525.g8f36a354ae-goog
Signature · 2 lines
Ville Syrjälä Intel