Skip to contentSkip to conversation

net/i40e: fix port close in FreeBSD

PATCH Applied Chenxu Di 2 participants 2 messages Dec 11, 2019 – Dec 18, 2019 Network drivers

lore
Share & tools
lore

Chenxu Di

author
#0 lore raw

PATCH 1/1 net/i40e: fix port close in FreeBSD

FreeBSD OS doesn't support igb_uio interrupt, so it will fail when unregister the interrupt callback in port close. We can fix the issue by passing -ENOENT when check the return value of unregister interrupt callback function.

Fixes ac89d46096d5 ("net/i40e: release port upon close")
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +1 -1
index 5999c964b..8b2500391 100644
@@ -2594,7 +2594,7 @@ i40e_dev_close(struct rte_eth_dev *dev)
 	do {
 		ret = rte_intr_callback_unregister(intr_handle,
 				i40e_dev_interrupt_handler, dev);
-		if (ret >= 0) {
+		if (ret >= 0 || ret == -ENOENT) {
 			break;
 		} else if (ret != -EAGAIN) {
 			PMD_INIT_LOG(ERR,
Signature · 1 line
2.17.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 29 lines · Chenxu Di

FreeBSD OS doesn't support igb_uio interrupt, so it will fail when unregister the interrupt callback in port close. We can fix the issue by passing -ENOENT when check the return value of unregister interrupt callback function.

Fixes ac89d46096d5 ("net/i40e: release port upon close")

---
drivers/net/i40e/i40e_ethdev.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +1 -1
index 5999c964b..8b2500391 100644
@@ -2594,7 +2594,7 @@ i40e_dev_close(struct rte_eth_dev *dev)
 	do {
 		ret = rte_intr_callback_unregister(intr_handle,
 				i40e_dev_interrupt_handler, dev);
-		if (ret >= 0) {
+		if (ret >= 0 || ret == -ENOENT) {
 			break;
 		} else if (ret != -EAGAIN) {
 			PMD_INIT_LOG(ERR,
Signature · 1 line
2.17.1

Applied to dpdk-next-net-intel, Thanks.