net: ethernet: ti: select PAGE_POOL for switchdev driver
Subsystems (3)
PATCH 1/2 net: ethernet: ti: select PAGE_POOL for switchdev driver
The new driver misses a dependency:
drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler':
cpsw_new.c:(.text+0x259c): undefined reference to __page_pool_put_page' cpsw_new.c:(.text+0x25d0): undefined reference to page_pool_alloc_pages' drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels':
cpsw_priv.c:(.text+0x22d8): undefined reference to page_pool_alloc_pages' cpsw_priv.c:(.text+0x2420): undefined reference to __page_pool_put_page' drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs':
cpsw_priv.c:(.text+0x2624): undefined reference to page_pool_create' drivers/net/ethernet/ti/cpsw_priv.o: In function cpsw_run_xdp':
cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page'
Other drivers use 'select' for PAGE_POOL, so do the same here.
--- drivers/net/ethernet/ti/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/ti/Kconfig +1 -0
@@ -63,6 +63,7 @@ config TI_CPSW_SWITCHDEV tristate "TI CPSW Switch Support with switchdev" depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST depends on NET_SWITCHDEV + select PAGE_POOL select TI_DAVINCI_MDIO select MFD_SYSCON select REGMAP
Signature · 1 line
2.20.0
PATCH 2/2 net: ethernet: ti: build cpsw-common for switchdev
Without the common part of the driver, the new file fails to link:
drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_probe':
cpsw_new.c:(.text+0x312c): undefined reference to `ti_cm_get_macid'
Use the same Makefile hack as before, and build cpsw-common.o for any driver that needs it.
--- drivers/net/ethernet/ti/Makefile | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/ti/Makefile +1 -0
@@ -5,6 +5,7 @@ obj-$(CONFIG_TI_CPSW) += cpsw-common.o obj-$(CONFIG_TI_DAVINCI_EMAC) += cpsw-common.o +obj-$(CONFIG_TI_CPSW_SWITCHDEV) += cpsw-common.o obj-$(CONFIG_TLAN) += tlan.o obj-$(CONFIG_CPMAC) += cpmac.o
Signature · 1 line
2.20.0
Re: [PATCH 2/2] net: ethernet: ti: build cpsw-common for switchdev
Quoted 20 lines · Arnd Bergmann
Without the common part of the driver, the new file fails to link:
drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_probe':
cpsw_new.c:(.text+0x312c): undefined reference to `ti_cm_get_macid'Use the same
Makefilehack as before, and build cpsw-common.o for any driver that needs it.Fixes ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/net/ethernet/ti/Makefile | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/ti/Makefile +0
-0
drivers/net/ethernet/ti/Makefile line 11
Quoted 7 lines
drivers/net/ethernet/ti/Makefile +1
-0@@ -5,6 +5,7 @@ obj-$(CONFIG_TI_CPSW) += cpsw-common.o obj-$(CONFIG_TI_DAVINCI_EMAC) += cpsw-common.o +obj-$(CONFIG_TI_CPSW_SWITCHDEV) += cpsw-common.o obj-$(CONFIG_TLAN) += tlan.o obj-$(CONFIG_CPMAC) += cpmac.o
Signature · 2 lines
Best regards, grygorii
Quoted 36 lines · Arnd Bergmann
The new driver misses a dependency:
drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler':
cpsw_new.c:(.text+0x259c): undefined reference to__page_pool_put_page' cpsw_new.c:(.text+0x25d0): undefined reference topage_pool_alloc_pages'drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels':
cpsw_priv.c:(.text+0x22d8): undefined reference topage_pool_alloc_pages' cpsw_priv.c:(.text+0x2420): undefined reference to__page_pool_put_page'drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs':
cpsw_priv.c:(.text+0x2624): undefined reference topage_pool_create' drivers/net/ethernet/ti/cpsw_priv.o: In functioncpsw_run_xdp':
cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page'Other drivers use 'select' for
PAGE_POOL, so do the same here.Fixes ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/net/ethernet/ti/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/ti/Kconfig +1
-0@@ -63,6 +63,7 @@ config TI_CPSW_SWITCHDEV tristate "TI CPSW Switch Support with switchdev" depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST depends on NET_SWITCHDEV + select PAGE_POOL select TI_DAVINCI_MDIO select MFD_SYSCON select REGMAPSignature · 1 line
2.20.0
Quoted 13 lines · On Wed, 11 Dec 2019 13:56:09 +0100 Arnd Bergmann <[email protected]> wrote:
The new driver misses a dependency:
drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler':
cpsw_new.c:(.text+0x259c): undefined reference to__page_pool_put_page' cpsw_new.c:(.text+0x25d0): undefined reference topage_pool_alloc_pages'drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels':
cpsw_priv.c:(.text+0x22d8): undefined reference topage_pool_alloc_pages' cpsw_priv.c:(.text+0x2420): undefined reference to__page_pool_put_page'drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs':
cpsw_priv.c:(.text+0x2624): undefined reference topage_pool_create' drivers/net/ethernet/ti/cpsw_priv.o: In functioncpsw_run_xdp':
cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page'
Quoted 4 lines
Other drivers use 'select' for
PAGE_POOL, so do the same here.Fixes ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")Signed-off-by Arnd Bergmann <[email protected]>
Thanks for fixing this.
Signature · 4 lines
Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
Quoted 27 lines · Arnd Bergmann
The new driver misses a dependency:
drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler':
cpsw_new.c:(.text+0x259c): undefined reference to__page_pool_put_page' cpsw_new.c:(.text+0x25d0): undefined reference topage_pool_alloc_pages'drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels':
cpsw_priv.c:(.text+0x22d8): undefined reference topage_pool_alloc_pages' cpsw_priv.c:(.text+0x2420): undefined reference to__page_pool_put_page'drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs':
cpsw_priv.c:(.text+0x2624): undefined reference topage_pool_create' drivers/net/ethernet/ti/cpsw_priv.o: In functioncpsw_run_xdp':
cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page'Other drivers use 'select' for
PAGE_POOL, so do the same here.Fixes ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/net/ethernet/ti/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/ti/Kconfig +0
-0
drivers/net/ethernet/ti/Kconfig config TI_CPSW_SWITCHDEV · line 69
Quoted 7 lines
drivers/net/ethernet/ti/Kconfig +1
-0@@ -63,6 +63,7 @@ config TI_CPSW_SWITCHDEV tristate "TI CPSW Switch Support with switchdev" depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST depends on NET_SWITCHDEV + select PAGE_POOL select TI_DAVINCI_MDIO select MFD_SYSCON select REGMAP
Thank you.
Signature · 2 lines
Best regards, grygorii
Jakub Kicinski
AppliedQuoted 1 line · Arnd Bergmann
The new driver misses a dependency:
Applied both, thank you!