Skip to contentSkip to conversation

mcstrans: start early and stop late

PATCH Superseded Dominick Grift 1 participant 1 message Dec 11, 2019 SELinux security module

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mcstrans: start early and stop late

It stopped too early, exposing a bug in sudo selinux_restore_tty():

SELINUX_ERR op=setxattr invalid_context="wheel.id:wheel.role:users.terminals.pty.pty_file:SystemLow"
avc: denied { mac_admin } for pid=859 comm="sudo" capability=33 scontext=wheel.id:wheel.role:sudo.wheel.subj:s0 tcontext=wheel.id:wheel.role:sudo.wheel.subj:s0 tclass=capability2 permissive=0

If we want to be able to reference human readable contexts in SELinuxContext= and nspawn -Z and -L then we need mcstrans ASAP

---
 mcstrans/src/mcstrans.service | 2 ++
 1 file changed, 2 insertions(+)
mcstrans/src/mcstrans.service +2 -0
index 09529432..08a41585 100644
@@ -2,6 +2,8 @@
 Description=Translates SELinux MCS/MLS labels to human readable form
 Documentation=man:mcstransd(8)
 ConditionSecurity=selinux
+DefaultDependencies=no
+Before=sysinit.target
 
 [Service]
 ExecStart=/sbin/mcstransd -f
Signature · 1 line
2.24.0