Skip to contentSkip to conversation

uml: add unspecified HAS_IOMEM dependencies

PATCH In review Brendan Higgins 10 participants 31 messages Dec 11, 2019 – Jan 31, 2020

Subsystems (14)
lore
Share & tools
lore
#0 lore raw

cover uml: add unspecified HAS_IOMEM dependencies

# TL;DR

This patchset adds a missing HAS_IOMEM dependency to several drivers in an attempt to get allyesconfig closer to working for ARCH=um.

# What am I trying to do?

This patchset is part of my attempt to get make ARCH=um allyesconfig to produce a config that will build *and* boot to init, so that I can use it as a mechanism to run tests[1].

This patchset is attempting to deal with

CONFIG_PINCTRL_EQUILIBRIUM=y
CONFIG_MTD_NAND_CADENCE=y
CONFIG_FSI_MASTER_ASPEED=y
CONFIG_CRYPTO_DEV_SAFEXCEL=y
CONFIG_XIL_AXIS_FIFO=y
CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y
CONFIG_XILINX_AXI_EMAC=y

which are selected by make ARCH=um allyesconfig, but prevent it from building.

# How far away are we from an allyesconfig UML kernel?

I have identified 33 Kconfigs that are selected by allyesconfig, but will either not build on UML, or prevent it from booting. They are:

CONFIG_STATIC_LINK=y
CONFIG_UML_NET_PCAP=y
CONFIG_NET_PTP_CLASSIFY=y
CONFIG_IP_VS=y
CONFIG_BRIDGE_EBT_BROUTE=y
CONFIG_BRIDGE_EBT_T_FILTER=y
CONFIG_BRIDGE_EBT_T_NAT=y
CONFIG_MTD_NAND_CADENCE=y
CONFIG_MTD_NAND_NANDSIM=y
CONFIG_BLK_DEV_NULL_BLK=y
CONFIG_BLK_DEV_RAM=y
CONFIG_SCSI_DEBUG=y
CONFIG_NET_VENDOR_XILINX=y
CONFIG_NULL_TTY=y
CONFIG_PTP_1588_CLOCK=y
CONFIG_PINCTRL_EQUILIBRIUM=y
CONFIG_DMABUF_SELFTESTS=y
CONFIG_COMEDI=y
CONFIG_XIL_AXIS_FIFO=y
CONFIG_EXFAT_FS=y
CONFIG_STM_DUMMY=y
CONFIG_FSI_MASTER_ASPEED=y
CONFIG_JFS_FS=y
CONFIG_UBIFS_FS=y
CONFIG_CRAMFS=y
CONFIG_CRYPTO_DEV_SAFEXCEL=y
CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y
CONFIG_KCOV=y
CONFIG_LKDTM=y
CONFIG_REED_SOLOMON_TEST=y
CONFIG_TEST_RHASHTABLE=y
CONFIG_TEST_MEMINIT=y
CONFIG_NETWORK_PHY_TIMESTAMPING=y

CONFIG_STATIC_LINK=y and CONFIG_UML_NET_PCAP=y already have fixes on their way.

I also have a patchset that just got accepted to fix CONFIG_EXFAT_FS=y[2].

So with this patchset and these other three fixes mentioned here, we will be about a third of the way there. There is only one more broken config that prevents UML from building, CONFIG_LKDTM=y. After this there will still be 22 broken configs which will prevent the UML allyesconfig kernel from reaching the end of init; nevertheless, this is a good milestone where, once reached, we can stop some of this bleeding by adding a build test.

# Why won't allyesconfig break again after this series of fixes?

As I mentioned above, I am using UML for testing the kernel, and I am currently working on getting my tests to run on KernelCI. As part of our testing procedure for KernelCI, we are planning on building a UML kernel using allyesconfig and running our tests on it. Thus, we will find out very quickly once someone breaks allyesconfig again once we get this all working.

Brendan Higgins (7):
pinctrl: equilibrium: add unspecified HAS_IOMEM dependency
mtd: rawnand: add unspecified HAS_IOMEM dependency
net: axienet: add unspecified HAS_IOMEM dependency
crypto: inside-secure: add unspecified HAS_IOMEM dependency
crypto: amlogic: add unspecified HAS_IOMEM dependency
staging: axis-fifo: add unspecified HAS_IOMEM dependency
fsi: aspeed: add unspecified HAS_IOMEM dependency

 drivers/crypto/Kconfig              | 2 +-
 drivers/crypto/amlogic/Kconfig      | 1 +
 drivers/fsi/Kconfig                 | 1 +
 drivers/mtd/nand/raw/Kconfig        | 2 +-
 drivers/net/ethernet/xilinx/Kconfig | 1 +
 drivers/pinctrl/Kconfig             | 1 +
 drivers/staging/axis-fifo/Kconfig   | 2 +-
 7 files changed, 7 insertions(+), 3 deletions(-)

[1] https://bugzilla.kernel.org/show_bug.cgi?id=205223
[2] https://patchwork.kernel.org/patch/11273771/

Signature · 1 line
2.24.0.525.g8f36a354ae-goog
#1 lore raw

PATCH 1/7 pinctrl: equilibrium: add unspecified HAS_IOMEM dependency

Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.

---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
index 3bfbf2ff6e2bd..2c0b30477f7d0 100644
@@ -422,6 +422,7 @@ config PINCTRL_TB10X
 
 config PINCTRL_EQUILIBRIUM
 	tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
+	depends on HAS_IOMEM
 	select PINMUX
 	select PINCONF
 	select GPIOLIB
Signature · 1 line
2.24.0.525.g8f36a354ae-goog
#2 lore raw

Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency

Quoted 4 lines · Brendan Higgins

Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

Quoted 8 lines

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.

We recently fixed a compile error by adding depends on OF
and I think OF implies HAS_IOMEM so this should be fixed now.

Can you confirm?

Yours,
Linus Walleij

#3 lore raw

Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency

Quoted 17 lines · Linus Walleij
Quoted 4 lines · Brendan Higgins

Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

Quoted 8 lines

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.

Quoted 6 lines

We recently fixed a compile error by adding depends on OF
and I think OF implies HAS_IOMEM so this should be fixed now.

Can you confirm?

I'm fairly sure it does not, so both patches are needed.

Arnd

#4 lore raw

Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins
Quoted 4 lines · Brendan Higgins

Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

Quoted 8 lines

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.

Patch applied but I augmented it with the recently added OF dependency so it now says:
depends on OF && HAS_IOMEM

Yours,
Linus Walleij

#5 lore raw

Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency

Sorry for not getting to this before I went on vacation.

Quoted 12 lines · Linus Walleij
Quoted 8 lines · Brendan Higgins

Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'

Quoted 8 lines
Quoted 4 lines

Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.

Patch applied but I augmented it with the recently added OF dependency so it now says:
depends on OF && HAS_IOMEM

Probably too late now to be helpful, but I can confirm that OF does NOT depend on HAS_IOMEM, so this patch was still needed.

Thanks regardless!

#6 lore raw

PATCH 2/7 mtd: rawnand: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

---
 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/raw/Kconfig +1 -1
index 74fb91adeb469..a80a46bb5b8bc 100644
@@ -452,7 +452,7 @@ config MTD_NAND_PLATFORM
 
 config MTD_NAND_CADENCE
 	tristate "Support Cadence NAND (HPNFC) controller"
-	depends on OF || COMPILE_TEST
+	depends on (OF || COMPILE_TEST) && HAS_IOMEM
 	help
 	  Enable the driver for NAND flash on platforms using a Cadence NAND
 	  controller.
Signature · 1 line
2.24.0.525.g8f36a354ae-goog
maintainer Acked-by on v1 2/7
#7 lore raw

Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Wed, 11 Dec 2019 11:27:37 -0800:

Quoted 8 lines

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Quoted 5 lines

Fix the build error by adding the unspecified dependency.

---

Sorry for the delay.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#8 lore raw

Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency

Quoted 16 lines · Miquel Raynal

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Wed, 11 Dec 2019 11:27:37 -0800:

Quoted 10 lines

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Quoted 7 lines
Quoted 3 lines

---

Sorry for the delay.

It looks like my change has not been applied to nand/next; is this the branch it should be applied to? I have also verified that this patch isn't in linux-next as of Jan 24th.

Is mtd/linux the correct tree for this? Or do I need to reach out to someone else?

Cheers

maintainer
#9 lore raw

Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Fri, 24 Jan 2020 18:12:12 -0800:

Quoted 23 lines · Miquel Raynal
Quoted 22 lines

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Wed, 11 Dec 2019 11:27:37 -0800:

Quoted 8 lines

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Quoted 5 lines

Fix the build error by adding the unspecified dependency.

---

Sorry for the delay.

Quoted 8 lines
Quoted 1 line

It looks like my change has not been applied to nand/next; is this the branch it should be applied to? I have also verified that this patch isn't in linux-next as of Jan 24th.

Is mtd/linux the correct tree for this? Or do I need to reach out to someone else?

When I sent my Acked-by I supposed someone else would pick the patch, but there is actually no dependency with all the other patches so I don't know why I did it... Sorry about that. I'll take it anyway in my PR for 5.6.

Thanks,
Miquèl

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um

#10 lore raw

Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency

Quoted 35 lines · Miquel Raynal

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Fri, 24 Jan 2020 18:12:12 -0800:

Quoted 29 lines · Miquel Raynal
Quoted 16 lines

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Wed, 11 Dec 2019 11:27:37 -0800:

Quoted 10 lines

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Quoted 7 lines
Quoted 3 lines

---

Sorry for the delay.

It looks like my change has not been applied to nand/next; is this the branch it should be applied to? I have also verified that this patch isn't in linux-next as of Jan 24th.

Quoted 7 lines
Quoted 2 lines

Is mtd/linux the correct tree for this? Or do I need to reach out to someone else?

When I sent my Acked-by I supposed someone else would pick the patch, but there is actually no dependency with all the other patches so I don't know why I did it... Sorry about that. I'll take it anyway in my PR for 5.6.

No worries, thanks!

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

maintainer
#11 lore raw

Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency

In reply to Miquel Raynal

Hello,

Miquel Raynal <[email protected]> wrote on Sat, 25 Jan 2020 16:28:03 +0100:

Quoted 34 lines

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Fri, 24 Jan 2020 18:12:12 -0800:

Quoted 29 lines · Miquel Raynal
Quoted 16 lines

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Wed, 11 Dec 2019 11:27:37 -0800:

Quoted 10 lines

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Quoted 7 lines
Quoted 3 lines

---

Sorry for the delay.

It looks like my change has not been applied to nand/next; is this the branch it should be applied to? I have also verified that this patch isn't in linux-next as of Jan 24th.

Quoted 7 lines
Quoted 2 lines

Is mtd/linux the correct tree for this? Or do I need to reach out to someone else?

When I sent my Acked-by I supposed someone else would pick the patch, but there is actually no dependency with all the other patches so I don't know why I did it... Sorry about that. I'll take it anyway in my PR for 5.6.

It is applied on top of mtd/next since a few days, it will be part of the 5.6 PR.

Sorry for the delay.

Thanks,
Miquèl

#12 lore raw

Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency

Quoted 48 lines · Miquel Raynal

Hello,

Miquel Raynal <[email protected]> wrote on Sat, 25 Jan 2020 16:28:03 +0100:

Quoted 34 lines

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Fri, 24 Jan 2020 18:12:12 -0800:

Quoted 29 lines · Miquel Raynal
Quoted 16 lines

Hi Brendan,

Brendan Higgins <[email protected]> wrote on Wed, 11 Dec 2019 11:27:37 -0800:

Quoted 10 lines

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Quoted 7 lines
Quoted 3 lines

---

Sorry for the delay.

It looks like my change has not been applied to nand/next; is this the branch it should be applied to? I have also verified that this patch isn't in linux-next as of Jan 24th.

Quoted 7 lines
Quoted 2 lines

Is mtd/linux the correct tree for this? Or do I need to reach out to someone else?

When I sent my Acked-by I supposed someone else would pick the patch, but there is actually no dependency with all the other patches so I don't know why I did it... Sorry about that. I'll take it anyway in my PR for 5.6.

Quoted 4 lines

It is applied on top of mtd/next since a few days, it will be part of the 5.6 PR.

Sorry for the delay.

No worries.

Thanks!

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um

#13 lore raw

PATCH 3/7 net: axienet: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins

Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

---
 drivers/net/ethernet/xilinx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/xilinx/Kconfig +1 -0
index 6304ebd8b5c69..b1a285e693756 100644
@@ -25,6 +25,7 @@ config XILINX_EMACLITE
 
 config XILINX_AXI_EMAC
 	tristate "Xilinx 10/100/1000 AXI Ethernet support"
+	depends on HAS_IOMEM
 	select PHYLINK
 	---help---
 	  This driver supports the 10/100/1000 Ethernet from Xilinx for the
Signature · 1 line
2.24.0.525.g8f36a354ae-goog
Reviewed-by on v1 3/7
#14 lore raw

RE: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM dependency

Quoted 27 lines

-----Original Message-----
From: Brendan Higgins <[email protected]>
Sent: Thursday, December 12, 2019 12:58 AM
To: [email protected]; [email protected]; [email protected]; David S. Miller <[email protected]>; Michal Simek <[email protected]>; Radhey Shyam Pandey <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Brendan Higgins <[email protected]>; [email protected]; [email protected]
Subject: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM dependency

Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:

ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined reference to `devm_ioremap_resource'

Quoted 4 lines

Fix the build error by adding the unspecified dependency.

Thanks!

Quoted 18 lines
---
 drivers/net/ethernet/xilinx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/xilinx/Kconfig +1 -1
index 6304ebd8b5c69..b1a285e693756 100644
@@ -25,6 +25,7 @@ config XILINX_EMACLITE
 
 config XILINX_AXI_EMAC
 	tristate "Xilinx 10/100/1000 AXI Ethernet support"
+	depends on HAS_IOMEM
 	select PHYLINK
 	---help---
 	  This driver supports the 10/100/1000 Ethernet from Xilinx for the
--
Quoted 1 line

2.24.0.525.g8f36a354ae-goog

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#15 lore raw

PATCH 4/7 crypto: inside-secure: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins

Currently CONFIG_CRYPTO_DEV_SAFEXCEL=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/crypto/inside-secure/safexcel.o: in function `safexcel_probe':
drivers/crypto/inside-secure/safexcel.c:1692: undefined reference to `devm_platform_ioremap_resource'

Fix the build error by adding the unspecified dependency.

---
 drivers/crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/Kconfig +1 -1
index 91eb768d4221a..0a73bebd04e5d 100644
@@ -716,7 +716,7 @@ source "drivers/crypto/stm32/Kconfig"
 
 config CRYPTO_DEV_SAFEXCEL
 	tristate "Inside Secure's SafeXcel cryptographic engine driver"
-	depends on OF || PCI || COMPILE_TEST
+	depends on (OF || PCI || COMPILE_TEST) && HAS_IOMEM
 	select CRYPTO_LIB_AES
 	select CRYPTO_AUTHENC
 	select CRYPTO_SKCIPHER
Signature · 1 line
2.24.0.525.g8f36a354ae-goog
maintainer
#16 lore raw

Re: [PATCH v1 4/7] crypto: inside-secure: add unspecified HAS_IOMEM dependency

Quoted 7 lines · Brendan Higgins

Currently CONFIG_CRYPTO_DEV_SAFEXCEL=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/crypto/inside-secure/safexcel.o: in function `safexcel_probe':
drivers/crypto/inside-secure/safexcel.c:1692: undefined reference to `devm_platform_ioremap_resource'

Quoted 7 lines

Fix the build error by adding the unspecified dependency.

---
 drivers/crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 8 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um
#17 lore raw

PATCH 5/7 crypto: amlogic: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins

Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe':
drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource'

Fix the build error by adding the unspecified dependency.

---
 drivers/crypto/amlogic/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/crypto/amlogic/Kconfig +1 -0
index b90850d18965f..cf95476026708 100644
@@ -1,5 +1,6 @@
 config CRYPTO_DEV_AMLOGIC_GXL
 	tristate "Support for amlogic cryptographic offloader"
+	depends on HAS_IOMEM
 	default y if ARCH_MESON
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE
Signature · 1 line
2.24.0.525.g8f36a354ae-goog
maintainer Acked-by on v1 5/7
#18 lore raw

Re: [PATCH v1 5/7] crypto: amlogic: add unspecified HAS_IOMEM dependency

Quoted 20 lines · Brendan Higgins

Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe':
drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource'

Fix the build error by adding the unspecified dependency.

---
 drivers/crypto/amlogic/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/crypto/amlogic/Kconfig +0 -0
index b90850d18965f..cf95476026708 100644

drivers/crypto/amlogic/Kconfig line 6

Quoted 6 lines
drivers/crypto/amlogic/Kconfig +1 -0
@@ -1,5 +1,6 @@
 config CRYPTO_DEV_AMLOGIC_GXL
 	tristate "Support for amlogic cryptographic offloader"
+	depends on HAS_IOMEM
 	default y if ARCH_MESON
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE

Thanks

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um

maintainer
#19 lore raw

Re: [PATCH v1 5/7] crypto: amlogic: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins
Quoted 7 lines · Brendan Higgins

Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe':
drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource'

Quoted 7 lines

Fix the build error by adding the unspecified dependency.

---
 drivers/crypto/amlogic/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Patch applied. Thanks.

Signature · 8 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um
#20 lore raw

PATCH 6/7 staging: axis-fifo: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins

Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe':
drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

---
 drivers/staging/axis-fifo/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/axis-fifo/Kconfig +1 -1
index 3fffe4d6f327f..f180a8e9f58af 100644
@@ -4,7 +4,7 @@
 #
 config XIL_AXIS_FIFO
 	tristate "Xilinx AXI-Stream FIFO IP core driver"
-	depends on OF
+	depends on OF && HAS_IOMEM
 	help
 	  This adds support for the Xilinx AXI-Stream FIFO IP core driver.
 	  The AXI Streaming FIFO allows memory mapped access to a AXI Streaming
Signature · 1 line
2.24.0.525.g8f36a354ae-goog
#21 lore raw

Re: [PATCH v1 6/7] staging: axis-fifo: add unspecified HAS_IOMEM dependency

Quoted 11 lines · Brendan Higgins

Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe':
drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Saying you reported a problem and then fixed it kind of does a bit of disservice to the "reported-by:" tag which we normally use only to credit the people that do not actually fix the problem.

So in the future, no need for this to be there for patches that you write yourself.

thanks,

greg k-h

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um

#22 lore raw

Re: [PATCH v1 6/7] staging: axis-fifo: add unspecified HAS_IOMEM dependency

Quoted 14 lines · Greg Kroah-Hartman
Quoted 11 lines · Brendan Higgins

Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe':
drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Quoted 6 lines

Saying you reported a problem and then fixed it kind of does a bit of disservice to the "reported-by:" tag which we normally use only to credit the people that do not actually fix the problem.

So in the future, no need for this to be there for patches that you write yourself.

Alright, thanks for spelling that out. I will remember that in the future.

Cheers!

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um

#23 lore raw

PATCH 7/7 fsi: aspeed: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins

Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

---
 drivers/fsi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fsi/Kconfig +1 -0
index 92ce6d85802cc..4cc0e630ab79b 100644
@@ -55,6 +55,7 @@ config FSI_MASTER_AST_CF
 
 config FSI_MASTER_ASPEED
 	tristate "FSI ASPEED master"
+	depends on HAS_IOMEM
 	help
 	 This option enables a FSI master that is present behind an OPB bridge
 	 in the AST2600.
Signature · 1 line
2.24.0.525.g8f36a354ae-goog
Acked-by on v1 7/7
#24 lore raw

Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency

Quoted 5 lines · Brendan Higgins

Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

Quoted 7 lines

ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in order to build some ARM drivers under UM. Do you have plans to fix that too?

Do you want to get this in a fix for 5.5?

Cheers,

Joel

Quoted 19 lines
---
 drivers/fsi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fsi/Kconfig +1 -1
index 92ce6d85802cc..4cc0e630ab79b 100644
@@ -55,6 +55,7 @@ config FSI_MASTER_AST_CF
 
 config FSI_MASTER_ASPEED
        tristate "FSI ASPEED master"
+       depends on HAS_IOMEM
        help
         This option enables a FSI master that is present behind an OPB bridge
         in the AST2600.
--

2.24.0.525.g8f36a354ae-goog

#25 lore raw

Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency

Quoted 10 lines · Joel Stanley
Quoted 8 lines · Brendan Higgins

Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'

Quoted 8 lines
Quoted 4 lines

Fix the build error by adding the unspecified dependency.

Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in order to build some ARM drivers under UM. Do you have plans to fix that too?

The only broken configs I found for UML are all listed on the cover letter of this patch. I think fixing COMPILE_TEST on UM could be worthwhile. Did you see any brokenness other than what I mentioned on the cover letter?

Quoted 1 line

Do you want to get this in a fix for 5.5?

Preferably, yes.

Quoted 1 line

Thanks!

#26 lore raw

Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency

Quoted 11 lines · Brendan Higgins
Quoted 4 lines · Joel Stanley

Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in order to build some ARM drivers under UM. Do you have plans to fix that too?

The only broken configs I found for UML are all listed on the cover letter of this patch. I think fixing COMPILE_TEST on UM could be worthwhile. Did you see any brokenness other than what I mentioned on the cover letter?

There's a few more in drivers/char/hw_random that you would need. These were HW_RANDOM_MESON , HW_RANDOM_MTK, HW_RANDOM_EXYNOS, HW_RANDOM_NPCM, HW_RANDOM_KEYSTONE.

The only one from your series I needed was PINCTRL_EQUILIBRIUM.

I applied this:

init/Kconfig +0 -1
@@ -91,7 +91,6 @@ config INIT_ENV_ARG_LIMIT
 
 config COMPILE_TEST
        bool "Compile also drivers which will not load"
-       depends on !UML
        default n
        help
 

That lets me build. However, the code I was attempting to enable depends on REGMAP, which needs IOMEM too, so I hit that dead end.

Another issue I had was debugging my kunitconfig. This patch helped a bit:

tools/testing/kunit/kunit_config.py +3 -0
@@ -40,6 +40,9 @@ class Kconfig(object):
        def is_subset_of(self, other: 'Kconfig') -> bool:
                return self.entries().issubset(other.entries())
 
+       def difference(self, other: 'Kconfig') -> list:
+               return self.entries().difference(other.entries())
+
        def write_to_file(self, path: str) -> None:
                with open(path, 'w') as f:
                        for entry in self.entries():
(quoted diff) +0 -0

b/tools/testing/kunit/kunit_kernel.py
index bf3876835331..0f261bc087e4 100644

tools/testing/kunit/kunit_kernel.py +0 -0
@@ -107,6 +107,7 @@ class LinuxSourceTree(object):
                validated_kconfig.read_from_file(kconfig_path)
                if not self._kconfig.is_subset_of(validated_kconfig):
                        logging.error('Provided Kconfig is not

contained in validated .config!')
+ logging.error(self._kconfig.difference(validated_kconfig))
return False
return True

Which would need some tidying up before applying, but helped a lot in working out what was going wrong.

Quoted 8 lines
Quoted 2 lines

Do you want to get this in a fix for 5.5?

Preferably, yes.

Quoted 1 line

Thanks!

#27 lore raw

Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency

In reply to Brendan Higgins
Quoted 21 lines · Brendan Higgins
Quoted 10 lines · Joel Stanley
Quoted 8 lines · Brendan Higgins

Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error:

ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'

Quoted 8 lines
Quoted 4 lines

Fix the build error by adding the unspecified dependency.

Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in order to build some ARM drivers under UM. Do you have plans to fix that too?

Quoted 10 lines

The only broken configs I found for UML are all listed on the cover letter of this patch. I think fixing COMPILE_TEST on UM could be worthwhile. Did you see any brokenness other than what I mentioned on the cover letter?

Quoted 1 line

Do you want to get this in a fix for 5.5?

Preferably, yes.

Quoted 1 line

Hey, I know I owe you a reply about debugging your kunitconfig (I'll try to get to that this week); nevertheless, it looks like this patch didn't make it into 5.5. Can you make sure it gets into 5.6? It shouldn't depend on anything else.

Cheers

#28 lore raw

Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency

Quoted 10 lines · Brendan Higgins
Quoted 5 lines
Quoted 1 line

Do you want to get this in a fix for 5.5?

Preferably, yes.

Quoted 1 line

Hey, I know I owe you a reply about debugging your kunitconfig (I'll try to get to that this week); nevertheless, it looks like this patch didn't make it into 5.5. Can you make sure it gets into 5.6? It shouldn't depend on anything else.

Sure, thanks for the reminder.

Cheers,

Joel

#30 lore raw
Quoted 10 lines · Johannes Berg

(stripping CCs a lot)

Quoted 4 lines · Brendan Higgins

# TL;DR

This patchset adds a missing HAS_IOMEM dependency to several drivers in an attempt to get allyesconfig closer to working for ARCH=um.

Out of curiosity, how big does that monstrosity get? :)

A bit more than 4000 lines as opposed to over 13000 lines for x86 and ARM.

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um