spi: nxp-fspi: Ensure width is respected in spi-mem operations
Subsystems (2)
PATCH 1/1 spi: nxp-fspi: Ensure width is respected in spi-mem operations
Make use of a core helper to ensure the desired width is respected when calling spi-mem operators.
Otherwise only the SPI controller will be matched with the flash chip, which might lead to wrong widths. Also consider the width specified by the user in the device tree.
--- drivers/spi/spi-nxp-fspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-nxp-fspi.c +1 -1
@@ -439,7 +439,7 @@ static bool nxp_fspi_supports_op(struct spi_mem *mem, op->data.nbytes > f->devtype_data->txfifo)return false; -return true; +return spi_mem_default_supports_op (mem, op); }/* Instead of busy looping invoke readl_poll_timeout functionality. */
Signature · 1 line
2.20.1
Mark Brown
maintainerApplied "spi: nxp-fspi: Ensure width is respected in spi-mem operations" to the spi tree
The patch
spi: nxp-fspi: Ensure width is respected in spi-mem operations
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
007773e16a6f3f49d1439554078c3ba8af131998Mon Sep 17 00:00:00 2001
From: Michael Walle <[email protected]>
Date: Wed, 11 Dec 2019 20:57:30 +0100
Subject: [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem
operations
Make use of a core helper to ensure the desired width is respected when calling spi-mem operators.
Otherwise only the SPI controller will be matched with the flash chip, which might lead to wrong widths. Also consider the width specified by the user in the device tree.
--- drivers/spi/spi-nxp-fspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-nxp-fspi.c +1 -1
@@ -439,7 +439,7 @@ static bool nxp_fspi_supports_op(struct spi_mem *mem, op->data.nbytes > f->devtype_data->txfifo)return false; -return true; +return spi_mem_default_supports_op (mem, op); }/* Instead of busy looping invoke readl_poll_timeout functionality. */
Signature · 1 line
2.20.1
Hi Michael,
Quoted 11 lines
-----Original Message-----
From: [email protected] <linux-kernel- [email protected]> On Behalf Of Michael Walle
Sent: Thursday, December 12, 2019 1:28 AM
To: [email protected]; [email protected]
Cc: Yogesh Gaur <[email protected]>; Ashish Kumar <[email protected]>; Mark Brown <[email protected]>; Michael Walle <[email protected]>
Subject: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations
Quoted 8 lines
Caution: EXT Email
Make use of a core helper to ensure the desired width is respected when calling spi-mem operators.
Otherwise only the SPI controller will be matched with the flash chip, which might lead to wrong widths. Also consider the width specified by the user in the device tree.
Could you please mention the flash and modes you tested. Does it support DUAL/QUAD mode? I couldn't test these modes as NXP LS1028ARDB has "mt35xu02g" which supports SINGLE and OCTAL modes only.
Thanks
Kuldeep
Quoted 23 lines
Fixes a5356aef6a90 ("spi: spi-mem: Add driver for NXP FlexSPI controller")Signed-off-by Michael Walle <[email protected]>--- drivers/spi/spi-nxp-fspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/spi/spi-nxp-fspi.c index renamed from drivers/spi/spi-nxp-fspi.c +0
-0
c36bb1bb464e..8c5084a3a617100644drivers/spi/spi-nxp-fspi.c +1
-1@@ -439,7 +439,7 @@ static bool nxp_fspi_supports_op(struct spi_mem *mem, op->data.nbytes > f->devtype_data->txfifo)return false; -return true; +return spi_mem_default_supports_op (mem, op); }/* Instead of busy looping invoke
readl_poll_timeoutfunctionality. */
--
2.20.1
Am 2020-01-07 06:39, schrieb Kuldeep Singh:
Quoted 18 lines
Hi Michael,
Quoted 16 lines
-----Original Message-----
From: [email protected] <linux-kernel- [email protected]> On Behalf Of Michael Walle
Sent: Thursday, December 12, 2019 1:28 AM
To: [email protected]; [email protected]
Cc: Yogesh Gaur <[email protected]>; Ashish Kumar <[email protected]>; Mark Brown <[email protected]>; Michael Walle <[email protected]>
Subject: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operationsCaution: EXT Email
Make use of a core helper to ensure the desired width is respected when calling spi-mem operators.
Quoted 8 lines
Quoted 3 lines
Otherwise only the SPI controller will be matched with the flash chip, which might lead to wrong widths. Also consider the width specified by the user in the device tree.
Could you please mention the flash and modes you tested. Does it support DUAL/QUAD mode?
I couldn't test these modes as NXP LS1028ARDB has "mt35xu02g" which supports SINGLE and OCTAL modes only.
That commit is already upstream. But FWIW, it was a Winbond W25Q32FW in dual i/o mode.
-michael