drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel
PATCH 1/1 drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
V9:
- Adjust init code, make the format more concise
- kill off default_off_cmds (Emil)
- use mipi_dsi_dcs_set_display_{on,off} in their enable/disable callbacks. (Emil)
- Adjusting the delay function (Emil)
V8:
- modify PARENTHESIS_ALIGNMENT format (Sam)
- use gpios are required API replace optional gpio API (Emil)
V7:
- Modify communication address
V6:
- Add the information of the reviewer
- Remove unnecessary delays, The udelay_range code gracefully returns without hitting the scheduler on a delay of 0. (Derek)
- Merge the same data structures, like display_mode and off_cmds (Derek)
- Optimize the processing of results returned by devm_gpiod_get_optional (Derek)
V5:
- Add the information of the reviewer (Sam)
- Delete unnecessary header files #include <linux/fb.h> (Sam)
- The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)
- ADD static, set_gpios function is not used outside this module (Sam)
V4:
- Frefix all function maes with boe_ (Sam)
- Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
- Sort include lines alphabetically (Sam)
- Fixed entries in the makefile must be sorted alphabetically (Sam)
- Add send_mipi_cmds function to avoid duplicating the code (Sam)
- Add the necessary delay(reset_delay_t5) between reset and sending the initialization command (Rock wang)
V3:
- Remove unnecessary delays in sending initialization commands (Jitao Shi)
V2:
- Use SPDX identifier (Sam)
- Use necessary header files replace drmP.h (Sam)
- Delete unnecessary header files #include <linux/err.h> (Sam)
- Specifies a GPIOs array to control the reset timing, instead of reading "dsi-reset-sequence" data from DTS (Sam)
- Delete backlight_disable() function when already disabled (Sam)
- Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
- Move the necessary data in the DTS to the current file, like porch, display_mode and Init code etc. (Sam)
- Add compatible device "boe,himax8279d10p" (Sam)
V1:
- Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
--- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-boe-himax8279d.c | 988 +++++++++++++++++++ 4 files changed, 1006 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c
MAINTAINERS +6 -0
@@ -5135,6 +5135,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/bochs/ +DRM DRIVER FOR BOE HIMAX8279D PANELS +M: Jerry Han <[email protected]> +S: Maintained +F: drivers/gpu/drm/panel/panel-boe-himax8279d.c +F: Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt + DRM DRIVER FOR FARADAY TVE200 TV ENCODER M: Linus Walleij <[email protected]> T: git git://anongit.freedesktop.org/drm/drm-misc
drivers/gpu/drm/panel/Kconfig +11 -0
@@ -18,6 +18,17 @@ config DRM_PANEL_ARM_VERSATILE reference designs. The panel is detected using special registers in the Versatile family syscon registers. +config DRM_PANEL_BOE_HIMAX8279D + tristate "Boe Himax8279d panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for Boe Himax8279d + TFT-LCD modules. The panel has a 1200x1920 resolution and uses + 24 bit RGB per pixel. It provides a MIPI DSI interface to + the host and has a built-in LED backlight. + config DRM_PANEL_LVDS tristate "Generic LVDS panel driver" depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
@@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o +obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o
drivers/gpu/drm/panel/panel-boe-himax8279d.c new file +988 -0
988 lines not on this page · raw message
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 56 lines · Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
V9:
- Adjust init code, make the format more concise
- kill offdefault_off_cmds(Emil)
- use mipi_dsi_dcs_set_display_{on,off} in their enable/disable callbacks. (Emil)
- Adjusting the delay function (Emil)V8:
- modifyPARENTHESIS_ALIGNMENTformat (Sam)
- use gpios are required API replace optional gpio API (Emil)V7:
- Modify communication addressV6:
- Add the information of the reviewer
- Remove unnecessary delays, Theudelay_rangecode gracefully returns without hitting the scheduler on a delay of 0. (Derek)
- Merge the same data structures, likedisplay_modeandoff_cmds(Derek)
- Optimize the processing of results returned bydevm_gpiod_get_optional(Derek)V5:
- Add the information of the reviewer (Sam)
- Delete unnecessary header files #include <linux/fb.h> (Sam)
- The configDRM_PANEL_BOE_HIMAX8279Dappears twice. Drop one of them (Sam)
- ADD static,set_gpiosfunction is not used outside this module (Sam)V4:
- Frefix all function maes withboe_(Sam)
- Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
- Sort include lines alphabetically (Sam)
- Fixed entries in the makefile must be sorted alphabetically (Sam)
- Addsend_mipi_cmdsfunction to avoid duplicating the code (Sam)
- Add the necessarydelay(reset_delay_t5)between reset and sending the initialization command (Rock wang)V3:
- Remove unnecessary delays in sending initialization commands (Jitao Shi)V2:
- Use SPDX identifier (Sam)
- Use necessary header files replacedrmP.h(Sam)
- Delete unnecessary header files #include <linux/err.h> (Sam)
- Specifies a GPIOs array to control the reset timing, instead of reading "dsi-reset-sequence" data from DTS (Sam)
- Deletebacklight_disable()function when already disabled (Sam)
- Usedevm_of_find_backlight()replaceof_find_backlight_by_node()(Sam)
- Move the necessary data in the DTS to the current file, like porch,display_modeand Init code etc. (Sam)
- Add compatible device "boe,himax8279d10p" (Sam)
Quoted 8 lines
V1:
- Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.Signed-off-by Jerry Han <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>Reviewed-by Derek Basehore <[email protected]>Reviewed-by Emil Velikov <[email protected]>
v9 looks much better thanks. My R-B now stands:
Sam, care you give this a quick look and merge if you're happy with latest revision?
v9 have changed quite a bit since you've reviewed it - same functionality with 10% less code ;-)
-Emil
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Jerry.
Quoted 2 lines
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
Thanks for your persistence with this driver.
Unfortunately the driver no longer builds after the drm_panel work we committed earlier this week to drm-misc-next.
Quoted 7 lines
V9:
- Adjust init code, make the format more concise
- kill offdefault_off_cmds(Emil)
- use mipi_dsi_dcs_set_display_{on,off} in their enable/disable callbacks. (Emil)
- Adjusting the delay function (Emil)
...
drivers/gpu/drm/panel/panel-boe-himax8279d.c line 50
Quoted 7 lines
drivers/gpu/drm/panel/panel-boe-himax8279d.c new file +7
-0+ +struct panel_info { +struct drm_panel base; +struct mipi_dsi_device *link; +const struct panel_desc *desc; + +struct backlight_device *backlight;
We have included backlight support in drm_panel.
Can you please introduce this and post a patch updating the driver to use this.
See other panle patches what is required to use it. (Mostly deleting code)
I took a look at the rest of the driver and everything looks good.
Sorry for causing you this extra trouble due to the drm_panel changes.
Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 36 lines
Hi Jerry.
Quoted 2 lines
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
Thanks for your persistence with this driver.
Unfortunately the driver no longer builds after the
drm_panelwork we committed earlier this week to drm-misc-next.Quoted 7 lines
V9:
- Adjust init code, make the format more concise
- kill offdefault_off_cmds(Emil)
- use mipi_dsi_dcs_set_display_{on,off} in their enable/disable callbacks. (Emil)
- Adjusting the delay function (Emil)...
drivers/gpu/drm/panel/panel-boe-himax8279d.c line 50
Quoted 7 lines
drivers/gpu/drm/panel/panel-boe-himax8279d.c new file +7
-0+ +struct panel_info { +struct drm_panel base; +struct mipi_dsi_device *link; +const struct panel_desc *desc; + +struct backlight_device *backlight;We have included backlight support in
drm_panel.
Can you please introduce this and post a patch updating the driver to use this.
See other panle patches what is required to use it. (Mostly deleting code)
Quoted 5 lines
I took a look at the rest of the driver and everything looks good.
Sorry for causing you this extra trouble due to the
drm_panelchanges.Sam
Hi sam:
I'm happy to change the code for consistency.
I have provided the corresponding patch.
Thanks
Jerry
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel