Skip to contentSkip to conversation

tests/Makefile: Show check-report.tap in check-help

PATCH In review Wainer dos Santos Moschetta 3 participants 4 messages Dec 11, 2019 – Dec 12, 2019

lore
Share & tools
lore
#0 lore raw

cover tests/Makefile: Show check-report.tap in check-help

Simple fix to commit 9df43317b82 that didn't adjust check-help.

Wainer dos Santos Moschetta (1):
tests/Makefile: Fix check-report.* targets shown in check-help

 tests/Makefile.include | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 tests/Makefile: Fix check-report.* targets shown in check-help

The check-report.html and check-report.xml targets were replaced with check-report.tap in commit 9df43317b82 but the check-help text was not updated so it still lists check-report.html.

---
 tests/Makefile.include | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tests/Makefile.include +1 -3
index 8566f5f119..680bd8a669 100644
@@ -16,12 +16,10 @@ check-help:
 	@echo " $(MAKE) check-softfloat      Run FPU emulation tests"
 	@echo " $(MAKE) check-acceptance     Run all acceptance (functional) tests"
 	@echo
-	@echo " $(MAKE) check-report.html    Generates an HTML test report"
+	@echo " $(MAKE) check-report.tap     Generates an aggregated TAP test report"
 	@echo " $(MAKE) check-venv           Creates a Python venv for tests"
 	@echo " $(MAKE) check-clean          Clean the tests and related data"
 	@echo
-	@echo "Please note that HTML reports do not regenerate if the unit tests"
-	@echo "have not changed."
 	@echo
 	@echo "The variable SPEED can be set to control the gtester speed setting."
 	@echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"
Signature · 1 line
2.21.0
#2 lore raw

Re: [PATCH 1/1] tests/Makefile: Fix check-report.* targets shown in check-help

Quoted 19 lines · Wainer dos Santos Moschetta

The check-report.html and check-report.xml targets were replaced with check-report.tap in commit 9df43317b82 but the check-help text was not updated so it still lists check-report.html.

---
 tests/Makefile.include | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tests/Makefile.include +0 -0
index 8566f5f119..680bd8a669 100644
@@ -16,12 +16,10 @@ check-help:
 	@echo " $(MAKE) check-softfloat      Run FPU emulation tests"
 	@echo " $(MAKE) check-acceptance     Run all acceptance (functional) tests"
 	@echo

tests/Makefile.include check-help: · line 25

Quoted 10 lines
tests/Makefile.include +1 -3
-	@echo " $(MAKE) check-report.html    Generates an HTML test report"
+	@echo " $(MAKE) check-report.tap     Generates an aggregated TAP test report"
 	@echo " $(MAKE) check-venv           Creates a Python venv for tests"
 	@echo " $(MAKE) check-clean          Clean the tests and related data"
 	@echo
-	@echo "Please note that HTML reports do not regenerate if the unit tests"
-	@echo "have not changed."
 	@echo
 	@echo "The variable SPEED can be set to control the gtester speed setting."
 	@echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"
Reviewed-by on v1 1/1
#3 lore raw

Re: [PATCH 1/1] tests/Makefile: Fix check-report.* targets shown in check-help

In reply to Wainer dos Santos Moschetta
Quoted 19 lines · Wainer dos Santos Moschetta

The check-report.html and check-report.xml targets were replaced with check-report.tap in commit 9df43317b82 but the check-help text was not updated so it still lists check-report.html.

---
 tests/Makefile.include | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tests/Makefile.include +0 -0
index 8566f5f119..680bd8a669 100644
@@ -16,12 +16,10 @@ check-help:
 	@echo " $(MAKE) check-softfloat      Run FPU emulation tests"
 	@echo " $(MAKE) check-acceptance     Run all acceptance (functional) tests"
 	@echo

tests/Makefile.include check-help: · line 25

Quoted 10 lines
tests/Makefile.include +1 -3
-	@echo " $(MAKE) check-report.html    Generates an HTML test report"
+	@echo " $(MAKE) check-report.tap     Generates an aggregated TAP test report"
 	@echo " $(MAKE) check-venv           Creates a Python venv for tests"
 	@echo " $(MAKE) check-clean          Clean the tests and related data"
 	@echo
-	@echo "Please note that HTML reports do not regenerate if the unit tests"
-	@echo "have not changed."
 	@echo
 	@echo "The variable SPEED can be set to control the gtester speed setting."
 	@echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"