drm/panel: boe-himax8279d: use drm_panel backlight support
PATCH 1/1 drm/panel: boe-himax8279d: use drm_panel backlight support
Use the backlight support in drm_panel to simplify the driver
Signed-off-by Jerry Han <[email protected]>
Reviewed-by Sam Ravnborg <[email protected]>
--- drivers/gpu/drm/panel/panel-boe-himax8279d.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-)
drivers/gpu/drm/panel/panel-boe-himax8279d.c +3 -14
@@ -6,7 +6,6 @@* */ -#include <linux/backlight.h> #include <linux/delay.h> #include <linux/kernel.h> #include <linux/module.h>
@@ -47,7 +46,6 @@ struct panel_info {struct mipi_dsi_device *link;const struct panel_desc *desc; -struct backlight_device *backlight;struct gpio_desc *enable_gpio;struct gpio_desc *pp33_gpio;struct gpio_desc *pp18_gpio;
@@ -93,8 +91,6 @@ static int boe_panel_disable(struct drm_panel *panel)if (!pinfo->enabled)return 0 ; -backlight_disable (pinfo->backlight); - err =mipi_dsi_dcs_set_display_off (pinfo->link);if (err <0 ) { DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n",
@@ -218,13 +214,6 @@ static int boe_panel_enable(struct drm_panel *panel)return ret; } - ret =backlight_enable (pinfo->backlight); -if (ret) { -DRM_DEV_ERROR (panel->drm->dev, -"Failed to enable backlight %d\n" , ret); -return ret; - } - pinfo->enabled = true;return 0 ;
@@ -899,9 +888,9 @@ static int panel_add(struct panel_info *pinfo)return ret; } - pinfo->backlight =devm_of_find_backlight (dev); -if (IS_ERR (pinfo->backlight)) -return PTR_ERR (pinfo->backlight); + ret =drm_panel_of_backlight (&pinfo->base); +if (ret) +return ret;drm_panel_init (&pinfo->base, dev, &panel_funcs,DRM_MODE_CONNECTOR_DSI );
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Jerry.
Quoted 54 lines · Jerry Han
Use the backlight support in
drm_panelto simplify the driverSigned-off-by Jerry Han <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- drivers/gpu/drm/panel/panel-boe-himax8279d.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-)drivers/gpu/drm/panel/panel-boe-himax8279d.c +0
-11@@ -6,7 +6,6 @@* */ -#include <linux/backlight.h> #include <linux/delay.h> #include <linux/kernel.h> #include <linux/module.h> @@ -47,7 +46,6 @@ struct panel_info {struct mipi_dsi_device *link;const struct panel_desc *desc; -struct backlight_device *backlight;struct gpio_desc *enable_gpio;struct gpio_desc *pp33_gpio;struct gpio_desc *pp18_gpio;@@ -93,8 +91,6 @@ static int boe_panel_disable(struct drm_panel *panel)if (!pinfo->enabled)return 0 ; -backlight_disable (pinfo->backlight); - err =mipi_dsi_dcs_set_display_off (pinfo->link);if (err <0 ) { DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n",@@ -218,13 +214,6 @@ static int boe_panel_enable(struct drm_panel *panel)return ret; } - ret =backlight_enable (pinfo->backlight); -if (ret) { -DRM_DEV_ERROR (panel->drm->dev, -"Failed to enable backlight %d\n" , ret); -return ret; - } - pinfo->enabled = true;return 0 ;@@ -899,9 +888,9 @@ static int panel_add(struct panel_info *pinfo)return ret; }
drivers/gpu/drm/panel/panel-boe-himax8279d.c static int panel_add(struct panel_info *pinfo) · line 896
Quoted 10 lines
drivers/gpu/drm/panel/panel-boe-himax8279d.c +3
-3- pinfo->backlight =devm_of_find_backlight (dev); -if (IS_ERR (pinfo->backlight)) -return PTR_ERR (pinfo->backlight); + ret =drm_panel_of_backlight (&pinfo->base); +if (ret) +return ret;drm_panel_init (&pinfo->base, dev, &panel_funcs,DRM_MODE_CONNECTOR_DSI );
The patch looks good.
But we still need the original patch fixed so it can build.
Please resend a v11 that can build.
Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel