gcc-plugins: make it possible to disable CONFIG_GCC_PLUGINS again
PATCH 1/1 gcc-plugins: make it possible to disable CONFIG_GCC_PLUGINS again
I noticed that randconfig builds with gcc no longer produce a lot of ccache hits, unlike with clang, and traced this back to plugins now being enabled unconditionally if they are supported.
I am now working around this by adding
export CCACHE_COMPILERCHECK=/usr/bin/size -A %compiler%
to my top-level Makefile. This changes the heuristic that ccache uses to determine whether the plugins are the same after a 'make clean'.
However, it also seems that being able to just turn off the plugins is generally useful, at least for build testing it adds noticeable overhead but does not find a lot of bugs additional bugs, and may be easier for ccache users than my workaround.
--- scripts/gcc-plugins/Kconfig | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
scripts/gcc-plugins/Kconfig +4 -5
@@ -14,8 +14,8 @@ config HAVE_GCC_PLUGINS An arch should select this symbol if it supports building with GCC plugins. -config GCC_PLUGINS - bool +menuconfig GCC_PLUGINS + bool "GCC plugins" depends on HAVE_GCC_PLUGINS depends on PLUGIN_HOSTCC != "" default y
@@ -25,8 +25,7 @@ config GCC_PLUGINS See Documentation/core-api/gcc-plugins.rst for details. -menu "GCC plugins" - depends on GCC_PLUGINS +if GCC_PLUGINS config GCC_PLUGIN_CYC_COMPLEXITY bool "Compute the cyclomatic complexity of a function" if EXPERT
@@ -113,4 +112,4 @@ config GCC_PLUGIN_ARM_SSP_PER_TASK bool depends on GCC_PLUGINS && ARM -endmenu +endif
Signature · 1 line
2.20.0
Quoted 12 lines · Arnd Bergmann
I noticed that randconfig builds with gcc no longer produce a lot of ccache hits, unlike with clang, and traced this back to plugins now being enabled unconditionally if they are supported.
I am now working around this by adding
export CCACHE_COMPILERCHECK=/usr/bin/size -A %compiler%
to my top-level
Makefile. This changes the heuristic that ccache uses to determine whether the plugins are the same after a 'make clean'.
Quoted 7 lines
However, it also seems that being able to just turn off the plugins is generally useful, at least for build testing it adds noticeable overhead but does not find a lot of bugs additional bugs, and may be easier for ccache users than my workaround.
Fixes 9f671e58159a ("security: Create "kernel hardening" config area")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 38 lines
--- scripts/gcc-plugins/Kconfig | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)scripts/gcc-plugins/Kconfig +4
-6@@ -14,8 +14,8 @@ config HAVE_GCC_PLUGINS An arch should select this symbol if it supports building with GCC plugins. -config GCC_PLUGINS - bool +menuconfig GCC_PLUGINS + bool "GCC plugins" depends on HAVE_GCC_PLUGINS depends on PLUGIN_HOSTCC != "" default y@@ -25,8 +25,7 @@ config GCC_PLUGINS See Documentation/core-api/gcc-plugins.rst for details. -menu "GCC plugins" - depends on GCC_PLUGINS +if GCC_PLUGINS config GCC_PLUGIN_CYC_COMPLEXITY bool "Compute the cyclomatic complexity of a function" if EXPERT@@ -113,4 +112,4 @@ config GCC_PLUGIN_ARM_SSP_PER_TASK bool depends on GCC_PLUGINS && ARM -endmenu +endif --2.20.0
Quoted 12 lines · Arnd Bergmann
I noticed that randconfig builds with gcc no longer produce a lot of ccache hits, unlike with clang, and traced this back to plugins now being enabled unconditionally if they are supported.
I am now working around this by adding
export CCACHE_COMPILERCHECK=/usr/bin/size -A %compiler%
to my top-level
Makefile. This changes the heuristic that ccache uses to determine whether the plugins are the same after a 'make clean'.
Quoted 8 lines
However, it also seems that being able to just turn off the plugins is generally useful, at least for build testing it adds noticeable overhead but does not find a lot of bugs additional bugs, and may be easier for ccache users than my workaround.
Fixes 9f671e58159a ("security: Create "kernel hardening" config area")Signed-off-by Arnd Bergmann <[email protected]>---
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 23 lines · Masahiro Yamada
Quoted 12 lines · Arnd Bergmann
I noticed that randconfig builds with gcc no longer produce a lot of ccache hits, unlike with clang, and traced this back to plugins now being enabled unconditionally if they are supported.
I am now working around this by adding
export CCACHE_COMPILERCHECK=/usr/bin/size -A %compiler%
to my top-level
Makefile. This changes the heuristic that ccache uses to determine whether the plugins are the same after a 'make clean'.Quoted 7 lines
However, it also seems that being able to just turn off the plugins is generally useful, at least for build testing it adds noticeable overhead but does not find a lot of bugs additional bugs, and may be easier for ccache users than my workaround.
Fixes 9f671e58159a ("security: Create "kernel hardening" config area")Signed-off-by Arnd Bergmann <[email protected]>Reviewed-by Masahiro Yamada <[email protected]>
Quoted 1 line · Ard Biesheuvel
Acked-by Ard Biesheuvel <[email protected]>
Thanks! Who would be the best person to pick up the patch? Should I send it to Andrew?
Arnd
Kees Cook
Acked-byQuoted 23 lines · Arnd Bergmann
Quoted 22 lines · Masahiro Yamada
Quoted 19 lines · Arnd Bergmann
I noticed that randconfig builds with gcc no longer produce a lot of ccache hits, unlike with clang, and traced this back to plugins now being enabled unconditionally if they are supported.
I am now working around this by adding
export CCACHE_COMPILERCHECK=/usr/bin/size -A %compiler%
to my top-level
Makefile. This changes the heuristic that ccache uses to determine whether the plugins are the same after a 'make clean'.However, it also seems that being able to just turn off the plugins is generally useful, at least for build testing it adds noticeable overhead but does not find a lot of bugs additional bugs, and may be easier for ccache users than my workaround.
Fixes 9f671e58159a ("security: Create "kernel hardening" config area")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 8 lines
Quoted 1 line
Reviewed-by Masahiro Yamada <[email protected]>Quoted 1 line · Ard Biesheuvel
Acked-by Ard Biesheuvel <[email protected]>Thanks! Who would be the best person to pick up the patch? Should I send it to Andrew?
I can take it in my tree, or I'm happy to have Masahiro take it.
Signature · 1 line
Kees Cook
Quoted 34 lines · Kees Cook
Quoted 23 lines · Arnd Bergmann
Quoted 22 lines · Masahiro Yamada
Quoted 19 lines · Arnd Bergmann
I noticed that randconfig builds with gcc no longer produce a lot of ccache hits, unlike with clang, and traced this back to plugins now being enabled unconditionally if they are supported.
I am now working around this by adding
export CCACHE_COMPILERCHECK=/usr/bin/size -A %compiler%
to my top-level
Makefile. This changes the heuristic that ccache uses to determine whether the plugins are the same after a 'make clean'.However, it also seems that being able to just turn off the plugins is generally useful, at least for build testing it adds noticeable overhead but does not find a lot of bugs additional bugs, and may be easier for ccache users than my workaround.
Fixes 9f671e58159a ("security: Create "kernel hardening" config area")Signed-off-by Arnd Bergmann <[email protected]>Quoted 8 lines
Quoted 1 line
Reviewed-by Masahiro Yamada <[email protected]>Quoted 1 line · Ard Biesheuvel
Acked-by Ard Biesheuvel <[email protected]>Thanks! Who would be the best person to pick up the patch? Should I send it to Andrew?
Quoted 6 lines
Acked-by Kees Cook <[email protected]>I can take it in my tree, or I'm happy to have Masahiro take it.
--
Kees Cook
Kees,
Please apply it to your tree.
Thanks.
Signature · 2 lines
Best Regards Masahiro Yamada
Kees Cook
AppliedQuoted 37 lines · Masahiro Yamada
Quoted 36 lines · Kees Cook
Quoted 23 lines · Arnd Bergmann
Quoted 22 lines · Masahiro Yamada
Quoted 19 lines · Arnd Bergmann
I noticed that randconfig builds with gcc no longer produce a lot of ccache hits, unlike with clang, and traced this back to plugins now being enabled unconditionally if they are supported.
I am now working around this by adding
export CCACHE_COMPILERCHECK=/usr/bin/size -A %compiler%
to my top-level
Makefile. This changes the heuristic that ccache uses to determine whether the plugins are the same after a 'make clean'.However, it also seems that being able to just turn off the plugins is generally useful, at least for build testing it adds noticeable overhead but does not find a lot of bugs additional bugs, and may be easier for ccache users than my workaround.
Fixes 9f671e58159a ("security: Create "kernel hardening" config area")Signed-off-by Arnd Bergmann <[email protected]>Quoted 8 lines
Quoted 1 line
Reviewed-by Masahiro Yamada <[email protected]>Quoted 1 line · Ard Biesheuvel
Acked-by Ard Biesheuvel <[email protected]>Thanks! Who would be the best person to pick up the patch? Should I send it to Andrew?
Acked-by Kees Cook <[email protected]>
Quoted 7 lines
Quoted 4 lines
I can take it in my tree, or I'm happy to have Masahiro take it.
--
Kees CookKees,
Please apply it to your tree.
Thanks, applied!
Signature · 1 line
Kees Cook