drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel
PATCH 1/1 drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
V11:
- Use the backlight support in drm_panel to simplify the driver (Sam)
V10:
- Adjust init code, make the format more concise (Emil)
V9:
- kill off default_off_cmds (Emil)
- use mipi_dsi_dcs_set_display_{on,off} in their enable/disable callbacks. (Emil)
- Adjusting the delay function (Emil)
V8:
- modify PARENTHESIS_ALIGNMENT format (Sam)
- use gpios are required API replace optional gpio API (Emil)
V7:
- Modify communication address
V6:
- Add the information of the reviewer
- Remove unnecessary delays, The udelay_range code gracefully returns without hitting the scheduler on a delay of 0. (Derek)
- Merge the same data structures, like display_mode and off_cmds (Derek)
- Optimize the processing of results returned by devm_gpiod_get_optional (Derek)
V5:
- Add the information of the reviewer (Sam)
- Delete unnecessary header files #include <linux/fb.h> (Sam)
- The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)
- ADD static, set_gpios function is not used outside this module (Sam)
V4:
- Frefix all function maes with boe_ (Sam)
- Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
- Sort include lines alphabetically (Sam)
- Fixed entries in the makefile must be sorted alphabetically (Sam)
- Add send_mipi_cmds function to avoid duplicating the code (Sam)
- Add the necessary delay(reset_delay_t5) between reset and sending the initialization command (Rock wang)
V3:
- Remove unnecessary delays in sending initialization commands (Jitao Shi)
V2:
- Use SPDX identifier (Sam)
- Use necessary header files replace drmP.h (Sam)
- Delete unnecessary header files #include <linux/err.h> (Sam)
- Specifies a GPIOs array to control the reset timing, instead of reading "dsi-reset-sequence" data from DTS (Sam)
- Delete backlight_disable() function when already disabled (Sam)
- Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
- Move the necessary data in the DTS to the current file, like porch, display_mode and Init code etc. (Sam)
- Add compatible device "boe,himax8279d10p" (Sam)
V1:
- Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
--- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-boe-himax8279d.c | 977 +++++++++++++++++++ 4 files changed, 995 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c
MAINTAINERS +6 -0
@@ -5153,6 +5153,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/bochs/ +DRM DRIVER FOR BOE HIMAX8279D PANELS +M: Jerry Han <[email protected]> +S: Maintained +F: drivers/gpu/drm/panel/panel-boe-himax8279d.c +F: Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt + DRM DRIVER FOR FARADAY TVE200 TV ENCODER M: Linus Walleij <[email protected]> T: git git://anongit.freedesktop.org/drm/drm-misc
drivers/gpu/drm/panel/Kconfig +11 -0
@@ -18,6 +18,17 @@ config DRM_PANEL_ARM_VERSATILE reference designs. The panel is detected using special registers in the Versatile family syscon registers. +config DRM_PANEL_BOE_HIMAX8279D + tristate "Boe Himax8279d panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for Boe Himax8279d + TFT-LCD modules. The panel has a 1200x1920 resolution and uses + 24 bit RGB per pixel. It provides a MIPI DSI interface to + the host and has a built-in LED backlight. + config DRM_PANEL_LVDS tristate "Generic LVDS panel driver" depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
@@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o +obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o
drivers/gpu/drm/panel/panel-boe-himax8279d.c new file +977 -0
977 lines not on this page · raw message
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Jerry.
Thanks!
Quoted 5 lines · Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
V11:
- Use the backlight support indrm_panelto simplify the driver (Sam)
...
Quoted 11 lines
- Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
Signed-off-by Jerry Han <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>Reviewed-by Derek Basehore <[email protected]>Reviewed-by Emil Velikov <[email protected]>Reported-by kbuild test robot <[email protected]>Cc Jitao Shi <[email protected]>Cc Rock wang <[email protected]>---
Applied to drm-misc-next with the following changes:
- fix build in boe_panel_get_modes()
- fix backlight - drm_panel_of_backlight() must be called after drm_panel_init()
Sam
drivers/gpu/drm/panel/panel-boe-himax8279d.c +11 -10
@@ -219,26 +219,27 @@ static int boe_panel_enable(struct drm_panel *panel)return 0 ; } -static int boe_panel_get_modes (struct drm_panel *panel) +static int boe_panel_get_modes (struct drm_panel *panel, +struct drm_connector *connector) {struct panel_info *pinfo =to_panel_info (panel);const struct drm_display_mode *m = pinfo->desc->display_mode;struct drm_display_mode *mode; - mode =drm_mode_duplicate (panel->drm, m); + mode =drm_mode_duplicate (connector->dev, m);if (!mode) { -DRM_DEV_ERROR (panel->drm->dev,"failed to add mode %ux%u@%u\n" , +DRM_DEV_ERROR (pinfo->base.dev,"failed to add mode %ux%u@%u\n" , m->hdisplay, m->vdisplay, m->vrefresh);return -ENOMEM ; }drm_mode_set_name (mode); -drm_mode_probed_add (panel->connector, mode); +drm_mode_probed_add (connector, mode); - panel->connector->display_info.width_mm = pinfo->desc->width_mm; - panel->connector->display_info.height_mm = pinfo->desc->height_mm; - panel->connector->display_info.bpc = pinfo->desc->bpc; + connector->display_info.width_mm = pinfo->desc->width_mm; + connector->display_info.height_mm = pinfo->desc->height_mm; + connector->display_info.bpc = pinfo->desc->bpc;return 1 ; }
@@ -888,13 +889,13 @@ static int panel_add(struct panel_info *pinfo)return ret; } +drm_panel_init (&pinfo->base, dev, &panel_funcs, +DRM_MODE_CONNECTOR_DSI ); + ret =drm_panel_of_backlight (&pinfo->base);if (ret)return ret; -drm_panel_init (&pinfo->base, dev, &panel_funcs, -DRM_MODE_CONNECTOR_DSI ); -return drm_panel_add (&pinfo->base); }
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel