xen/balloon: fix ballooned page accounting without hotplug enabled
Juergen Gross
maintainerPATCH 1/1 xen/balloon: fix ballooned page accounting without hotplug enabled
When CONFIG_XEN_BALLOON_MEMORY_HOTPLUG is not defined reserve_additional_memory() will set balloon_stats.target_pages to a wrong value in case there are still some ballooned pages allocated via alloc_xenballooned_pages().
This will result in balloon_process() no longer be triggered when ballooned pages are freed in batches.
Reported-by Nicholas Tsirakis <[email protected]>
Signed-off-by Juergen Gross <[email protected]>
--- drivers/xen/balloon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/xen/balloon.c +2 -1
@@ -394,7 +394,8 @@ static struct notifier_block xen_memory_nb = {#else static enum bp_state reserve_additional_memory (void ) { - balloon_stats.target_pages = balloon_stats.current_pages; + balloon_stats.target_pages = balloon_stats.current_pages + + balloon_stats.target_unpopulated;return BP_ECANCELED ; }#endif /* CONFIG_XEN_BALLOON_MEMORY_HOTPLUG */
Signature · 1 line
2.16.4
Quoted 10 lines · Juergen Gross
When
CONFIG_XEN_BALLOON_MEMORY_HOTPLUGis not definedreserve_additional_memory()will set balloon_stats.target_pages to a wrong value in case there are still some ballooned pages allocated viaalloc_xenballooned_pages().This will result in
balloon_process()no longer be triggered when ballooned pages are freed in batches.Reported-by Nicholas Tsirakis <[email protected]>Signed-off-by Juergen Gross <[email protected]>
Reviewed-by Boris Ostrovsky <[email protected]>