media: imx7-mipi-csis: remove subdev_notifier
PATCH 1/1 media: imx7-mipi-csis: remove subdev_notifier
It was defined a notifier in the csi_state structure that is never allocated. And besides that it's unregister in the remove, even though it is a no-op, just remove both.
--- drivers/staging/media/imx/imx7-mipi-csis.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/media/imx/imx7-mipi-csis.c +0 -3
@@ -251,8 +251,6 @@ struct csi_state {struct mipi_csis_event events[MIPI_CSIS_NUM_EVENTS ]; -struct v4l2_async_notifier subdev_notifier; -struct csis_hw_reset hw_reset;struct regulator *mipi_phy_regulator;bool sink_linked;
@@ -1104,7 +1102,6 @@ static int mipi_csis_remove(struct platform_device *pdev)mipi_csis_debugfs_exit (state);v4l2_async_unregister_subdev (&state->mipi_sd); -v4l2_async_notifier_unregister (&state->subdev_notifier);pm_runtime_disable (&pdev->dev);mipi_csis_pm_suspend (&pdev->dev, true);
Signature · 1 line
2.24.0
Quoted 9 lines · Rui Miguel Silva
It was defined a notifier in the
csi_statestructure that is never allocated. And besides that it's unregister in the remove, even though it is a no-op, just remove both.Fixes 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7")Reported-by Hans Verkuil <[email protected]>Suggested-by Dan Carpenter <[email protected]>Suggested-by Philipp Zabel <[email protected]>Signed-off-by Rui Miguel Silva <[email protected]>
Quoted 25 lines
--- drivers/staging/media/imx/imx7-mipi-csis.c | 3 --- 1 file changed, 3 deletions(-)drivers/staging/media/imx/imx7-mipi-csis.c +0
-3@@ -251,8 +251,6 @@ struct csi_state {struct mipi_csis_event events[MIPI_CSIS_NUM_EVENTS ]; -struct v4l2_async_notifier subdev_notifier; -struct csis_hw_reset hw_reset;struct regulator *mipi_phy_regulator;bool sink_linked;@@ -1104,7 +1102,6 @@ static int mipi_csis_remove(struct platform_device *pdev)mipi_csis_debugfs_exit (state);v4l2_async_unregister_subdev (&state->mipi_sd); -v4l2_async_notifier_unregister (&state->subdev_notifier);pm_runtime_disable (&pdev->dev);mipi_csis_pm_suspend (&pdev->dev, true);
Quoted 9 lines · Rui Miguel Silva
It was defined a notifier in the
csi_statestructure that is never allocated. And besides that it's unregister in the remove, even though it is a no-op, just remove both.Fixes 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7")Reported-by Hans Verkuil <[email protected]>Suggested-by Dan Carpenter <[email protected]>Suggested-by Philipp Zabel <[email protected]>Signed-off-by Rui Miguel Silva <[email protected]>
Mismatch between this Signed-off-by and your email address. Is it OK if I use your linaro email in this Signed-off-by?
Regards,
Hans
Quoted 26 lines
--- drivers/staging/media/imx/imx7-mipi-csis.c | 3 --- 1 file changed, 3 deletions(-)drivers/staging/media/imx/imx7-mipi-csis.c +0
-3@@ -251,8 +251,6 @@ struct csi_state {struct mipi_csis_event events[MIPI_CSIS_NUM_EVENTS ]; -struct v4l2_async_notifier subdev_notifier; -struct csis_hw_reset hw_reset;struct regulator *mipi_phy_regulator;bool sink_linked;@@ -1104,7 +1102,6 @@ static int mipi_csis_remove(struct platform_device *pdev)mipi_csis_debugfs_exit (state);v4l2_async_unregister_subdev (&state->mipi_sd); -v4l2_async_notifier_unregister (&state->subdev_notifier);pm_runtime_disable (&pdev->dev);mipi_csis_pm_suspend (&pdev->dev, true);
Hi Hans,
Quoted 5 lines · Hans Verkuil
Quoted 4 lines · Rui Miguel Silva
It was defined a notifier in the
csi_statestructure that is never allocated. And besides that it's unregister in the remove, even though it is a no-op, just remove both.
Quoted 8 lines
Quoted 5 lines
Fixes 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiversubdev for i.MX7") Reported-by: Hans Verkuil <[email protected]>
Suggested-by Dan Carpenter <[email protected]>Suggested-by Philipp Zabel <[email protected]>Signed-off-by Rui Miguel Silva <[email protected]>Mismatch between this Signed-off-by and your email address. Is it OK if I use your linaro email in this Signed-off-by?
Yeah, no problem. go ahead. Thanks.
------
Cheers,
Rui
Quoted 30 lines
Regards,
Hans
Quoted 24 lines
---
drivers/staging/media/imx/imx7-mipi-csis.c| 3 ---1 file changed, 3 deletions(-)(quoted diff) +0
-0
b/drivers/staging/media/imx/imx7-mipi-csis.cindex99166afca071..383abecb3bec100644 ---a/drivers/staging/media/imx/imx7-mipi-csis.c+++b/drivers/staging/media/imx/imx7-mipi-csis.c@@ -251,8 +251,6 @@ structcsi_state{drivers/staging/media/imx/imx7-mipi-csis.c +0
-1struct mipi_csis_event events[MIPI_CSIS_NUM_EVENTS ]; -struct v4l2_async_notifier subdev_notifier; - struct
csis_hw_resethw_reset; struct regulator*mipi_phy_regulator; boolsink_linked; @@ -1104,7 +1102,6 @@ static intmipi_csis_remove(struct platform_device *pdev)drivers/staging/media/imx/imx7-mipi-csis.c +0
-0mipi_csis_debugfs_exit (state);v4l2_async_unregister_subdev (&state->mipi_sd); -v4l2_async_notifier_unregister (&state->subdev_notifier);pm_runtime_disable (&pdev->dev);mipi_csis_pm_suspend (&pdev->dev, true);