Skip to contentSkip to conversation

dt-bindings: media: Convert Allwinner hardware codec to a schema

PATCH Applied Maxime Ripard 3 participants 4 messages Dec 13, 2019 – Dec 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: media: Convert Allwinner hardware codec to a schema

The Allwinner SoCs have a hardware video codec that is supported in Linux, with a matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas.

---
 .../allwinner,sun4i-a10-video-engine.yaml     | 83 +++++++++++++++++++
 .../devicetree/bindings/media/cedrus.txt      | 57 -------------
 2 files changed, 83 insertions(+), 57 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/cedrus.txt
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml new file +83 -0
new file mode 100644
index 000000000000..47c8513555b2
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: GPL-2.0+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/allwinner,sun4i-a10-video-engine.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner A10 Video Engine Device Tree Bindings
+
+maintainers:
+  - Chen-Yu Tsai <[email protected]>
+  - Maxime Ripard <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - allwinner,sun4i-a10-video-engine
+      - allwinner,sun5i-a13-video-engine
+      - allwinner,sun7i-a20-video-engine
+      - allwinner,sun8i-a33-video-engine
+      - allwinner,sun8i-h3-video-engine
+      - allwinner,sun50i-a64-video-engine
+      - allwinner,sun50i-h5-video-engine
+      - allwinner,sun50i-h6-video-engine
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: Bus Clock
+      - description: Module Clock
+      - description: RAM Clock
+
+  clock-names:
+    items:
+      - const: ahb
+      - const: mod
+      - const: ram
+
+  resets:
+    maxItems: 1
+
+  allwinner,sram:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description: Phandle to the device SRAM
+
+  memory-region:
+    description:
+      CMA pool to use for buffers allocation instead of the default
+      CMA pool.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - resets
+  - allwinner,sram
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/sun7i-a20-ccu.h>
+    #include <dt-bindings/reset/sun4i-a10-ccu.h>
+
+    video-codec@1c0e000 {
+        compatible = "allwinner,sun7i-a20-video-engine";
+        reg = <0x01c0e000 0x1000>;
+        interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&ccu CLK_AHB_VE>, <&ccu CLK_VE>,
+                 <&ccu CLK_DRAM_VE>;
+        clock-names = "ahb", "mod", "ram";
+        resets = <&ccu RST_VE>;
+        allwinner,sram = <&ve_sram 1>;
+    };
+
+...
Documentation/devicetree/bindings/media/cedrus.txt deleted +0 -57

57 lines not on this page · raw message

Signature · 1 line
2.23.0
#1 lore raw
Quoted 21 lines · Maxime Ripard

The Allwinner SoCs have a hardware video codec that is supported in Linux, with a matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas.

---
 .../allwinner,sun4i-a10-video-engine.yaml     | 83 +++++++++++++++++++
 .../devicetree/bindings/media/cedrus.txt      | 57 -------------
 2 files changed, 83 insertions(+), 57 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/cedrus.txt
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml new file +0 -0
new file mode 100644
index 000000000000..47c8513555b2

Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml line 1

Quoted 1 line
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml new file +1 -0
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: GPL-2.0+

Do you have rights to change the license (adding '+' aka '-or-later')? If so, please add BSD-2-Clause. I don't have any other comments, so just confirm and I can change it when applying.

Rob

#2 lore raw

Hi Rob,

Quoted 16 lines · Rob Herring
Quoted 15 lines · Maxime Ripard

The Allwinner SoCs have a hardware video codec that is supported in Linux, with a matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas.

---
 .../allwinner,sun4i-a10-video-engine.yaml     | 83 +++++++++++++++++++
 .../devicetree/bindings/media/cedrus.txt      | 57 -------------
 2 files changed, 83 insertions(+), 57 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/cedrus.txt
Quoted 11 lines

Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml line 1

Quoted 7 lines
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml new file +1 -0
new file mode 100644
index 000000000000..47c8513555b2
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: GPL-2.0+

Do you have rights to change the license (adding '+' aka '-or-later')? If so, please add BSD-2-Clause. I don't have any other comments, so just confirm and I can change it when applying.

That's a mistake, sorry. I'm not the original author, so I can't change that license...

Maxime

maintainer Applied
#3 lore raw
In reply to Maxime Ripard
Quoted 6 lines · Maxime Ripard

The Allwinner SoCs have a hardware video codec that is supported in Linux, with a matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas.

Quoted 8 lines
---
 .../allwinner,sun4i-a10-video-engine.yaml     | 83 +++++++++++++++++++
 .../devicetree/bindings/media/cedrus.txt      | 57 -------------
 2 files changed, 83 insertions(+), 57 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/cedrus.txt

Applied, thanks.

Rob