Skip to contentSkip to conversation

dt-bindings: ata: Convert Allwinner AHCI controller to a schema

PATCH Applied Maxime Ripard 2 participants 2 messages Dec 13, 2019 – Dec 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: ata: Convert Allwinner AHCI controller to a schema

The Allwinner SoCs have a AHCI controllers that is supported in Linux, with a matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas.

---
 .../devicetree/bindings/ata/ahci-platform.txt | 12 ----
 .../ata/allwinner,sun4i-a10-ahci.yaml         | 47 +++++++++++++
 .../ata/allwinner,sun8i-r40-ahci.yaml         | 67 +++++++++++++++++++
 3 files changed, 114 insertions(+), 12 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
 create mode 100644 Documentation/devicetree/bindings/ata/allwinner,sun8i-r40-ahci.yaml
Documentation/devicetree/bindings/ata/ahci-platform.txt +0 -12
index 55c6fab1b373..77091a277642 100644
@@ -9,8 +9,6 @@ PHYs.
 
 Required properties:
 - compatible        : compatible string, one of:
-  - "allwinner,sun4i-a10-ahci"
-  - "allwinner,sun8i-r40-ahci"
   - "brcm,iproc-ahci"
   - "hisilicon,hisi-ahci"
   - "cavium,octeon-7130-ahci"
@@ -45,8 +43,6 @@ Required properties when using sub-nodes:
 - #address-cells    : number of cells to encode an address
 - #size-cells       : number of cells representing the size of an address
 
-For allwinner,sun8i-r40-ahci, the reset property must be present.
-
 Sub-nodes required properties:
 - reg		    : the port number
 And at least one of the following properties:
@@ -60,14 +56,6 @@ Examples:
 		interrupts = <115>;
         };
 
-	ahci: sata@1c18000 {
-		compatible = "allwinner,sun4i-a10-ahci";
-		reg = <0x01c18000 0x1000>;
-		interrupts = <56>;
-		clocks = <&pll6 0>, <&ahb_gates 25>;
-		target-supply = <&reg_ahci_5v>;
-	};
-
 With sub-nodes:
 	sata@f7e90000 {
 		compatible = "marvell,berlin2q-achi", "generic-ahci";
Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml new file +47 -0

47 lines not on this page · raw message

Documentation/devicetree/bindings/ata/allwinner,sun8i-r40-ahci.yaml new file +67 -0

67 lines not on this page · raw message

Signature · 1 line
2.23.0
maintainer Applied
#1 lore raw
Quoted 6 lines · Maxime Ripard

The Allwinner SoCs have a AHCI controllers that is supported in Linux, with a matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas.

Quoted 9 lines
---
 .../devicetree/bindings/ata/ahci-platform.txt | 12 ----
 .../ata/allwinner,sun4i-a10-ahci.yaml         | 47 +++++++++++++
 .../ata/allwinner,sun8i-r40-ahci.yaml         | 67 +++++++++++++++++++
 3 files changed, 114 insertions(+), 12 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
 create mode 100644 Documentation/devicetree/bindings/ata/allwinner,sun8i-r40-ahci.yaml

Applied, thanks.

Rob