Skip to contentSkip to conversation

mac80211: he_support was not set when bringing up a HE mesh interface

PATCH In review John Crispin 2 participants 2 messages Dec 13, 2019 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211: he_support was not set when bringing up a HE mesh interface

From: Pradeep Kumar Chitrapu <[email protected]>

The he_support flag inside bss_conf was not set when a HE mesh interface gets created. This causes the drivers to not set the HW up correctly.

Fixes 60ad72da55ac ("mac80211: implement HE support for mesh")
---
 net/mac80211/mesh.c | 2 ++
 1 file changed, 2 insertions(+)
net/mac80211/mesh.c +2 -0
index d09b3c789314..98d70f4ef6a4 100644
@@ -551,6 +551,8 @@ int mesh_add_he_cap_ie(struct ieee80211_sub_if_data *sdata,
 	    sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10)
 		return 0;
 
+	sdata->vif.bss_conf.he_support = 1;
+
 	if (skb_tailroom(skb) < ie_len)
 		return -ENOMEM;
 
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 5 lines

From: Pradeep Kumar Chitrapu <[email protected]>

The he_support flag inside bss_conf was not set when a HE mesh interface gets created. This causes the drivers to not set the HW up correctly.

This is all wrong ... it doesn't even explain the change.

Also, the subject? Really? I know you can all do better.

Quoted 3 lines
Fixes 60ad72da55ac ("mac80211: implement HE support for mesh")
Cc Sven Eckelmann <[email protected]>

The fixes should also be part of the footer.

johannes