gpio: tegra186: Allow building on Tegra194-only configurations
PATCH 1/1 gpio: tegra186: Allow building on Tegra194-only configurations
From: Thierry Reding <[email protected]>
The driver is compatible with both Tegra186 and Tegra194, but currently it cannot be selected if only Tegra194 support is enabled. Allow builds with only Tegra194 support enabled to select this driver.
While at it, select this driver by default on Tegra194 builds because it is an essential part of the system.
---
Note: One other option would be to simplify this and depend only on ARCH_TEGRA, like we do for GPIO_TEGRA. This has the slighty disadvantage that it will be built by default on all Tegra platforms, so it will end up unused in many cases.
For now, I decided to just add the Tegra194 SoC configuration to the conditionals, but it might be worth reconsidering the above-mentioned simplification if this driver is applicable to any other future chips.
Thierry
drivers/gpio/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/Kconfig +2 -2
@@ -553,8 +553,8 @@ config GPIO_TEGRA config GPIO_TEGRA186 tristate "NVIDIA Tegra186 GPIO support" - default ARCH_TEGRA_186_SOC - depends on ARCH_TEGRA_186_SOC || COMPILE_TEST + default ARCH_TEGRA_186_SOC || ARCH_TEGRA_194_SOC + depends on ARCH_TEGRA_186_SOC || ARCH_TEGRA_194_SOC || COMPILE_TEST depends on OF_GPIO select GPIOLIB_IRQCHIP select IRQ_DOMAIN_HIERARCHY
Signature · 1 line
2.23.0
Quoted 10 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The driver is compatible with both Tegra186 and Tegra194, but currently it cannot be selected if only Tegra194 support is enabled. Allow builds with only Tegra194 support enabled to select this driver.
While at it, select this driver by default on Tegra194 builds because it is an essential part of the system.
Signed-off-by Thierry Reding <[email protected]>
Patch applied for fixes, it seems like it should be -rc material.
Yours,
Linus Walleij